July 2025 - Wine-GitLab - list.winehq.org

[PATCH v10 0/2] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 10, 2025

July 10, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v10: ntdll: Also restore rbp before calling user mode callback. user32/tests: Test unwinding through a user callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

3 4

[PATCH v15 0/4] MR8478: cfgmgr32: Device query API part 2: Implement object properties and initial device enumeration in DevCreateObjectQuery
by Vibhav Pant (＠vibhavp) July 10, 2025

July 10, 2025

-- v15: cfgmgr32: Support fetching properties for device objects in Dev{GetObjects, CreateObjectQueryEx}. cfgmgr32: Implement initial device enumeration for DevCreateObjectQuery. cfgmgr32: Stub DevCreateObjectQuery(Ex) functions. cfgmgr32/tests: Add tests for fetching specific properties in DevGetObjects. https://gitlab.winehq.org/wine/wine/-/merge_requests/8478

3 6

[PATCH v3 0/8] MR8505: mfsrcsnk, winegstreamer: Implement thinning.
by Charlotte Pabst (＠CharlottePabst) July 10, 2025

July 10, 2025

Follow-up to !8184. This also adds a bunch of helpers for writing media source tests (without involving the mf session) in mfsrcsnk, these could be helpful for more tests of this kind in the future. I'm somewhat unsure as to why we haven't done tests for source behavior so far: while those are plugins, applications rely on a bunch of things in the builtin sources that microsoft provides. Since this affects both mfsrcsnk and winegstreamer sources, tests should be run both with `HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler` enabled and disabled. Due to this I figured it'd make sense to implement everything first and then remove the test todo_wine's and the statements rejecting the thin parameter in a single commit ("Allow thinning"). Perhaps this could be solved more nicely by setting the registry key in the tests themselves? I'm unsure if that is something we do in tests, generally. `MEStreamThinMode` events need to be emitted between the last sample using the outdated thinning parameter and the first sample using the updated thinning parameter. The winegstreamer implementation for this turned out a bit complex, if there is a simpler way to do this please let me know. Regarding winegstreamer, note that buffers need to be intercepted before the decoder because decoders often discard `GST_BUFFER_FLAG_DELTA_UNIT` flags (which is already annoying in itself - it causes all samples to be marked as `MFSampleExtension_CleanPoint`, this should potentially be worked around in the future). But even besides that, intercepting before the decoder is the "proper" implementation, since the point of thinning is increasing decoding speed by skipping delta frames, tho there are some games that rely on the semantics as well. -- v3: mfsrcsnk: Emit MEStreamThinMode event. mfsrcsnk: Move media_source_send_sample. mfsrcsnk: Implement thinning. winedmo: Implement thinning. winedmo: Generate missing timestamps. winegstreamer: Implement thinning in media source. winegstreamer: Implement thinning in wg_parser. mfsrcsnk/tests: Add tests for thinning. https://gitlab.winehq.org/wine/wine/-/merge_requests/8505

3 11

[PATCH v2 0/1] MR8541: server: Keep owned mutex syncs alive until abandoned.
by Rémi Bernon July 10, 2025

July 10, 2025

Fixes: 672c3a561f5cd1cd6937c702fe2fe05397f41375 Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/8538, with test case derived from @tclem repro case, thanks! -- v2: server: Keep owned mutex syncs alive until abandoned. https://gitlab.winehq.org/wine/wine/-/merge_requests/8541

1 2

[PATCH 0/1] MR8508: cfgmgr32: Preserve registry casing when getting device interface list.
by Arek Hiler (＠ivyl) July 10, 2025

July 10, 2025

This fixes SDL3 wrongly using their HIDAPI backend for XInput devices on Wine due to a case-sensitive check for `&IG_`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8508

3 3

[PATCH 0/1] MR8538: server: Release mutexes upon their destruction.
by Tim Clem (＠tclem) July 10, 2025

July 10, 2025

Fixes a regression with 672c3a561f5. --- A few applications (Quicken, some Wine Mono tests) hit this server assertion after the 10.11 merge: ``` Assertion failed: (mutex->owner == thread), function abandon_mutexes, file mutex.c, line 244. ``` I'm not sure that this patch is correct, exactly. But the current situation is that `mutex_destroy` frees its mutex's sync object, but leaves it in its owning thread's list of `mutex_sync`s. So later, `abandon_mutexes` will enumerate it, which is a UAF. If the memory got stomped on in the meantime (or zeroed, as macOS' `free` does recently), it will hit the above assertion. Arguably I suppose this could call `mutex_sync_destroy` instead of the direct `do_release`? Also should this do a `release_object` on the `struct mutex *` itself? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8538

3 5

[PATCH 0/1] MR8541: server: Keep owned mutex syncs alive until abandoned.
by Rémi Bernon July 10, 2025

July 10, 2025

Fixes: 672c3a561f5cd1cd6937c702fe2fe05397f41375 Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/8538, with test case derived from @tclem repro case, thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8541

1 1

[PATCH v8 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 10, 2025

July 10, 2025

-- v8: setupapi: Support in-built properties in SetupDiGetDevicePropertyW and CM_Get_DevNode_Property_ExW. ntoskrnl.exe/tests: Add tests for built-in properties for PnP device instances. setupapi/tests: Add tests for inbuilt device properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/8515

2 6

[PATCH v7 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 10, 2025

July 10, 2025

-- v7: setupapi: Support in-built properties in SetupDiGetDevicePropertyW and CM_Get_DevNode_Property_ExW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8515

3 11

[PATCH v9 0/2] MR8258: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
by Jacob Czekalla (＠JacobCzekalla) July 10, 2025

July 10, 2025

comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. LButtonDown should return when the treeview handle is invalid (e.g. destroyed) after NM_CLICK to prevent further message processing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58211 -- v9: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. https://gitlab.winehq.org/wine/wine/-/merge_requests/8258

2 2