July 2025 - Wine-GitLab - list.winehq.org

[PATCH v4 0/1] MR8479: ntdll: Treat XDG_DATA_DIRS as special env variable
by Mike Kozelkov (＠augenzi) July 7, 2025

July 7, 2025

This solution was introduced in !7901, but it still open without any review. More info in the original MR. Also I should note that GTK uses XDG_DATA_DIRS and XDG_HOME_DIRS environment variables to locate icon themes and MIME information. This solution fixes: https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 -- v4: ntdll: Treat XDG_DATA_DIRS as special env variable https://gitlab.winehq.org/wine/wine/-/merge_requests/8479

3 4

[PATCH 0/2] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 7, 2025

July 7, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515

2 3

Re: [PATCH v8 0/2] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 7, 2025

July 7, 2025

changes: - check %rbp like Paul suggested. - use asm macros instead of asm() directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8466#note_109000

1 0

[PATCH v7 0/2] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 7, 2025

July 7, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v7: ntdll: Also restore rbp before calling user mode callback. user32/tests: Test unwinding through a user callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

2 2

[PATCH v6 0/2] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 7, 2025

July 7, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v6: ntdll: Also restore rbp before calling user mode callback. user32/tests: Test unwinding through a user callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

3 7

[PATCH v2 0/7] MR8415: mf: Get rid of the IMFMediaShutdownNotify interface.
by Rémi Bernon July 7, 2025

July 7, 2025

As discussed in !8402. @cmccarthy what do you think of this? I think queueing an event right before shutting down the queue is enough to get the media session notified? It won't get the actual event but it will be able to see the MF_E_SHUTDOWN error after calling `EndGetEvent`? -- v2: include: Remove now unnecessary IMFMediaShutdownNotify interface. mf/session: Remove now unnecessary IMFMediaShutdownNotify. winegstreamer: Remove now unnecessary IMFMediaShutdownNotify. mf/session: Handle an optional MEError event from sources on shutdown. winegstreamer: Queue an event before shutting down the event queues. mfsrcsnk: Queue an event before shutting down the event queues. mfplat/tests: Add more tests for event queue shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/8415

3 13

[PATCH 0/1] MR8489: wined3d: Use __WINE_CRT_PRINTF_ATTR.
by Jacek Caban (＠jacek) July 7, 2025

July 7, 2025

This enables the format attribute in Clang builds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8489

4 3

[PATCH 0/1] MR8472: wined3d: Fix double-free when shader_set_function fails.
by Yuxuan Shui (＠yshui) July 7, 2025

July 7, 2025

shader_set_function is inconsistent in whether it will cleanup the shader before returning an error. Most of the callers of shader_set_function will do the cleanup, which could double-free; but not all of them do, which means there are also potential leaks. So make sure all callers do, and remove shader_cleanup calls from shader_set_function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8472

4 3

[PATCH v4 0/3] MR8507: widl: Drop an incorrect check on runtimeclass definitions.
by Hans Leidekker (＠hans) July 7, 2025

July 7, 2025

-- v4: widl: Store the runtimeclass for constructor interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/8507

3 5

[PATCH v3 0/1] MR8479: ntdll: Treat XDG_DATA_DIRS as special env variable
by Mike Kozelkov (＠augenzi) July 7, 2025

July 7, 2025

This solution was introduced in !7901, but it still open without any review. More info in the original MR. Also I should note that GTK uses XDG_DATA_DIRS and XDG_HOME_DIRS environment variables to locate icon themes and MIME information. This solution fixes: https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 -- v3: ntdll: Treat XDG_DATA_DIRS as special env variable https://gitlab.winehq.org/wine/wine/-/merge_requests/8479

2 1