August 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR8813: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) Aug. 22, 2025

Aug. 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8813

1 0

Re: [PATCH v2 0/1] MR8805: vkd3d: Import upstream release 1.17. - approved
by Alexandre Julliard (＠julliard) Aug. 22, 2025

Aug. 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8805

1 0

[PATCH v8 0/1] MR8786: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 22, 2025

Aug. 22, 2025

Commit 518e394794160818ffe6826c874ff2f550c95bbb introduced new and important default behavior for PE binaries built using `winegcc`/`wineg++`/`winebuild`. * `/DYNAMICBASE` - Generates an executable image that can be randomly rebased at load time by using the address space layout randomization (ASLR) feature of Windows that was first available in Windows Vista. * `/HIGHENTROPYVA` - Randomized 64-bit virtual addresses make it more difficult for an attacker to guess the location of a particular memory region. ... however as identified in https://bugs.winehq.org/show_bug.cgi?id=58480, this new default behavior can severely impact applications that interact with binaries created for Windows XP and older. This is quite common for legacy audio plugins, such as VST2(TM) plugins. This MR keeps the new default "dynamicbase" and "highentropyva" flags by default, but mirrors the mingw/msys2 `--disable-dynamicbase` flag as explained here: https://www.msys2.org/news/#2021-01-31-aslr-enabled-by-default. MSVC also provides a similarly named flag [here](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase). Downstream, the LMMS project has successfully deployed the mingw flag and the MSVC flag for our Windows builds. Our Linux builds use a custom wine-bridge and would benefit from the same. We've currently tested this MR downstream against a snapshot of master branch to passing results. Downstream PRs: * Linux: https://github.com/LMMS/lmms/pull/7987 * Windows: https://github.com/LMMS/lmms/pull/7976 -- v8: winebuild: Add flag to disable dynamicbase/aslr https://gitlab.winehq.org/wine/wine/-/merge_requests/8786

3 2

[PATCH 0/2] MR8823: d2d1: Add some helpers for geometry figure manipulation.
by Nikolay Sivov (＠nsivov) Aug. 22, 2025

Aug. 22, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8823

2 2

[PATCH 0/6] MR8821: mshtml: Implement DOMParser.
by Gabriel Ivăncescu Aug. 22, 2025

Aug. 22, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8821

2 10

[PATCH v6 0/5] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 22, 2025

Aug. 22, 2025

Commit 518e394794160818ffe6826c874ff2f550c95bbb introduced new and important default behavior for PE binaries built using `winegcc`/`wineg++`/`winebuild`. * `/DYNAMICBASE` - Generates an executable image that can be randomly rebased at load time by using the address space layout randomization (ASLR) feature of Windows that was first available in Windows Vista. * `/HIGHENTROPYVA` - Randomized 64-bit virtual addresses make it more difficult for an attacker to guess the location of a particular memory region. ... however as identified in https://bugs.winehq.org/show_bug.cgi?id=58480, this new default behavior can severely impact applications that interact with binaries created for Windows XP and older. This is quite common for legacy audio plugins, such as VST2(TM) plugins. This MR keeps the new default "dynamicbase" and "highentropyva" flags by default, but mirrors the mingw/msys2 `--disable-dynamicbase` flag as explained here: https://www.msys2.org/news/#2021-01-31-aslr-enabled-by-default. MSVC also provides a similarly named flag [here](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase). Downstream, the LMMS project has successfully deployed the mingw flag and the MSVC flag for our Windows builds. Our Linux builds use a custom wine-bridge and would benefit from the same. We've currently tested this MR downstream against a snapshot of master branch to passing results. Downstream PRs: * Linux: https://github.com/LMMS/lmms/pull/7987 * Windows: https://github.com/LMMS/lmms/pull/7976 -- v6: Simplify https://gitlab.winehq.org/wine/wine/-/merge_requests/8786

2 7

[PATCH 0/1] MR8820: winewayland: Mark only windows with per-pixel alpha as layered.
by Alexandros Frantzis (＠afrantzis) Aug. 22, 2025

Aug. 22, 2025

This avoids using buffers with an alpha channel for windows that use SetLayeredWindowAttributes() and don't really utilize per-pixel alpha. Fixes: 6f8f5fe7bf989ba1429bc42114091e8416ad1a7c Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58504 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8820

2 1

[PATCH 0/3] MR8812: winegstreamer: Support 2D sample buffer.
by Conor McCarthy (＠cmccarthy) Aug. 22, 2025

Aug. 22, 2025

Performance issues can occur when a video output sample has a 2D buffer, because winegstreamer currently outputs only to a linear buffer, which must then be copied into the 2D buffer. Worse, a linear lock of the 2D buffer requires the current contents to be copied to a linear buffer, even when we intend to overwrite it, because MF linear buffers do not support write-only locking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8812

3 9

Re: [PATCH v15 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) Aug. 22, 2025

Aug. 22, 2025

On Fri Aug 22 11:05:37 2025 +0000, Alexandre Julliard wrote: > The registry can be edited by ordinary users as well. I understand, but would it be more convenient for them than opening a regular file? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113606

1 0

Re: [PATCH v3 0/7] MR8776: More runtimeclass type checks - approved
by Huw Davies (＠huw) Aug. 22, 2025

Aug. 22, 2025

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8776

1 0

[PATCH v3 0/3] MR8769: winebus: Miscellaneous changes relating to device identification.
by Connor McAdams (＠cmcadams) Aug. 22, 2025

Aug. 22, 2025

These patches are prerequisites for getting DualShock 4 controllers to work via USB in Tekken 8. -- v3: winebus: Override device instance enumerator string if bus type is known. winebus: Generate unique container IDs when adding devices. winebus: Generate unique serial numbers when adding devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8769

3 4

[PATCH v5 0/3] MR8808: winealsa, winecoremidi: Fixed MIDI reset Control Change
by Keigo Okamoto (＠KeigoOkamoto) Aug. 22, 2025

Aug. 22, 2025

This pull request fixes Wine's MIDI synthesizer reset process to be the same as Windows'. When playing Touhou Project games in MIDI BGM mode, the music playback becomes buggy when the BGM changes. The video below is an example of an anomaly that occurs when playing The Fantastic Tales from Tono after playing Crystallized Silver in Touhou 7. https://youtu.be/O69sndJ45Ag Here's a correct example of The Fantastic Tales from Tono playback: https://youtu.be/XlFAQEbbNDg Piano sound is clearly missing on Wine. This issue occurs due to an Wine's incorrect reset process for MIDI synthesizer. When I ran FluidSynth on Windows and checked the log, I found that CC123 and CC121 were executed for each MIDI channel when switching songs. CC123 means All Notes Off, CC121 means Reset All Controllers. -- v5: wineoss: Send All Notes Off and Reset Controllers. https://gitlab.winehq.org/wine/wine/-/merge_requests/8808

3 5

Re: [PATCH v15 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Alexandre Julliard (＠julliard) Aug. 22, 2025

Aug. 22, 2025

On Fri Aug 22 10:41:14 2025 +0000, Ivan Lyugaev wrote: > Saving settings in a configuration file allows ordinary users to change > them directly in the file itself. Use the same configuration on > different devices. In my opinion, saving the settings in the registry > complicates this decision from the point of view of the average user. > For example, in Windows, for the canon 3010 scanner, the driver saved > the settings in the configuration file along the path > **%AppData%\Roaming\Canon\G3010 Series ** > Taking into account the above, do I need to change the location where > the settings are saved, or should I stick with this solution? The registry can be edited by ordinary users as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113600

1 0

Re: [PATCH v15 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) Aug. 22, 2025

Aug. 22, 2025

On Thu Aug 21 20:44:13 2025 +0000, Esme Povirk wrote: > Alternative configurations could be stored in named keys in the registry > though. This might be an easier UI, since you could select them with a > combo box. Saving settings in a configuration file allows ordinary users to change them directly in the file itself. Use the same configuration on different devices. In my opinion, saving the settings in the registry complicates this decision from the point of view of the average user. For example, in Windows, for the canon 3010 scanner, the driver saved the settings in the configuration file along the path **%AppData%\Roaming\Canon\G3010 Series ** Taking into account the above, do I need to change the location where the settings are saved, or should I stick with this solution? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113599

1 0

[PATCH v7 0/3] MR8733: gameinput: Introduce new DLL.
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8338 The header cannot seem to be generated easily from an IDL, gameinput has some unfortunate versioning which reuses the same identifiers across versions, in an incompatible way and sometimes sharing only a subset of them (for instance enum values), and uses C++ namespaces to separate versions. The implementation needs to support every interface version at the same time, which is implemented by wrapping identifiers and adding version suffixes whenever it is included by the implementing code. The tests are also using that so we can tests multiple versions in the same file. -- v7: dinput/tests: Add some gameinput tests. gameinput: Introduce new DLL. include: Add gameinput.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8733

1 4

[PATCH v4 0/2] MR8808: winealsa, winecoremidi: Fixed MIDI reset Control Change
by Keigo Okamoto (＠KeigoOkamoto) Aug. 22, 2025

Aug. 22, 2025

This pull request fixes Wine's MIDI synthesizer reset process to be the same as Windows'. When playing Touhou Project games in MIDI BGM mode, the music playback becomes buggy when the BGM changes. The video below is an example of an anomaly that occurs when playing The Fantastic Tales from Tono after playing Crystallized Silver in Touhou 7. https://youtu.be/O69sndJ45Ag Here's a correct example of The Fantastic Tales from Tono playback: https://youtu.be/XlFAQEbbNDg Piano sound is clearly missing on Wine. This issue occurs due to an Wine's incorrect reset process for MIDI synthesizer. When I ran FluidSynth on Windows and checked the log, I found that CC123 and CC121 were executed for each MIDI channel when switching songs. CC123 means All Notes Off, CC121 means Reset All Controllers. -- v4: winecoreaudio: Send All Notes Off and Reset Controllers. https://gitlab.winehq.org/wine/wine/-/merge_requests/8808

2 2

[PATCH v3 0/1] MR8808: winealsa: Fixed MIDI reset Control Change
by Keigo Okamoto (＠KeigoOkamoto) Aug. 22, 2025

Aug. 22, 2025

This pull request fixes Wine's MIDI synthesizer reset process to be the same as Windows'. When playing Touhou Project games in MIDI BGM mode, the music playback becomes buggy when the BGM changes. The video below is an example of an anomaly that occurs when playing The Fantastic Tales from Tono after playing Crystallized Silver in Touhou 7. https://youtu.be/O69sndJ45Ag Here's a correct example of The Fantastic Tales from Tono playback: https://youtu.be/XlFAQEbbNDg Piano sound is clearly missing on Wine. This issue occurs due to an Wine's incorrect reset process for MIDI synthesizer. When I ran FluidSynth on Windows and checked the log, I found that CC123 and CC121 were executed for each MIDI channel when switching songs. CC123 means All Notes Off, CC121 means Reset All Controllers. -- v3: winealsa: Send All Notes Off and Reset Controllers. https://gitlab.winehq.org/wine/wine/-/merge_requests/8808

2 1

Re: [PATCH v2 0/1] MR8808: winealsa: Fixed MIDI reset Control Change
by Huw Davies (＠huw) Aug. 22, 2025

Aug. 22, 2025

Generally looks good, thanks! However, could you reword the commit message to be something like: `winealsa: Send All Notes Off and Reset Controllers.` ? Also, could you update the similar code in `winecoreaudio.drv/coremidi.c`? There, we already send 0x7b first, so it's just a question of replacing the 0x40 with a 0x79 and updating the comment. This change can go as a second commit in this same MR. I appreciate that you probably can't compile on macOS, but the CI will catch any errors in this trivial change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8808#note_113589

1 0

[PATCH v6 0/3] MR8733: Draft: gameinput: Introduce new DLL.
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8338 The header cannot seem to be generated easily from an IDL, gameinput has some unfortunate versioning which reuses the same identifiers across versions, in an incompatible way and sometimes sharing only a subset of them (for instance enum values), and uses C++ namespaces to separate versions. The implementation needs to support every interface version at the same time, which is implemented by wrapping identifiers and adding version suffixes whenever it is included by the implementing code. The tests are also using that so we can tests multiple versions in the same file. -- v6: dinput/tests: Add some gameinput tests. gameinput: Introduce new DLL. include: Add gameinput.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8733

2 5

[PATCH 0/2] MR8790: Draft: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
by Jacob Czekalla (＠JacobCzekalla) Aug. 22, 2025

Aug. 22, 2025

LButtonDown should return when the treeview handle is invalid (e.g. destroyed) after NM_CLICK to prevent further message processing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58211 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8790

3 6

[PATCH v2 0/4] MR8814: widl: Cleanup write_type helpers (3/3).
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

-- v2: widl: Introduce a new append_declspec helper. widl: Inline write_args into write_type_right. widl: Cleanup indentation and variables in write_type_right. widl: Remove now unnecessary write_callconv argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/8814

2 6

[PATCH v4 0/3] MR8733: Draft: gameinput: Introduce new DLL.
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8338 The header cannot seem to be generated easily from an IDL, gameinput has some unfortunate versioning which reuses the same identifiers across versions, in an incompatible way and sometimes sharing only a subset of them (for instance enum values), and uses C++ namespaces to separate versions. The implementation needs to support every interface version at the same time, which is implemented by wrapping identifiers and adding version suffixes whenever it is included by the implementing code. The tests are also using that so we can tests multiple versions in the same file. -- v4: dinput/tests: Add some gameinput tests. gameinput: Introduce new DLL. include: Add gameinput.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8733

1 3

[PATCH v2 0/5] MR8486: win32u: Always pass class name atom strings to wineserver.
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

-- v2: win32u: Always pass class name atom strings to wineserver. server: Support integral atom strings. win32u: Introduce helpers to check desktop and message class. user32: Use init_class_name(_ansi) in FindWindowEx(A|W). win32u: Forbid setting GCW_ATOM class info. https://gitlab.winehq.org/wine/wine/-/merge_requests/8486

2 9

[PATCH 0/6] MR8818: user32, win32u, server: Implement integral class name versioning support.
by Rémi Bernon Aug. 22, 2025

Aug. 22, 2025

Passing every atom as UNICODE_STRING to win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8818

1 6

[PATCH v2 0/1] MR8802: win32u: Avoid calling server in NtUserGetKeyState() when input keystate is in sync.
by Paul Gofman (＠gofman) Aug. 22, 2025

Aug. 22, 2025

-- v2: win32u: Avoid calling server in NtUserGetKeyState() when input keystate is in sync. https://gitlab.winehq.org/wine/wine/-/merge_requests/8802

3 3