August 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR8795: comdlg32: PRINTDLG_UpdatePrintDlgW() should update dmCopies field in DEVMODE. - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8795

1 0

Re: [PATCH v5 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

1 0

Re: [PATCH v2 0/1] MR8710: opengl32: Perform cAccumBits filtering if specified in wglChoosePixelFormat(). - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8710

1 0

Re: [PATCH v3 0/1] MR8788: hhctrl.ocx/help: Check for a NULL web_browser before QueryInterface. - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8788

1 0

Re: [PATCH v2 0/1] MR8791: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8791

1 0

Re: [PATCH v2 0/1] MR8793: server: Check thread and call parameters in (queue_apc) for APC_USER. - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8793

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 19:57:20 2025 +0000, Alexandre Julliard wrote: > DYNAMICBASE by itself is not meaningful for .exe.so binaries, they are > mapped by the Unix loader anyway, which provides its own ASLR. >From my understanding, `winebuild` influences the PE section of this binary, which IS meaningful. This is reinforced by the fact that our plugins stop crashing when it's disabled. The `HIGHENTROPYVA` should have no effect if `DYNAMICBASE` is off, so I can see a "not meaningful" there (but only on mutual exclusion), but I wanted to keep the PR as simple as possible. I understand that Unix has [its own ASLR that's on by default](https://askubuntu.com/questions/318315), but to deny the meaningfulness of this flag seems -- respectively -- incorrect. This regression was introduced with 518e394794160818ffe6826c874ff2f550c95bbb and can be reverted just the same. I'm only asking to give `winegcc` (or more specifically `winebuild`) devs the ability to control it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113323

1 0

[PATCH v2 0/6] MR8797: Implement GetProcessPriorityBoost/SetProcessPriorityBoost
by Marc-Aurel Zent (＠mzent) Aug. 20, 2025

Aug. 20, 2025

-- v2: kernel32/tests: Add tests for GetProcessPriorityBoost/SetProcessPriorityBoost. kernelbase: Implement SetProcessPriorityBoost. kernelbase: Implement GetProcessPriorityBoost. ntdll: Implement ProcessPriorityBoost class in NtSetInformationProcess. server: Add set_thread_disable_boost() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/8797

3 9

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 19:41:56 2025 +0000, Tres Finocchiaro wrote: > `HIGHENTROPYVA:NO` allows `DYNAMICBASE` to remain active for both 32-bit > and 64-bit executables while only disabling the 64-bit `HIGHENTROPYVA` > features. Since `DYNAMICBASE` is widely preferred for security > purposes, this provides just-enough granularity to close > [#58480](https://bugs.winehq.org/show_bug.cgi?id=58480), and matches > more closely to that of cygwin and MSVC compilers. Note that this > `HIGHENTROPYVA:NO` solution is new information since creating that bug report. > On the other hand, if it's winehq's stance that these flags should be > toggled together, I'd happily change this back. I was fearful that > handling them together may not be succinct enough, but I'm happy to oblige. DYNAMICBASE by itself is not meaningful for .exe.so binaries, they are mapped by the Unix loader anyway, which provides its own ASLR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113321

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 18:17:23 2025 +0000, Alexandre Julliard wrote: > That second flag doesn't seem necessary. `HIGHENTROPYVA:NO` allows `DYNAMICBASE` to remain active for both 32-bit and 64-bit executables while only disabling the 64-bit `HIGHENTROPYVA` features. Since `DYNAMICBASE` is widely preferred for security purposes, this provides just-enough granularity to close [#58480](https://bugs.winehq.org/show_bug.cgi?id=58480), and matches more closely to that of cygwin and MSVC compilers. Note that this `HIGHENTROPYVA:NO` solution is new information since creating that bug report. On the other hand, if it's winehq's stance that these flags should be toggled together, I'd happily change this back. I was fearful that handling them together may not be succinct enough, but I'm happy to oblige. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113319

1 0

[PATCH v2 0/3] MR8774: vccorlib140: Add an initial implementation for allocation primitives.
by Vibhav Pant (＠vibhavp) Aug. 20, 2025

Aug. 20, 2025

The `Allocate` method has two variants: * Allocate(size_t): Performs a normal allocation, but throws a COMException on OOM. * Allocate(ptrdiff_t offset, size_t size): Allocates a block of size `size`, and initializes a control block for an `IWeakReference` at `offset`. The weak reference resolves to the allocated object, which can finally be freed by calling `ControlBlock::ReleaseTarget`. The IWeakReference implementation seems to be rather odd, which I have tried to demonstrate (and test) in the unit tests: * `ReleaseTarget` only frees the object if the strong ref count is _below_ 0. * `IWeakReference::Resolve` will _not_ set the output pointer to `NULL` if the weak reference is no longer alive. This MR implements these functions sans exception support. -- v2: vccorlib140: Implement Platform::Details::{Allocate(ptrdiff_t, size_t), ControlBlock::ReleaseTarget}. vccorlib140: Add stub for Platform::Details::{Allocate(ptrdiff_t, size_t), ControlBlock::ReleaseTarget}. https://gitlab.winehq.org/wine/wine/-/merge_requests/8774

4 5

[PATCH v2 0/1] MR8758: winegstreamer: Use a stride alignment of 2 for NV12 in align_video_info_planes().
by Conor McCarthy (＠cmccarthy) Aug. 20, 2025

Aug. 20, 2025

Fixes the todos in !8034. -- v2: winegstreamer: Use a stride alignment of 2 for NV12 in align_video_info_planes(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8758

3 3

[PATCH v3 0/3] MR8792: msvcp140_atomic_wait: A few std::chrono::tzdb semi-stubs.
by Paul Gofman (＠gofman) Aug. 20, 2025

Aug. 20, 2025

-- v3: msvcp140_atomic_wait: Stub __std_tzdb_get_leap_seconds() / __std_tzdb_delete_leap_seconds(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_current_zone() / __std_tzdb_delete_current_zone(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_time_zones() / __std_tzdb_delete_time_zones(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8792

3 5

[PATCH v2 0/3] MR8792: msvcp140_atomic_wait: A few std::chrono::tzdb semi-stubs.
by Paul Gofman (＠gofman) Aug. 20, 2025

Aug. 20, 2025

-- v2: msvcp140_atomic_wait: Stub __std_tzdb_get_leap_seconds() / __std_tzdb_delete_leap_seconds(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_current_zone() / __std_tzdb_delete_current_zone(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_time_zones() / __std_tzdb_delete_time_zones(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8792

3 6

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 17:08:48 2025 +0000, Tres Finocchiaro wrote: > I've added a second flag for `HIGHENTROPYVA`. This new flag is longer > and breaks some styling. Any advice is greatly appreciated. I've > placed the style foopahs inline. That second flag doesn't seem necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113306

1 0

[PATCH v2 0/2] MR8801: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag.
by Billy Laws (＠bylaws) Aug. 20, 2025

Aug. 20, 2025

This flag seems to have always been supported. Unlike BYPASS_PROCESS_FREEZE -- v2: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/8801

3 4

[PATCH 0/2] MR8801: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag.
by Billy Laws (＠bylaws) Aug. 20, 2025

Aug. 20, 2025

This flag seems to have always been supported. Unlike BYPASS_PROCESS_FREEZE -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8801

2 2

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

I've added a second flag for `HIGHENTROPYVA`. This new flag is longer and breaks some styling. Any advice is greatly appreciated. I've placed the style foopahs inline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113299

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c: > { "dll", 0, LONG_OPT_DLL }, > { "def", 0, LONG_OPT_DEF }, > { "disable-dynamicbase", 0, LONG_OPT_DISABLE_DYNAMICBASE }, > + { "disable-high-entropy-va", 0, LONG_OPT_DISABLE_HIGH_ENTROPY_VA }, I would appreciate any advice from the winehq team here on styling. Mimicking the existing format for section will touch many more lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113298

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c: > " -d, --delay-lib=LIB Import the specified library in delayed mode\n" > " -D SYM Ignored for C flags compatibility\n" > " --disable-dynamicbase Disable 'ASLR' address space layout randomization (default: ASLR on)\n" > +" --disable-high-entropy-va Disable high-entropy 64-bit 'ASLR' (default: high-entropy on).\n" I would appreciate any advice from the winehq team here on styling. Mimicking the format this section for 80 chars will touch many more lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113297

1 0

[PATCH 0/2] MR8770: ntoskrnl: Add support for getting DEVPKEY_Device_BusReportedDeviceDesc from devices.
by Connor McAdams (＠cmcadams) Aug. 20, 2025

Aug. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8770

4 6

[PATCH v4 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) Aug. 20, 2025

Aug. 20, 2025

Fix out-of-bound access by wcslen. Found by ASan. -- v4: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

5 9

[PATCH v2 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

Commit 518e394794160818ffe6826c874ff2f550c95bbb introduced new and important default behavior for PE binaries built using `winegcc`/`wineg++`/`winebuild`. * `/DYNAMICBASE` - Generates an executable image that can be randomly rebased at load time by using the address space layout randomization (ASLR) feature of Windows that was first available in Windows Vista. * `/HIGHENTROPYVA` - Randomized 64-bit virtual addresses make it more difficult for an attacker to guess the location of a particular memory region. ... however as identified in https://bugs.winehq.org/show_bug.cgi?id=58480, this new default behavior can severely impact applications that interact with binaries created for Windows XP and older. This is quite common for legacy audio plugins, such as VST2(TM) plugins. This MR keeps the new default "dynamicbase" and "highentropyva" flags by default, but mirrors the mingw/msys2 `--disable-dynamicbase` flag as explained here: https://www.msys2.org/news/#2021-01-31-aslr-enabled-by-default. MSVC also provides a similarly named flag [here](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase). Downstream, the LMMS project has successfully deployed the mingw flag and the MSVC flag for our Windows builds. Our Linux builds use a custom wine-bridge and would benefit from the same. We've currently tested this MR downstream against a snapshot of master branch to passing results. Downstream PRs: * Linux: https://github.com/LMMS/lmms/pull/7987 * Windows: https://github.com/LMMS/lmms/pull/7976 -- v2: Spit up DYNAMICBASE and HIGHENTROPYVA https://gitlab.winehq.org/wine/wine/-/merge_requests/8786

2 2

[PATCH v2 0/4] MR8781: jscript: Misc array and toString fixes.
by Gabriel Ivăncescu Aug. 20, 2025

Aug. 20, 2025

-- v2: jscript: Fix error value when passing non-string 'this' to String's toString. jscript: Fallback to Object's toString for Arrays when 'this' isn't an jscript: Return proper error when passing wrong type to Function.apply. jscript: Allow objects that expose "length" prop for Function.apply under https://gitlab.winehq.org/wine/wine/-/merge_requests/8781

2 8

[PATCH 0/5] MR8799: win32u, server: Misc atom / class name requests cleanup.
by Rémi Bernon Aug. 20, 2025

Aug. 20, 2025

In preparation / instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/8486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8799

1 5