August 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + CloseHandle(hFile); > + > + sprintf(search, "%s=", name); > + context = NULL; > + line = strtok_s(content, "\n", &context); > + found = FALSE; > + > + while (line) > + { > + if (strstr(line, search) == line) > + { > + CHAR* val_start = line + strlen(search); > + CHAR* space = strchr(val_start, ' '); > + > + if (space) > + *space = '\0'; Ignoring anything after the first space in a string is odd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113168

1 0

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + BOOL found; > + HANDLE hFile = CreateFileW( > + path, > + GENERIC_READ, > + 0, NULL, OPEN_EXISTING, > + FILE_ATTRIBUTE_NORMAL, > + NULL > + ); > + > + if (hFile == INVALID_HANDLE_VALUE) > + { > + ERR("CreateFileW returned error: %lu\n", GetLastError()); > + return FALSE; > + } > + > + sprintf(search, "%s=", name); This `sprintf` is done twice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113167

1 0

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + while (line && count < 1000) > + { > + if (!found && strstr(line, search) == line) > + { > + lines[count++] = buffer; > + found = TRUE; > + } > + else > + { > + lines[count++] = strdup(line); > + } > + line = strtok_s(NULL, "\n", &context); > + } > + if (!found) > + { > + lines[count++] = buffer; This could write past the end of `lines`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113166

1 0

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + CHAR* context = NULL; > + size_t new_size = 0; > + CHAR* line; > + > + line = strtok_s(content, "\n", &context); > + > + while (line && count < 1000) > + { > + if (!found && strstr(line, search) == line) > + { > + lines[count++] = buffer; > + found = TRUE; > + } > + else > + { > + lines[count++] = strdup(line); I don't see a reason to make an additional allocation for each line. The original pointer should remain valid until `content` is freed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113165

1 0

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + > + new_content = NULL; > + found = FALSE; > + > + sprintf(search, "%s=", option->name); > + if (content) > + { > + CHAR* lines[1000] = {0}; > + int count = 0; > + CHAR* context = NULL; > + size_t new_size = 0; > + CHAR* line; > + > + line = strtok_s(content, "\n", &context); > + > + while (line && count < 1000) Please don't duplicate the buffer length. You can use the `ARRAY_SIZE` macro. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113164

1 0

Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 19, 2025

Aug. 19, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + sprintf(buffer, "%s=%s\n", (option->name), option->value.bool_val ? "true" : "false"); > + break; > + } > + > + size = GetFileSize(hFile, NULL); > + content = (CHAR*)malloc(size + sizeof(CHAR)); > + > + ReadFile(hFile, content, size, &read, NULL); > + content[size / sizeof(CHAR)] = '\0'; > + CloseHandle(hFile); > + > + new_content = NULL; > + found = FALSE; > + > + sprintf(search, "%s=", option->name); > + if (content) This is checking whether the malloc succeeded after the allocated value has already been used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113163

1 0

[PATCH 0/1] MR8785: rsaenh: Use TomCrypt for hash implementations.
by Hans Leidekker (＠hans) Aug. 19, 2025

Aug. 19, 2025

Some apps unload bcrypt which causes a crash if rsaenh is used afterwards. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8785

2 1

[PATCH 0/4] MR8781: jscript: Misc array and toString fixes.
by Gabriel Ivăncescu Aug. 19, 2025

Aug. 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8781

2 6

[PATCH 0/1] MR8783: dwrite: Add fallback for Dingbats.
by Ziqing Hui (＠zhui) Aug. 19, 2025

Aug. 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8783

3 2

[PATCH 0/1] MR8758: winegstreamer: Use a stride alignment of 2 for NV12 in align_video_info_planes().
by Conor McCarthy (＠cmccarthy) Aug. 19, 2025

Aug. 19, 2025

Fixes the todos in !8034. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8758

3 3

[PATCH v2 0/11] MR8782: iphlpapi: Implement ipv6 ping.
by Paul Gofman (＠gofman) Aug. 19, 2025

Aug. 19, 2025

-- v2: iphlpapi/tests: Add tests for Icmp6SendEcho2(). iphlpapi: Implement Icmp6SendEcho2(). nsiproxy.sys: Don't try to check for original packet for ping socket. iphlpapi: Implement Icmp6CreateFile(). iphlpapi: Implement Icmp6ParseReplies(). iphlpapi: Only supply APC routine if no event in icmp_send_echo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8782

2 11

[PATCH 0/11] MR8782: iphlpapi: Implement ipv6 ping.
by Paul Gofman (＠gofman) Aug. 19, 2025

Aug. 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8782

2 12

Re: [PATCH v11 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Esme Povirk (＠madewokherd) Aug. 18, 2025

Aug. 18, 2025

Esme Povirk (@madewokherd) commented about dlls/sane.ds/cfg.c: > + } > + *last_slash = L'\0'; > + attr = GetFileAttributesW(path); > + if (attr == INVALID_FILE_ATTRIBUTES) > + { > + if (!CreateDirectoryW(path, NULL)) > + { > + DWORD err = GetLastError(); > + ERR("CreateDirectoryW returned error: %lu\n", err); > + return FALSE; > + } > + } > + return TRUE; > +} > + > +BOOL is_exist_file(WCHAR* path) I would suggest simply trying to create the file you will use when it's time to use it and handling any errors that come up. Checking first can cause race conditions: https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113132

1 0

Re: [PATCH v2 0/1] MR7923: shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from...
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

Superseded by !7490. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7923#note_113126

1 0

Re: [PATCH v2 0/1] MR7923: shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from... - closed
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7923

1 0

Re: [PATCH v4 0/1] MR7490: shell32: mark FOLDERID_UserProgramFiles as CSIDL_Type_User - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7490

1 0

Re: [PATCH v4 0/3] MR8612: ntdll: Return STATUS_INVALID_ADDRESS for free regions in get_memory_region_info(). - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8612

1 0

Re: [PATCH v3 0/1] MR8404: include: Make sure to null terminate string in wine_dbg_vsprintf. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8404

1 0

Re: [PATCH v2 0/9] MR8775: joy.cpl: Misc force feedback effect fixes. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8775

1 0

Re: [PATCH v4 0/4] MR8696: widl: Cleanup write_type helpers (1/3). - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8696

1 0

Re: [PATCH v12 0/9] MR8664: cryptxml: Implement some stubs. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8664

1 0

Re: [PATCH v2 0/1] MR8771: winebus.sys: Use uint16_t instead of __u16 - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8771

1 0

Re: [PATCH v10 0/2] MR7064: ntdll: Check for invalid GS base in the 64-bit segv_handler. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

1 0

Re: [PATCH v4 0/1] MR8591: ntdll: Fill EnabledFeatures before return. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8591

1 0

Re: [PATCH v2 0/1] MR8772: ntdll/tests: Mark test as broken with old Windows versions. - approved
by Alexandre Julliard (＠julliard) Aug. 18, 2025

Aug. 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8772

1 0