August 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR8860: winex11: Bitmap rendering now checks pbuffer bit instead of pixmap bit
by Zowie van Dillen (＠zowie) Sept. 3, 2025

Sept. 3, 2025

This is my first commit so I thought with something pretty unobjectionable. The merge request !8210 seems to have switched from pixmaps to pbuffers for bitmap rendering (although it might have been an earlier change). This flag was overlooked and is still checking for pixmap compatibility. This caused problems with 16-bit bitmap rendering because, on my Nvidia driver, the pixmap bit is only ever set for onscreen (`DRAW_TO_WINDOW`) pixel formats. None of the 16-bit pixel formats are `DRAW_TO_WINDOW`, so that means it won't be able to find a good 16-bit pixel format. The pbuffer bit, on the other hand, is set for most offscreen formats and also more common for onscreen formats. Notably this doesn't actually fix 16-bit bitmap rendering — it's pretty darn broken. Other changes need some more research & discussion though, I'll keep it for another day. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8860

3 2

[PATCH 0/1] MR8033: kernelbase: Support using CreateFile to create folders
by Yeshun Ye (＠yeyeshun) Sept. 3, 2025

Sept. 3, 2025

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> Change-Id: I2a8099278fae6dcc45bc92fb1f1f606407fba000 Although MSDN does not mention that CreateFile can be used to create folders, it is actually supported. Verified on WinXP, Win7, and Win10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8033

3 6

[PATCH 0/1] MR8858: sane.ds: Adding saving scanner settings to the registry
by Ivan Lyugaev (＠valy) Sept. 3, 2025

Sept. 3, 2025

The latest scanner settings are now automatically saved in the HKEY_CURRENT_USER\Software\ScannersSettings\<Vendor>\<Product> path. This modification was tested and worked correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8858

3 17

[PATCH 0/4] MR8817: ICU support part 1
by Zhiyi Zhang (＠zhiyi) Sept. 2, 2025

Sept. 2, 2025

For React Native. See WIP https://gitlab.winehq.org/zhiyi/wine/-/commits/bug-23698-react-native-icu and https://gitlab.winehq.org/zhiyi/wine-icu/-/commits/master for wine-icu integration. The GitLab CI part hasn't been set up yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8817

2 5

[PATCH v10 0/8] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) Sept. 1, 2025

Sept. 1, 2025

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v10: hidclass: Set Status for pending IRPs of removed devices to STATUS_DEVICE_NOT_CONNECTED. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile[Ex](). server: Introduce a separate server object for the async cancel operation. server: Keep cancelled async in a separate list. server: Introduce a find_async_from_user helper. ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 18

[PATCH 0/1] MR8852: ntdll: Zero aligned size in initialize_block().
by Paul Gofman (＠gofman) Sept. 1, 2025

Sept. 1, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8852

3 4

[PATCH v12 0/13] MR8829: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Sept. 1, 2025

Sept. 1, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v12: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

3 14

[PATCH v2 0/1] MR8862: mmdevapi/tests: Rewrite capturing tests.
by Giovanni Mascellani (＠giomasce) Sept. 1, 2025

Sept. 1, 2025

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916) and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- v2: mmdevapi/tests: Rewrite capturing tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

2 2

[PATCH v2 0/1] MR8745: wbemprox: Add Status property to Win32_Process
by Adam Słaboń Sept. 1, 2025

Sept. 1, 2025

This is needed for 8BitDo Firmware Updater version 2.52 -- v2: wbemprox: Add Status property to Win32_Process https://gitlab.winehq.org/wine/wine/-/merge_requests/8745

2 3

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Vibhav Pant (＠vibhavp) Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 16:55:44 2025 +0000, Bernhard Übelacker wrote: > Thanks for looking into it. By replacing the body of > property_value_statics_CreateString with above version (and renaming the > parameter value to value_str) ASan stays silent and the test succeeds here. Thanks, I'll create an MR for the fix them (: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114367

1 0

[PATCH v11 0/13] MR8829: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v11: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v10 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v10: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v9 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v9: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 11:46:59 2025 +0000, Vibhav Pant wrote: > Yes, I think `IPropertyValueStatics::CreateString` should use > `WindowsDuplicateString`. Could you replace the code > [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… > with > ```c > { > HSTRING value; > HRESULT hr; > TRACE("iface %p, value %s, property_value %p.\n", iface, > debugstr_hstring(value_str), property_value); > *property_value = NULL; > if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; > create_primitive_property_value_iref(PropertyType_String, > irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); > } > ``` > and see if it resolves the issue? I'll create an MR in that case. Thanks for looking into it. By replacing the body of property_value_statics_CreateString with above version (and renaming the parameter value to value_str) ASan stays silent and the test succeeds here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114358

1 0

[PATCH v8 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v8: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v7 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v7: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v6 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v6: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current(). windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). windows.media.playback.backgroundmediaplayer: Add IBackgroundMediaPlayerStatics stub. include: Add IMediaPlayer definition. windows.media.playback.backgroundmediaplayer: Add stub dll. include: Add windows.media.playback.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v8 0/7] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v8: Resource pending for “Open with” on file association https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 7

[PATCH 0/1] MR8862: mmdevapi/tests: Rewrite capturing tests.
by Giovanni Mascellani (＠giomasce) Aug. 31, 2025

Aug. 31, 2025

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916) and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

2 1

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Vibhav Pant (＠vibhavp) Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 09:30:40 2025 +0000, Bernhard Übelacker wrote: > @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up > with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is > `str` supposed to be a new allocation after line 948? > ``` > ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: > heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp > 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 > READ of size 8 at 0x7f6707c03ba0 thread T0 > #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 > #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 > 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) > freed by thread T0 here: > #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 > #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 > #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 > previously allocated by thread T0 here: > #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 > #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 > #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 > #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 > ``` > [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… Yes, I think `IPropertyValueStatics::CreateString` should use `WindowsDuplicateString`. Could you replace the code [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… with ```c { HSTRING value; HRESULT hr; TRACE("iface %p, value %s, property_value %p.\n", iface, debugstr_hstring(value_str), property_value); *property_value = NULL; if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; create_primitive_property_value_iref(PropertyType_String, irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); } ``` and see if it resolves the issue? I'll create an MR in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114348

1 0

[PATCH 0/1] MR8849: cmd: Treat COPY from CON or CON: as ASCII operation.
by Joe Souza (＠JoeS209) Aug. 31, 2025

Aug. 31, 2025

This should fix the remaining issues in bug #16214. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8849

3 8

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker Aug. 31, 2025

Aug. 31, 2025

Bernhard Übelacker (@bernhardu) commented about dlls/vccorlib140/tests/vccorlib.c: > + obj = pCreateValue(TYPECODE_STRING, &str); > + WindowsDeleteString(str); > + ok(obj != NULL || broken(obj == NULL), "got obj %p\n", obj); /* Returns NULL on i386 Windows 10. */ > + if (obj) > + { > + type = PropertyType_Empty; > + hr = IPropertyValue_get_Type(obj, &type); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(type == PropertyType_String, "got type %d\n", type); > + str = NULL; > + hr = IPropertyValue_GetString(obj, &str); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(str != NULL, "got str %p\n", str); > + buf = WindowsGetStringRawBuffer(str, NULL); > + ok(buf && !wcscmp(buf, L"foo"), "got buf %s\n", debugstr_w(buf)); > + WindowsDeleteString(str); @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is `str` supposed to be a new allocation after line 948? ``` ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 READ of size 8 at 0x7f6707c03ba0 thread T0 #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) freed by thread T0 here: #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 previously allocated by thread T0 here: #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 ``` [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114345

1 0

[PATCH v7 0/6] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v7: Creating Makefile https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 6

[PATCH v5 0/4] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v5: Creating winemenumgr https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 4

[PATCH v3 0/3] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v3: Ajouter un nouveau répertoire https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 3