August 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker Aug. 31, 2025

Aug. 31, 2025

Bernhard Übelacker (@bernhardu) commented about dlls/vccorlib140/tests/vccorlib.c: > + obj = pCreateValue(TYPECODE_STRING, &str); > + WindowsDeleteString(str); > + ok(obj != NULL || broken(obj == NULL), "got obj %p\n", obj); /* Returns NULL on i386 Windows 10. */ > + if (obj) > + { > + type = PropertyType_Empty; > + hr = IPropertyValue_get_Type(obj, &type); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(type == PropertyType_String, "got type %d\n", type); > + str = NULL; > + hr = IPropertyValue_GetString(obj, &str); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(str != NULL, "got str %p\n", str); > + buf = WindowsGetStringRawBuffer(str, NULL); > + ok(buf && !wcscmp(buf, L"foo"), "got buf %s\n", debugstr_w(buf)); > + WindowsDeleteString(str); @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is `str` supposed to be a new allocation after line 948? ``` ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 READ of size 8 at 0x7f6707c03ba0 thread T0 #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) freed by thread T0 here: #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 previously allocated by thread T0 here: #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 ``` [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114345

1 0

[PATCH v7 0/6] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v7: Creating Makefile https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 6

[PATCH v5 0/4] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v5: Creating winemenumgr https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 4

[PATCH v3 0/3] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v3: Ajouter un nouveau répertoire https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 3

[PATCH v2 0/2] MR8857: Update fr.po
by Allan Rémy Aug. 30, 2025

Aug. 30, 2025

-- v2: Modifier fr.po https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 2

[PATCH 0/1] MR8857: Update fr.po
by Allan Rémy Aug. 30, 2025

Aug. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

3 9

[PATCH v7 0/1] MR8859: windows.applicationmodel/tests: Add tests for exposing COM interfaces through the manifest.
by Vibhav Pant (＠vibhavp) Aug. 30, 2025

Aug. 30, 2025

This MR adds additional tests to validate registration-free activation of WinRT components using the AppX manifest. -- v7: windows.applicationmodel/tests: Add tests for exposing inproc WinRT classes through the manifest. https://gitlab.winehq.org/wine/wine/-/merge_requests/8859

3 3

[PATCH v9 0/2] MR8635: oleaut32: Add VarNumFromStr to convert VT_BSTR to numeric or boolean
by Maotong Zhang (＠xiaotong) Aug. 30, 2025

Aug. 30, 2025

Use VarNumFromStr for VT_BSTR conversion in VarAnd、VarOr、VarImp Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56280 -- v9: oleaut32: Add VarNumFromStr to convert VT_BSTR to numeric or boolean https://gitlab.winehq.org/wine/wine/-/merge_requests/8635

3 4

[PATCH v2 0/8] MR8856: opcservices/tests: Add tests for ReadPackageFromStream.
by Nikolay Sivov (＠nsivov) Aug. 30, 2025

Aug. 30, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: opcservice: Fix iteration with MovePrevious(). opcservices/tests: Add more tests for MovePrevious(). opcservices: Fix MoveNext() at the collection end. opcservices/tests: Add some more tests for MoveNext(). opcservices/tests: Use stricter return values checks. opcservices/tests: Remove Vista workarounds. opcservices/tests: Use wide-char strings. opcservices/tests: Add tests for ReadPackageFromStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/8856

3 8

[PATCH v5 0/1] MR8859: windows.applicationmodel/tests: Add tests for exposing COM interfaces through the manifest.
by Vibhav Pant (＠vibhavp) Aug. 30, 2025

Aug. 30, 2025

This MR adds additional tests to validate registration-free activation of WinRT components using the AppX manifest. -- v5: windows.applicationmodel/tests: Add tests for exposing inproc WinRT classes through the manifest. https://gitlab.winehq.org/wine/wine/-/merge_requests/8859

2 1