August 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Rémi Bernon Aug. 7, 2025

Aug. 7, 2025

On Thu Aug 7 19:05:40 2025 +0000, Tomasz Pakuła wrote: > You're thinking too much. It's no the default of the Windows/API but how > drivers behave. A lot of wheels use custom protocol and they can do > whatever they want with autocenter and PID wheels just don't support any > explicit autocenter method. It's more likelay an omission on the part of > developer that still works because wheel manufacturers work around it. > The current handling of autocenter is correct and works in all three > cases (hidraw/SDL/udev). Fwiw you can create different device types in the tests and check whether autocenter has a different default value, but I suspect like @TomaszPakula says, that it's just unspecified behavior. The DInput autocenter feature doesn't seem to be well defined, even on the HID PID side, and sends a generic (reset / stop all) command that drivers are free to interpret the way they like. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112404

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tomasz Pakuła Aug. 7, 2025

Aug. 7, 2025

On Thu Aug 7 19:03:03 2025 +0000, Tyson Whitehead wrote: > My thinking is that the default under Windows in `DIPROPAUTOCENTER_ON` > for joysticks and `DIPROPAUTOCENTER_OFF` for wheels. Could this be possible? > It would perfectly explain @TomaszPakula issue of his wheel not working > the same under Windows (no autocentering) and Wine (autocentering) for > his truck simulations assuming ETS2/ATS doesn't explicitly set it as the > developers only tested wheels on Windows and therefore assumed it would > be off. You're thinking too much. It's no the default of the Windows/API but how drivers behave. A lot of wheels use custom protocol and they can do whatever they want with autocenter and PID wheels just don't support any explicit autocenter method. It's more likelay an omission on the part of developer that still works because wheel manufacturers work around it. The current handling of autocenter is correct and works in all three cases (hidraw/SDL/udev). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112403

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tyson Whitehead (＠twhitehead) Aug. 7, 2025

Aug. 7, 2025

On Thu Aug 7 18:58:37 2025 +0000, Rémi Bernon wrote: > It is the default value because that's what makes the tests to pass. > Setting `DIPROPAUTOCENTER_OFF` by default doesn't pass the tests. The > tests also pass on Windows so we can conclude that it's also > `DIPROPAUTOCENTER_ON` by default on Windows. My thinking is that the default under Windows in `DIPROPAUTOCENTER_ON` for joysticks and `DIPROPAUTOCENTER_OFF` for wheels. Could this be possible? It would perfectly explain @TomaszPakula issue of his wheel not working the same under Windows (no autocentering) and Wine (autocentering) for his truck simulations assuming ETS2/ATS doesn't explicitly set it as the developers only tested wheels on Windows and therefore assumed it would be off. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112402

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Rémi Bernon Aug. 7, 2025

Aug. 7, 2025

On Thu Aug 7 18:53:47 2025 +0000, Tyson Whitehead wrote: > Right. It makes sense that not setting `DIPROR_AUTOCENTER` under Wine > gives the same result as setting it to `DIPROPAUTOCENTER_ON` because I > made `DIPROPAUTOCENTER_ON` on the [default > value](https://gitlab.winehq.org/wine/wine/-/blob/42a63687cd6991de03402d81b… > when I first implemented `DIPROR_AUTOCENTER`. I also strongly suspect > that it is this default value that is what is actually wrong and needs fixing. It is the default value because that's what makes the tests to pass. Setting `DIPROPAUTOCENTER_OFF` by default doesn't pass the tests. The tests also pass on Windows so we can conclude that it's also `DIPROPAUTOCENTER_ON` by default on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112401

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tyson Whitehead (＠twhitehead) Aug. 7, 2025

Aug. 7, 2025

On Thu Aug 7 18:53:47 2025 +0000, Rémi Bernon wrote: > I think we have tests which explicitly set DIPROP_AUTOCENTER, and some > which don't, and it seems that when it's not set the HID PID reports > that are sent to the device are the same as when DIPROP_AUTOCENTER is > set to `DIPROPAUTOCENTER_ON`. Right. It makes sense that not setting `DIPROR_AUTOCENTER` under Wine gives the same result as setting it to `DIPROPAUTOCENTER_ON` because I made `DIPROPAUTOCENTER_ON` on the [default value](https://gitlab.winehq.org/wine/wine/-/blob/42a63687cd6991de03402d81b… when I first implemented `DIPROR_AUTOCENTER`. I also strongly suspect that it is this default value that is what is actually wrong and needs fixing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112400

1 0

[PATCH 0/1] MR8738: d3d12: Support creating devices using dxcore adapters.
by Nikolay Sivov (＠nsivov) Aug. 7, 2025

Aug. 7, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8738

3 2

[PATCH 0/2] MR8737: dxcore: Add support for DriverDescription property.
by Nikolay Sivov (＠nsivov) Aug. 7, 2025

Aug. 7, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8737

3 3

[PATCH 0/8] MR8739: mshtml: Misc attribute node tests and fixes.
by Gabriel Ivăncescu Aug. 7, 2025

Aug. 7, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8739

1 8

[PATCH 0/4] MR8656: mshtml: Implement attribute nodes with gecko nodes in IE9+ modes.
by Gabriel Ivăncescu Aug. 7, 2025

Aug. 7, 2025

For the IE9 attr node implementation (delegating to gecko attr nodes), this uses the existing infrastructure to keep track of the attributes in a collection (and so, associate DISPIDs for them, etc), since it also matches native (same DISPID broken behavior when removing attrs) and we already have the code for it. The current code is split into helpers called from many places already related to it, so instead I just extended the helpers with new code paths for IE9+ attrs. There's also appropriate FIXMEs for things that aren't properly handled by simple delegation to gecko (from my older patchset), so at least if we find something that needs it, it will be way easier to debug. The last patch is a bit big since it had to enable the new attr nodes everywhere in IE9+ modes, else either tests would fail or we wouldn't test anything, as I'm using existing tests (just in IE9 mode). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8656

2 9

[PATCH 0/7] MR6971: mshtml: Implement attribute nodes properly in IE9+ modes and prototype chain.
by Gabriel Ivăncescu Aug. 7, 2025

Aug. 7, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6971

2 16