September 2025 - Wine-GitLab

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Connor McAdams (＠cmcadams) Sept. 30, 2025

Sept. 30, 2025

On Mon Sep 29 21:59:33 2025 +0000, Matteo Bruni wrote: > If I understand correctly, this affects the output. In which case I'd > avoid calling it an optimization, both in the comment and the commit subject. > It's a bit of a pet peeve of mine, please bear with me... I wrote this patch awhile ago, I _think_ I used the term optimization to bolster my argument for changing this behavior. It technically should be faster as it lets us get out of this function earlier. The decompressed values don't change with this "optimization". The actual compressed data values shouldn't really matter, what should matter is the decompressed values. But, in `check_texture{2d,3d}_data()`, we check for compressed values. What would be a better term to use here? Just "Wine specific change"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117153

1 0

[PATCH 0/5] MR9073: Cmd engine rewrite (part XXXVII)
by eric pouech (＠epo) Sept. 30, 2025

Sept. 30, 2025

This MR finishes the eradication of WCMD_ReadFile in favor of WCMD_fgets started in previous MR. A couple of enhancements to MORE command. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9073

2 5

[PATCH 0/6] MR9072: win32u: Implement D3DKMT object sharing through NT handles.
by Rémi Bernon Sept. 30, 2025

Sept. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9072

1 6

[PATCH 0/4] MR9071: server: Introduce an internal queue bits field.
by Rémi Bernon Sept. 30, 2025

Sept. 30, 2025

And set a QS_DRIVER bit when the queue fd is ready for reading, or clear it if it isn't, before waiting on it. Clear the bit after waiting as we expect the client to process events before calling the server again and before we can poll it again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9071

1 4

[PATCH 0/1] MR9070: ddraw/tests: Use ANSI versions of user32 functions.
by Elizabeth Figura (＠zfigura) Sept. 30, 2025

Sept. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9070

2 1

[PATCH v2 0/1] MR9058: d3dx9: Add an initial implementation of UpdateSkinnedMesh().
by Elizabeth Figura (＠zfigura) Sept. 29, 2025

Sept. 29, 2025

-- v2: d3dx9: Add an initial implementation of UpdateSkinnedMesh(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9058

3 2

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) Sept. 29, 2025

Sept. 29, 2025

Very minor comments, looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117123

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) Sept. 29, 2025

Sept. 29, 2025

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/texture.c: > + struct d3dx_pixels src_pixels, dst_pixels; > + uint32_t dst_row_pitch, dst_slice_pitch; > + > + hr = d3dx_image_get_pixels(&image, i, j, &src_pixels); > + if (FAILED(hr)) > + break; > + > + hr = d3dx_calculate_pixels_size(fmt_desc->format, dst_size.width, dst_size.height, &dst_row_pitch, > + &dst_slice_pitch); > + if (FAILED(hr)) > + break; > + > + set_d3dx_pixels(&dst_pixels, pixels_buffer, dst_row_pitch, dst_slice_pitch, NULL, dst_size.width, > + dst_size.height, dst_size.depth, &unaligned_rect); > + > + hr = d3dx_load_pixels_from_pixels(&dst_pixels, fmt_desc, &src_pixels, src_desc, D3DX10_FILTER_POINT, 0); Just a question in passing, unrelated to the patch: do we know if `D3DX10_FILTER_POINT` is actually the default filter? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117122

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) Sept. 29, 2025

Sept. 29, 2025

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/d3dx_helpers.c: > expected_src_data_size = (image->layer_pitch * image->layer_count) + header_size; > if (src_data_size < expected_src_data_size) > { > + const uint32_t dxt10_info_only_flags = D3DX_IMAGE_INFO_ONLY | D3DX_IMAGE_SUPPORT_DXT10; > + > WARN("File is too short %u, expected at least %u bytes.\n", src_data_size, expected_src_data_size); > - /* D3DX10/D3DX11 do not validate the size of the pixels, only the header. */ > - if (!(flags & D3DX_IMAGE_SUPPORT_DXT10)) > + /* > + * D3DX10/D3DX11 do not validate the size of the pixels, only the header. > + * However, if we're loading the image data, don't match native > + * behavior. > + */ I'd mention explicitly that we're doing it to be safe and until we find reason to do otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117121

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) Sept. 29, 2025

Sept. 29, 2025

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/stb_dxt.h: > dest[1] = (unsigned char)mn; > dest += 2; > > + /* > + * Wine specific optimization to more closely match Windows behavior: If > + * max is equal to minimum, just set all bits to 0 (which means the value > + * is the value of max in this case). > + */ > + if (mx == mn) { > + memset(dest, 0, 6); > + return; > + } If I understand correctly, this affects the output. In which case I'd avoid calling it an optimization, both in the comment and the commit subject. It's a bit of a pet peeve of mine, please bear with me... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117120

1 0