September 2025 - Wine-GitLab

[PATCH 0/3] MR8921: win32u: Fix missing NULL initialization of NtAllocateVirtualMemory parameter.
by Rémi Bernon Sept. 8, 2025

Sept. 8, 2025

Fixes: b2764cf318acc318bc5a577571bcb84678b7e1cf -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8921

1 3

[PATCH v4 0/1] MR8794: shell32: Restore the ability of running unix executables via unix paths
by Yuxuan Shui (＠yshui) Sept. 8, 2025

Sept. 8, 2025

MobaXTerm tries to ShellExecute "/bin/sh" when running under wine. This ability to run unix executables on the host via unix paths was accidentally removed in the attemp to align ShellExecute more closely with native, while fixing the problem that sometimes wrong executable is started by ShellExecute (e.g. in Motor Race Collection). Related: a2548c8db3096963012939c82e340f6b867f3efd Fixes: 85d029e3b01f6dd35a86cc07796af982d66e4a03 -- v4: shell32: Restore the ability of running unix executables via unix paths https://gitlab.winehq.org/wine/wine/-/merge_requests/8794

3 3

[PATCH v2 0/1] MR3529: rpcrt4: Forward NdrStubCall3 to NdrStubCall2.
by Alex Henrie (＠alexhenrie) Sept. 8, 2025

Sept. 8, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54606 -- v2: rpcrt4: Forward NdrStubCall3 to NdrStubCall2. https://gitlab.winehq.org/wine/wine/-/merge_requests/3529

5 9

[PATCH 0/1] MR8919: ntdll: Fix the build of check_invalid_gsbase() on FreeBSD
by Gerald Pfeifer (＠gerald) Sept. 7, 2025

Sept. 7, 2025

This addresses dlls/ntdll/unix/signal_x86_64.c: In function ‘check_invalid_gsbase’: dlls/ntdll/unix/signal_x86_64.c:2067:23: error: passing argument 1 of ‘amd64_get_gsbase’ from incompatible pointer type [-Wincompatible-pointer-types] 2067 | amd64_get_gsbase( &cur_gsbase ); | ^~~~~~~~~~~ | | | ULONG_PTR * {aka long unsigned int *} which shows with modern compilers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8919

2 1

[PATCH v3 0/1] MR7447: oleaut32: Implement (S|G)etVarConversionLocaleSetting()
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

Partial, as per documentation, implement fixing as the default locale. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Implement (S|G)etVarConversionLocaleSetting() https://gitlab.winehq.org/wine/wine/-/merge_requests/7447

3 2

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Test commit should go first, with todo's. Second commit will then remove todo's. Note that there are whitespace warnings when applying patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115153

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > if (open_classes_key(HKEY_CLASSES_ROOT, buf, MAXIMUM_ALLOWED, &xhkey)) > { > - free(buf); > - WARN("couldn't open key for ProgID %s\n", debugstr_w(progid)); > - return CO_E_CLASSSTRING; > + lstrcpyW(buf, progid); > + lstrcatW(buf, L"\\CurVer"); > + if (RegQueryValueW(HKEY_CLASSES_ROOT, buf, buf3, &buf3len)) > + { > + free(buf); > + WARN("couldn't query CurVer value for ProgID %s\n", debugstr_w(progid)); > + return CO_E_CLASSSTRING; > + } > + > + lstrcpyW(buf, buf3); > + lstrcatW(buf, L"\\CLSID"); Size of 'buf' has no relation to size of 'buf3', so you can't assume you can copy things and not overrun it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115152

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > > static HRESULT clsid_from_string_reg(LPCOLESTR progid, CLSID *clsid) > { > - WCHAR buf2[CHARS_IN_GUID]; > + WCHAR buf2[CHARS_IN_GUID],buf3[CHARS_IN_GUID]; > LONG buf2len = sizeof(buf2); > + LONG buf3len = sizeof(buf3); Those should be renamed to something more intuitive. Also buf3 here does not contain a stringified GUID but ProgID, so using CHARS_IN_GUID length is incorrect. What happens if ProgID referenced with CurVer itself contains another CurVer, is it followed? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115151

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ This comment does not belong to this new test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115150

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ > + StringFromGUID2(&CLSID_non_existent, clsidstr, ARRAYSIZE(clsidstr)); > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest\\CurVer", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)L"MyApp.DocumentTest.1", (wcslen(L"MyApp.DocumentTest.1") + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest.1\\CLSID", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)clsidstr, (wcslen(clsidstr) + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + hr = CLSIDFromProgID(L"MyApp.DocumentTest", &clsid); > + ok(hr == S_OK, "CLSIDFromProgID failed with error 0x%08lx\n", hr); > + ok(IsEqualCLSID(&clsid, &CLSID_non_existent), "got wrong clsid %s\n", wine_dbgstr_guid(&clsid)); This needs a test for when both CurVer and CLSID are present. The test should clean up entries it creates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115149

1 0