January 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + PropVariantClear(&propvar); > + > + /* Place an ENDOFSEGMENT marker after the third sample */ > + hr = IMFStreamSink_PlaceMarker(stream, MFSTREAMSINK_MARKER_ENDOFSEGMENT, NULL, NULL); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + hr = gen_wait_media_event_until_blocking((IMFMediaEventGenerator*)stream, callback, MEStreamSinkMarker, 1000, &propvar); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + PropVariantClear(&propvar); > + > + /* Check clock time */ > + while (time <= 300000) > + { > + IMFPresentationClock_GetTime(clock, &time); > + Sleep(50); > + } This does not look very safe to me. If we must to do GetTime(), maybe do it in a separate thread, and have a timeout? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128139

1 0

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + hr = IMFMediaTypeHandler_SetCurrentMediaType(type_handler, media_type); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + IMFMediaType_Release(media_type); > + IMFMediaTypeHandler_Release(type_handler); > + > + /* Test rate support when initialised */ > +if (rate_support1) > +{ > + hr = IMFRateSupport_GetSlowestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + ok(rate == 0.125, "Unexpected rate %f\n", rate); > + > + hr = IMFRateSupport_GetFastestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + ok(rate == 8.0, "Unexpected rate %f\n", rate); Any idea where those numbers are coming from? Is this accessible somehow from mmdevapi maybe? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128138

1 0

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + > +if (rate_support1) > +{ > + hr = IMFRateSupport_GetSlowestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > + > + hr = IMFRateSupport_GetFastestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > + > + hr = IMFRateSupport_IsRateSupported(rate_support1, FALSE, 1.0, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > +} > +else > +{ > + skip("Skipping rate support tests\n"); > +} There is no need for a skip, you know that GetService is todo, then a return object check is enough to guard tests that need it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128137

1 0

[PATCH v2 0/1] MR9983: winedump: Print CLR string offset instead of index.
by Hans Leidekker (＠hans) Jan. 27, 2026

Jan. 27, 2026

-- v2: winedump: Print CLR string offset instead of index. https://gitlab.winehq.org/wine/wine/-/merge_requests/9983

2 1

[PATCH 0/1] MR9983: winedump: Print CLR string offset instead of index.
by Hans Leidekker (＠hans) Jan. 27, 2026

Jan. 27, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9983

2 1

[PATCH 0/5] MR9981: winevulkan: More make_vulkan cleanup and simplifications.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9981

1 5

[PATCH 0/1] MR9980: opengl32: Fix a typo in client-side GLsync allocated object.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

Fixes: df7943684d11c4ad26128da2abc1506f29c4eb45 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59320 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9980

1 1

[PATCH 0/5] MR9930: cfgmgr32: Update header and specifications.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

This is in preparation for implementing cfgmgr32 functions more properly, which are widely used by native gameinput. The module is supposed to be the lower-level API, abstracting the registry, and used by other modules like setupapi instead of the other way around. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9930

2 12

[PATCH v3 0/1] MR9881: cmd: Replace '/' to '\' for path in 'WCMD_pushd'
by Yeshun Ye (＠yeyeshun) Jan. 27, 2026

Jan. 27, 2026

The parameter of the 'pushd' command may contain the character ‘/’, which is compatible with Windows. Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v3: cmd: Allow '/' in quoted 'WCMD_pushd' args. https://gitlab.winehq.org/wine/wine/-/merge_requests/9881

3 2

[PATCH v2 0/2] MR9946: start: Remove quotes from the path specified by '/d'.
by Yeshun Ye (＠yeyeshun) Jan. 27, 2026

Jan. 27, 2026

I'm not sure how to write a test case for this bug, as it involves creating a child process and I don't know how to verify if the child process was created correctly. Please test manually: enter `start /d "c:\windows" regedit.exe` in a batch file. It won't work correctly because `start` wraps the directory specified by `/D` with `L"\"\\\""` and `L"\\\"\""`. -- v2: start: Remove quotes from the path specified by '/d'. cmd/tests: Add test for 'start' with '/d'. https://gitlab.winehq.org/wine/wine/-/merge_requests/9946

3 6