January 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR9847: winex11: Drop SCIM workaround. - approved
by Sven Baars (＠sbaars) Jan. 3, 2026

Jan. 3, 2026

This merge request was approved by Sven Baars. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9847

1 0

Re: [PATCH v2 0/1] MR9847: winex11: Drop SCIM workaround.
by Sven Baars (＠sbaars) Jan. 3, 2026

Jan. 3, 2026

On Fri Jan 2 22:31:23 2026 +0000, Byeongsik Jeon wrote: > Thanks for the comment! > I couldn't find a proper bugfix log in the SCIM git log, so I did some > additional testing. > In my previous tests, I had only tested with scim-hangul. I tested again > with scim-pinyin and SCIM built-in rawcode_imengine. In conclusion, the > issue seems to be a bug in the process_key_event of each imengine. > The `process_key_event` function of the problematic SCIM imengines are > implemented as follows: > ``` > if (key.is_key_release()) > return true; > ``` > In the non-problematic scim-hangul, it returns false. > By returning `false` in this situation, SCIM can call > IMdkit::IMForwardEvent and the X client can process the key release > event. This is the same for the ibus and fcitx imengines as well. > At the time of a4a5a2e, SCIM was the mainstream xim server, but today > SCIM is not being developed anymore, it has been replaced by ibus and > fcitx, so it doesn't seem necessary for Wine to continue this > workaround. It also creates additional issues for xim servers that work > correctly, as in #55849. > And, I didn't use git revert because of the changes in > handle_wm_protocols() since a4a5a2e. > v2: Add more commit message. Thanks for the extensive explanation. It looks reasonable to me to remove the workaround. It also sounds like the workaround is broken even when using SCIM with scim-hangul, which is even more reason to revert it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9847#note_126379

1 0

[PATCH v2 0/1] MR9851: win32u: Return failure from ResizePalette called with a count of zero.
by Bernhard Übelacker Jan. 2, 2026

Jan. 2, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59203 [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161382) -- v2: win32u: Return failure from ResizePalette called with a count of zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/9851

1 2

[PATCH 0/1] MR9851: win32u: Return failure from ResizePalette called with a count of zero.
by Bernhard Übelacker Jan. 2, 2026

Jan. 2, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59203 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9851

2 3

Re: [PATCH v2 0/1] MR9847: winex11: Drop SCIM workaround.
by Byeongsik Jeon (＠bsjeon) Jan. 2, 2026

Jan. 2, 2026

On Fri Jan 2 22:23:05 2026 +0000, Sven Baars wrote: > Thanks for looking into this. Did you also confirm that the workaround > was necessary for you with older versions of SCIM? When looking into > that bug I was unfortunately not able to do that. > Also, it would probably be better to use `git revert` to revert the > original commit that implemented the workaround. And then mention in the > commit message that this has been fixed in SCIM (and include the bug > link like you already did of course). > Thanks! Thanks for the comment! I couldn't find a proper bugfix log in the SCIM git log, so I did some additional testing. In my previous tests, I had only tested with scim-hangul. I tested again with scim-pinyin and SCIM built-in rawcode_imengine. In conclusion, the issue seems to be a bug in the process_key_event of each imengine. The `process_key_event` function of the problematic SCIM imengines are implemented as follows: ``` if (key.is_key_release()) return true; ``` In the non-problematic scim-hangul, it returns false. By returning `false` in this situation, SCIM can call IMdkit::IMForwardEvent and the X client can process the key release event. This is the same for the ibus and fcitx imengines as well. At the time of a4a5a2e, SCIM was the mainstream xim server, but today SCIM is not being developed anymore, it has been replaced by ibus and fcitx, so it doesn't seem necessary for Wine to continue this workaround. It also creates additional issues for xim servers that work correctly, as in #55849. And, I didn't use git revert because of the changes in handle_wm_protocols() since a4a5a2e. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9847#note_126369

1 0

Re: [PATCH v2 0/2] MR9850: d3d*/tests: Test how lighting is affected by world and view matrices. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2026

Jan. 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9850

1 0

Re: [PATCH v5 0/2] MR9822: Fix possible EA launcher hangs. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2026

Jan. 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9822

1 0

Re: [PATCH v2 0/1] MR9848: po: Update Finnish translation. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2026

Jan. 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9848

1 0

Re: [PATCH v3 0/1] MR9845: user32: Remove unused todo_wine handling from listbox test. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2026

Jan. 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9845

1 0

[PATCH 0/2] MR9850: d3d*/tests: Test how lighting is affected by world and view matrices.
by Elizabeth Figura (＠zfigura) Jan. 2, 2026

Jan. 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9850

2 2