February 2026 - Wine-GitLab

Re: [PATCH v3 0/2] MR9704: winmm, msvfw32: DGV window shenanigans with audio only files
by Huw Davies (＠huw) Feb. 25, 2026

Feb. 25, 2026

Huw Davies (@huw) commented about dlls/winmm/tests/mci.c: > > -static void test_playWaveTypeMpegvideo(void) > +static void test_playTypeMpegvideo(HWND hwnd) > { > + const WCHAR *filename = load_resource(L"test.mp3"); > + MCI_DGV_WINDOW_PARMSW window_param = { 0 }; > + MCI_STATUS_PARMS status_parm = { 0 }; > + MCI_PLAY_PARMS play_parm = { 0 }; > + MCIDEVICEID wDeviceID = 0; > + char buf[1024] = { 0 }; > MCIERROR err; > - MCIDEVICEID wDeviceID; > - MCI_PLAY_PARMS play_parm; > - MCI_STATUS_PARMS status_parm; > - char buf[1024]; > - memset(buf, 0, sizeof(buf)); Please don't make these kind of changes, just add the vars you need, only init them if need be and don't try to Christmas tree them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9704#note_130483

1 0

Re: [PATCH v6 0/1] MR10174: bcryptprimitives: Make ProcessPrng always return `TRUE`
by Christopher Denton (＠cdenton) Feb. 25, 2026

Feb. 25, 2026

On Wed Feb 25 10:13:33 2026 +0000, Hans Leidekker wrote: > I think an ERR() would still be good to have because RtlGenRandom() can > fail according to the docs. It doesn't fail in the current > implementation but an assert would be an additional guard against that > changing and be more visible, but I don't mind leaving it out at this > point. The question is whether it's better to abort the app or to > continue without random data. Having slept on it, I think I'm going to revert this to the original aborting behaviour. If that's not accepted then I can remove it but I do think it's the right thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130477

1 0

Re: [PATCH v6 0/1] MR10174: bcryptprimitives: Make ProcessPrng always return `TRUE`
by Christopher Denton (＠cdenton) Feb. 25, 2026

Feb. 25, 2026

I just notice that this should be calling `RtlGenRandom` in a loop because `ProcessPrng` takes a `SIZE_T` but this will be truncated to a `ULONG` when calling `RtlGenRandom`. Should I do that here or send a separate MR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130476

1 0

Re: [PATCH v6 0/1] MR10174: bcryptprimitives: Make ProcessPrng always return `TRUE`
by Hans Leidekker (＠hans) Feb. 25, 2026

Feb. 25, 2026

Hans Leidekker (@hans) commented about dlls/bcryptprimitives/main.c: > > BOOL WINAPI ProcessPrng(BYTE *data, SIZE_T size) > { > - return RtlGenRandom(data, size); > + RtlGenRandom(data, size); > + /* ProcessPrng is documented as always returning TRUE */ > + return TRUE; I think an ERR() would still be good to have because RtlGenRandom() can fail according to the docs. It doesn't fail in the current implementation but an assert would be an additional guard against that changing and be more visible, but I don't mind leaving it out at this point. The question is whether it's better to abort the app or to continue without random data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130474

1 0

[PATCH 0/5] MR10183: msxml/tests: Extend PI test with newlines.
by Nikolay Sivov (＠nsivov) Feb. 25, 2026

Feb. 25, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10183

2 5

Re: [PATCH v3 0/7] MR10099: winebth.sys part 14: Create PDOs for GATT services. - approved
by Alexandre Julliard (＠julliard) Feb. 24, 2026

Feb. 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10099

1 0

Re: [PATCH v2 0/1] MR10181: msvcp140: Add _Xregex_error implementation. - approved
by Alexandre Julliard (＠julliard) Feb. 24, 2026

Feb. 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10181

1 0

Re: [PATCH v2 0/1] MR10178: compiler-rt: add __ctzdi2 to fix i386 mingw builds - approved
by Alexandre Julliard (＠julliard) Feb. 24, 2026

Feb. 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10178

1 0

Re: [PATCH v7 0/3] MR9915: mmdevapi: Device name changes. - approved
by Alexandre Julliard (＠julliard) Feb. 24, 2026

Feb. 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9915

1 0

Re: [PATCH v4 0/2] MR8763: win32u: Disable keyboard cues by default. - approved
by Alexandre Julliard (＠julliard) Feb. 24, 2026

Feb. 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8763

1 0