March 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR10289: SDK conformance (part I) - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10289

1 0

Re: [PATCH v2 0/4] MR10288: wshom.ocx: Implement WshShortcut_get_TargetPath(). - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10288

1 0

Re: [PATCH v3 0/1] MR10280: win32u: Set VendorId / DeviceId in DirectX registry key with correct size. - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10280

1 0

Re: [PATCH v2 0/1] MR10287: shcore: Add RecordFeatureUsage() stub. - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10287

1 0

Re: [PATCH v3 0/7] MR10273: vcruntime140: Initial C++ support. - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10273

1 0

Re: [PATCH v3 0/7] MR10281: Add some ninput function stubs. - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10281

1 0

Re: [PATCH v2 0/1] MR10282: wintypes: Return S_OK for api_information_statics_IsMethodPresent(). - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10282

1 0

Re: [PATCH v4 0/2] MR10250: Call abort if _wassert error behavior is set to _OUT_TO_STDERR and trigger a debug break.
by Piotr Caban (＠piotr) March 10, 2026

March 10, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/exit.c: > _cputs("\nabnormal program termination\n"); > } > #endif > + > raise(SIGABRT); > + > +#if _MSVCR_VER >= 140 > + if (MSVCRT_abort_behavior & _CALL_REPORTFAULT) > + __fastfail(FAST_FAIL_FATAL_APP_EXIT); > +#endif `_CALL_REPORTFAULT` was added in `msvcr80`. It should be probably changed to `_MSVCR_VER >= 80`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10250#note_131758

1 0

Re: [PATCH v4 0/2] MR10250: Call abort if _wassert error behavior is set to _OUT_TO_STDERR and trigger a debug break.
by Piotr Caban (＠piotr) March 10, 2026

March 10, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/exit.c: > wchar_t text[2048]; > _snwprintf(text, sizeof(text), L"File: %ls\nLine: %d\n\nExpression: \"%ls\"", file, line, str); > DoMessageBoxW(L"Assertion failed!", text); > + raise(SIGABRT); > + _exit(3); > } > else > fwprintf(stderr, L"Assertion failed: %ls, file %ls, line %d\n\n", str, file, line); > > - raise(SIGABRT); > - _exit(3); > + abort(); ```suggestion:-3+0 fwprintf(stderr, L"Assertion failed: %ls, file %ls, line %d\n\n", str, file, line); abort(); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10250#note_131757

1 0

Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Matteo Bruni (＠Mystral) March 10, 2026

March 10, 2026

I haven't tried but it seems preferable to always allocate and copy the data directly in `GetNextObject()` and then remove the `!data->level &&` condition from `Release()`, so you don't need to add another field to the struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131748

1 0