March 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v11 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2 - approved
by Esme Povirk (＠madewokherd) March 5, 2026

March 5, 2026

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10193

1 0

[PATCH v2 0/4] MR10104: user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled
by Ivan Ivlev (＠iviv) March 5, 2026

March 5, 2026

Edit control does not release mouse capture after WM_LBUTTONDOWN has been processed two times in a row. This MR fixes this issue by releasing capture and setting it again on WM_LBUTTONDOWN if window was already captured. I have stumbled upon the app in which edit control process WM_LBUTTONDOWN twice on one mouse click. While in windows it causes no problem, wine edit does not release capture, so other buttons inside this app become unclickable. It happens because when WM_LBUTTONDOWN is processed twice, WM_CAPTURECHANGED is sent and bCaptureState is set to FALSE, then EDIT_WM_LButtonUp does not release capture because bCaptureState is already FALSE. Thing about tests: I have added test case for this problem to be visible. I also had to use todo_wine because SendMessageA for WM_LBUTTONDOWN and WM_LBUTTONUP returns 0 in wine and 1 in windows (which is not the case for combobox test, where SendMessageА for WM_LBUTTONDOWN also returns 1 in wine). -- v2: comctl32_v6/edit: Reset capture on WM_LBUTTONDOWN if already enabled user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled comctl32/tests/edit.c: Test WM_LBUTTONDOWN processing user32/tests/edit.c: Test WM_LBUTTONDOWN processing https://gitlab.winehq.org/wine/wine/-/merge_requests/10104

2 1

[PATCH v7 0/22] MR10227: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 5, 2026

March 5, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- v7: Edit loader.c - attempt to align this file with the version on my system mf: Implement IMFTimer using a periodic callback. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10227

1 0

[PATCH v6 0/6] MR10244: Draft: vbscript: fix sub first arg parentheses handling
by Francis De Brabandere (＠francisdb) March 5, 2026

March 5, 2026

Closes https://bugs.winehq.org/show_bug.cgi?id=54177 -- v6: improve parser comment https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 2

[PATCH v4 0/4] MR10244: Draft: vbscript: fix sub first arg parentheses handling
by Francis De Brabandere (＠francisdb) March 5, 2026

March 5, 2026

Closes https://bugs.winehq.org/show_bug.cgi?id=54177 -- v4: revert adding of unrelated test https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 4

[PATCH v3 0/3] MR10244: Draft: vbscript: fix sub first arg parentheses handling
by Francis De Brabandere (＠francisdb) March 5, 2026

March 5, 2026

Closes https://bugs.winehq.org/show_bug.cgi?id=54177 -- v3: vbscript: more parentheses related parser fixes https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 2

Re: [PATCH v2 0/1] MR10098: shell32: Use lpwstrReason argument in RestartDialogEx. - closed
by Leonid Konontsov (＠nokono) March 5, 2026

March 5, 2026

This merge request was closed by Leonid Konontsov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10098

1 0

[PATCH v2 0/2] MR10244: Draft: vbscript: fix sub first arg parentheses handling
by Francis De Brabandere (＠francisdb) March 5, 2026

March 5, 2026

Closes https://bugs.winehq.org/show_bug.cgi?id=54177 -- v2: vbscript: more parentheses related parser fixes https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

[PATCH v3 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 5, 2026

March 5, 2026

This PR addresses two issues that I observed preventing the Native Instruments Kontakt Player MSI (and other MSI files from the same vendor) from successfully finishing: 1. Some installers contain padding for 4-byte alignment of table streams. * Proposed fix: We relax Wine's parsing to allow for such padding. 2. Some installers declare that they have 3-byte strrefs, but the data actually contains 2-byte strrefs. This looks like a malformed MSI to me, and Wine correctly rejects them currently. The regression tests in this PR indicate that Windows in CI (test-win10-21h2-\*) is reading garbage as well. However, NI ships these MSI files, which implies that somehow the installation successfully completes on Windows machines nevertheless. * Proposed fix: We explicitly detect and correct this particular mismatch at load time of the MSI, in order to be able to complete the installation under Wine as well. --- The above are technically separate issues, but they affect the same software in similar ways, so I opted for one PR. Please me know if I should split them. --- Quick repro hint: Native Instruments offers a program called Native Access (which acts as an installation hub on the user's machine). On user request, NA downloads and launches the affected MSI files in the background. If you try to repro, a couple of things to watch out for: 1. NA seems to always report a successful installation, even when the underlying MSI fails to complete (and therefore nothing is installed). This PR does nothing to address this false positive, as it is most likely a logic bug in the hub or installation orchestration. 2. To observe/examine the underlying MSI files (including the fix presented here), you'll need to grab them after NA downloads and extracts them on your machine (or find manual/direct downloads on the NI website, where applicable) --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issues and coming up with fixes._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v3: msi/tests: Add regression tests for table stream padding and mismatched string refs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

3 5

Re: [PATCH v3 0/1] MR10206: comctl32/treeview: Fixed missing redraw of item being unfocused
by Piotr Pawłowski March 5, 2026

March 5, 2026

Please approve. This fixes repaint bug I kept running into when testing other changes, item being deselected was stuck shown selected after specific user input. Nothing can break from this, only changes item TREEVIEW_InvalidateItem() calls. There's nothing to auto test here, simulate user input and take screenshots? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10206#note_131348

1 0