April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR10726: dsound: Merge capability flags when returning existing primary buffer.
by Jon Koops (＠jonkoops) April 23, 2026

April 23, 2026

I'm thinking perhaps the underlying implementation is somewhat wrong. It seems that Windows does in fact NOT merge these flags (test fails on this assertion). Perhaps each DirectSoundCreate gets its own buffer there? Or there is some other reason that GetVolume actually just works on Windows, even if it doesn't handle the flags (this seems illogical, but who knows). I'm going to add a test to verify this to the PR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10726#note_137436

1 0

Re: [PATCH v2 0/2] MR10726: dsound: Merge capability flags when returning existing primary buffer.
by Jon Koops (＠jonkoops) April 23, 2026

April 23, 2026

Hmmm, looking at the failures on CI it seems that my assumptions about how Windows handles this are wrong. Let me re-evaluate the logs from the report. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10726#note_137435

1 0

[PATCH 0/4] MR10727: msxml3/tests: Separate DTD validation tests.
by Nikolay Sivov (＠nsivov) April 23, 2026

April 23, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10727

2 4

Re: [PATCH v2 0/2] MR10726: dsound: Merge capability flags when returning existing primary buffer.
by Jon Koops (＠jonkoops) April 23, 2026

April 23, 2026

Note the implementation I wrote assumes that the flags are merged, I am not exactly sure if Windows usually merges, or swaps the flags, but I have added an assertion to the test to validate this (checks pre-existing flags still exist after merge). From what I could gather from the submitting patches guide this would also be tested against Windows, so I assume this would be enough to ensure this behavior is correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10726#note_137433

1 0

[PATCH 0/1] MR10701: gitlab: Add nasm to the CI docker images.
by Rémi Bernon (＠rbernon) April 23, 2026

April 23, 2026

For https://gitlab.winehq.org/wine/wine/-/merge_requests/10687 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10701

2 2

Re: [PATCH v6 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Hans Leidekker (＠hans) April 23, 2026

April 23, 2026

On Thu Apr 23 07:11:20 2026 +0000, Nikolai Abdusamatov wrote: > Hi @huw , could you please take another look at this MR when you have a moment? > I’ve addressed the previous review comments and updated the patch > accordingly. Please let me know if anything else needs to be changed. > Thanks! @tclem and @bshanks may know better if these interfaces are still used. Alternatively we could put them last, although that presumably brings back the buffer overflow in your app. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_137410

1 0

[PATCH v5 0/8] MR10364: dinput: Add support for generating consistent guidInstance values for devices.
by Connor McAdams (＠cmcadams) April 23, 2026

April 23, 2026

This MR adds support for creating `guidInstance` values for joystick devices in a way that matches native behavior. Our current method of creating a `guidInstance` value uses the device's rawinput handle, which changes each time a controller is plugged in. Fixes a bug in Rocket League where a controller plug/unplug cycle results in a new controller being detected each time. The process is like this: - Controller is connected, the game gets its `guidInstance` value from `EnumDevices()`, stores it and associates it with player 1. - Controller is disconnected. - The same controller is reconnected, the game calls `EnumDevices()`, and finds a new `guidInstance` value. - It then assumes this is a new controller, creates a new player, and behaves as though player 1's controller is unplugged. This MR implements `guidInstance` in a way that matches native, and ensures that the `guidInstance` value remains consistent. Doing things this way also makes it easier to add support for `DIPROP_JOYSTICKID` and `GUID_Joystick` in a future MR. I've implemented those in a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/dinput-instance-gu… using this system. -- v5: dinput: Refresh joystick devices when an unknown GUID is used to create a device. dinput: Return E_FAIL when opening a joystick device that is currently disconnected. dinput: Create a version 1 UUID for dinput joystick devices. dinput: Create registry entries for HID joysticks. dinput: Use joystick cache in hid_joystick_create_device(). dinput: Use joystick cache in hid_joystick_enum_device(). dinput: Create a cache of currently connected HID joysticks. dinput: Only pass instance name string to device_instance_is_disabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10364

3 16

Re: [PATCH v6 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Nikolai Abdusamatov (＠n-abdusamatov) April 23, 2026

April 23, 2026

On Tue Apr 14 19:47:26 2026 +0000, Nikolai Abdusamatov wrote: > Thanks to everyone for your detailed feedback and suggestions. I've > updated the patch based on them - I hope I got it right. The game still > loads correctly, and the buffer size doesn't exceed the client’s limit. > I've also attached the latest logs, including a comparison with the > previous version. > [analysis_summary.txt](/uploads/68d89f1348ab9b257566b116cddaf80d/analysis_summary.txt) Hi @huw , could you please take another look at this MR when you have a moment? I’ve addressed the previous review comments and updated the patch accordingly. Please let me know if anything else needs to be changed. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_137409

1 0

[PATCH v3 0/1] MR10427: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface
by Alistair Leslie-Hughes (＠alesliehughes) April 23, 2026

April 23, 2026

-- v3: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface https://gitlab.winehq.org/wine/wine/-/merge_requests/10427

2 1

[PATCH v3 0/2] MR10723: ddraw: Ignore hwnd clipper in exclusive fullscreen mode.
by Paul Gofman (＠gofman) April 23, 2026

April 23, 2026

-- v3: ddraw: Ignore hwnd clipper in exclusive fullscreen mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/10723

2 2