April 2026 - Wine-GitLab - list.winehq.org

[PATCH v11 0/10] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 21, 2026

April 21, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59604 Implement CM_Get_Parent by storing device tree relationship properties when ntoskrnl enumerates child devices via IRP_MN_QUERY_DEVICE_RELATIONS: - DEVPKEY_Device_Parent on each child device - DEVPKEY_Device_Children on the parent device - DEVPKEY_Device_Siblings on each child device CM_Get_Parent reads DEVPKEY_Device_Parent through SetupDiGetDevicePropertyW. Also fix SETUPDI_EnumerateMatchingInterfaces to remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration results. --\> no more phantom devices Based on discussion with Rémi Bernon (Bug 59604) Tested on a fresh Wine 11.6 setup with KNX ETS 6.4.1: A USB HID license dongle (VID 2A07, PID 0102) is now correctly identified through CM_Get_Parent device tree navigation. -- v11: setupapi/tests: Add CM_Get_Parent tests. cfgmgr32: Implement CM_Get_Parent using DEVPKEY_Device_Parent property. ntoskrnl/tests: Add DEVPKEY_Device_Siblings test. ntoskrnl: Store DEVPKEY_Device_Siblings on each child after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Children test. ntoskrnl: Store DEVPKEY_Device_Children on parent after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Parent test. ntoskrnl: Store DEVPKEY_Device_Parent when enumerating child devices. setupapi/tests: Add test for DIGCF_DEVICEINTERFACE filter. setupapi: Remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10604

2 12

[PATCH v11 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 21, 2026

April 21, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v11: gdi32: Add test for tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

2 4

[PATCH 0/1] MR10711: odbc32: Add missing object unlock on return in SQLSetEnvAttr().
by Nikolay Sivov (＠nsivov) April 21, 2026

April 21, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10711

4 3

[PATCH v2 0/1] MR10675: scrrun: Implement IFolder and IFile ShortName and ShortPath.
by Francis De Brabandere (＠francisdb) April 21, 2026

April 21, 2026

Both get_ShortPath methods wrap GetShortPathNameW on the stored long path; get_ShortName extracts the last component of the resulting short path. Add matching tests comparing against GetShortPathNameW directly. -- v2: scrrun: Implement IFolder and IFile ShortName and ShortPath. https://gitlab.winehq.org/wine/wine/-/merge_requests/10675

3 3

[PATCH v10 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 21, 2026

April 21, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v10: gdi32: Add test for tmExternalLeading for CFF fonts. tools: Suport generation of otf fonts. win32u/freetype: Fix tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

3 6

[PATCH 0/1] MR10488: win32u: Optimize the speed of halftone primitives by using 32.32 fixed point arithmetic.
by Zhiyi Zhang (＠zhiyi) April 21, 2026

April 21, 2026

Floating-point operations are expensive, especially when running on x86 CPU emulators. Tests show that speed after this commit is improved by 18% on AMD 9950x with no visual difference. [halftone-test.zip](/uploads/d9cede791109b4d32d767ad0b7cac79e/halftone-test.zip) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10488

3 2

[PATCH 0/2] MR10697: win32u: Reject DDBs that are not 1-bit or 32-bit for GetDIBits().
by Zhiyi Zhang (＠zhiyi) April 21, 2026

April 21, 2026

SDL3 applications depend on this to not overwrite the depth of its internal display mode. Fix SDL3 applications using the native display mode instead of the specified display mode when restoring to fullscreen from focus loss for the first time, and the specific display mode is 16-bit. Please see `WIN_UpdateDisplayMode()` in the SDL3 source code. ```c static void WIN_UpdateDisplayMode(SDL_VideoDevice *_this, LPCWSTR deviceName, DWORD index, SDL_DisplayMode *mode) { ... if (index == ENUM_CURRENT_SETTINGS && (hdc = CreateDCW(deviceName, NULL, NULL, NULL)) != NULL) { char bmi_data[sizeof(BITMAPINFOHEADER) + 256 * sizeof(RGBQUAD)]; LPBITMAPINFO bmi; HBITMAP hbm; SDL_zeroa(bmi_data); bmi = (LPBITMAPINFO)bmi_data; bmi->bmiHeader.biSize = sizeof(BITMAPINFOHEADER); hbm = CreateCompatibleBitmap(hdc, 1, 1); GetDIBits(hdc, hbm, 0, 1, NULL, bmi, DIB_RGB_COLORS); GetDIBits(hdc, hbm, 0, 1, NULL, bmi, DIB_RGB_COLORS); DeleteObject(hbm); DeleteDC(hdc); if (bmi->bmiHeader.biCompression == BI_BITFIELDS) { switch (*(Uint32 *)bmi->bmiColors) { ... case 0x7C00: mode->format = SDL_PIXELFORMAT_XRGB1555; break; } ... ``` When entering a 16-bit display mode, `WIN_UpdateDisplayMode(_this, displaydata->DeviceName, ENUM_CURRENT_SETTINGS, mode);` is called in `WIN_SetDisplayMode()`. The second `GetDIBits()` call in `WIN_UpdateDisplayMode()` succeeds and ends up overwriting the format to SDL_PIXELFORMAT_XRGB1555, which is a 15-bit display mode. So when SDL3 tries to enter the 16-bit display mode again, it won't be found because it's now 15-bit. Tests show that the second `GetDIBits()` should fail and thus leave the display mode format unchanged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10697

3 4

[PATCH v4 0/2] MR10504: Draft: vbscript: Implement GetLocale and SetLocale functions.
by Francis De Brabandere (＠francisdb) April 21, 2026

April 21, 2026

-- v4: vbscript: Use script LCID in Format* and call SetThreadLocale. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v2 0/7] MR10706: msxml3: Respect document encoding in Save().
by Nikolay Sivov (＠nsivov) April 21, 2026

April 21, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: msxml3/tests: Add a few missing return value checks (Coverity). msxml3/tests: Fix some use-after-free (Coverity). msxml3/tests: Fix a string double free (Coverity). msxml3/tests: Fix copy-paste issue when testing node value (Coverity). msxml3: Improve cleanup on error paths when creating DOM nodes (Coverity). msxml3: Fix a leak when parsing xml declaration body (Coverity). msxml3: Respect document encoding in Save(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10706

2 7

[PATCH 0/3] MR10708: mfplat: Strip leading slashes from the URL in source_resolver_CreateObjectFromURL().
by Conor McCarthy (＠cmccarthy) April 21, 2026

April 21, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10708

3 4