April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v8 0/1] MR10561: secur32: Fix handling by SChannel for CNG/NCrypt client certificates for mTLS - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10561

1 0

Re: [PATCH v6 0/3] MR10487: winewayland: Fix display freeze for games that fake-minimize - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10487

1 0

Re: [PATCH v2 0/1] MR10694: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10694

1 0

Re: [PATCH v2 0/7] MR10688: msxml3: Improvements to setAttribute().
by Nikolay Sivov (＠nsivov) April 20, 2026

April 20, 2026

On Mon Apr 20 11:42:09 2026 +0000, Nikolay Sivov wrote: > Great, thank you. Could you try if !10705 helps? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688#note_137130

1 0

[PATCH 0/1] MR10705: msxml3: Fix owner node refcount update when adding children and attributes.
by Nikolay Sivov (＠nsivov) April 20, 2026

April 20, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10705

2 1

[PATCH v2 0/5] MR10677: amstream: Test and fix media type enum on ddraw stream.
by Brendan McGrath (＠redmcg) April 20, 2026

April 20, 2026

This MR adds new tests and subsequent fixes for the type returned by `IEnumMediaTypes::Next` on the `IEnumMediaTypes` retrieved from the `IPin::EnumMediaTypes` function on the Direct Draw media stream. -- v2: amstream: Return connected media subtype in enum if connected. amstream: Return current format in media type enum. amstream/tests: Test enum media type on disconnect. amstream/tests: Test enum media type whilst connected. amstream/tests: Test enum media type with ddraw. https://gitlab.winehq.org/wine/wine/-/merge_requests/10677

3 8

[PATCH v11 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- v11: vbscript: Return "Invalid for loop control variable" error for member expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

Re: [PATCH v10 0/7] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Elizabeth Figura (＠zfigura) April 20, 2026

April 20, 2026

On Fri Apr 17 19:58:07 2026 +0000, Jan Robert Gerigk wrote: > I have addressed all three points: > 2/7 and 3/7: removed the scope blocks, moved parent_id\[\] (and friends > in 3/7: parent_sp, child_ids, count) to the functions declaration block. > 7/7: replaced the non-empty check with ok(!wcscmp(buffer_w, > L"ROOT\\WINETEST\\0"), ...) plus a matching size check. As a side > effect, 4/7s scope block and duplicate child_ids/count are gone. The > Siblings loop now reuses the function-level vars from 3/7, with a single > free() at the end. And tests for 1/7, 3/7, and 4/7? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_137123

1 0

[PATCH v9 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 20, 2026

April 20, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v9: gdi32: Add test for tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

3 11

[PATCH v5 0/1] MR10600: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

For VT_DISPATCH arguments, call the object's default property (DISPID_VALUE) to get a string value instead of returning the object via VariantCopy (Eval) or returning type mismatch (Execute/ ExecuteGlobal). This matches Windows behavior where passing a dispatch object without a default property fails with error 438, and objects with a default property have it invoked to obtain the string to evaluate or execute. -- v5: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10600

3 4