April 2026 - Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR10497: vbscript: Return specific error codes for unterminated block statements.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

When a block statement reaches EOF without its closing keyword, Windows returns a specific error code. Add error productions in the bison grammar for four unterminated block types: - If without End If (error 1014) - While without Wend (error 1018) - Do without Loop (error 1019) - For/For Each without Next (error 1020) Previously these all fell through to the generic E_FAIL path. -- v3: vbscript: Return specific error codes for unterminated block statements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10497

2 1

Re: [PATCH v4 0/11] MR10513: d3dx{9,10,11}: Add support for premultiplied alpha and SRGB conversions. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10513

1 0

Re: [PATCH v2 0/6] MR10686: opengl32: Fix missing hooks and merge similar wrappers together. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10686

1 0

Re: [PATCH v9 0/2] MR10546: vbscript: Use indexed lookup for global functions and variables. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10546

1 0

Re: [PATCH v5 0/1] MR10489: vbscript: Return specific error codes for missing keywords in parser. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10489

1 0

[PATCH v21 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v21: https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 8

Re: [PATCH v9 0/1] MR10592: vbscript: Add call depth limit to prevent stack overflow on infinite recursion. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10592

1 0

Re: [PATCH v11 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

1 0

Re: [PATCH v4 0/7] MR10669: odbc32: Implement sharing environment between connections. - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10669

1 0

Re: [PATCH v3 0/7] MR10540: build: Fix warnings with recent gcc/glibc versions - approved
by Alexandre Julliard (＠julliard) April 17, 2026

April 17, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10540

1 0