April 2026 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10788: Draft: gdiplus: Fix GdiMeasureString line height to use 4/3 emSize
by Bartosz Kosiorek (＠gang65) April 30, 2026

April 30, 2026

Hi @dmitry @madewokherd I need some advice from experts before I proceed with further work. By default, GDI+ adds a small amount of padding for non typographic. It is top 1/6 padding and 1/6 bottom padding of emSize. Non-Typographic format uses the 4/3 ratio to ensure vertical spacing and avoid clipping overhanging glyphs. Typographic format doesn't include any padding. This patch is causing massive test success: ``` graphics.c:3987: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4004: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333344 graphics.c:3987: Test succeeded inside todo block: Expected 18.000000, got 17.880001 graphics.c:4004: Test succeeded inside todo block: Expected 18.000000, got 17.879997 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333321 graphics.c:3987: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4004: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4004: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 12.699999, got 12.615334 graphics.c:4004: Test succeeded inside todo block: Expected 12.699999, got 12.615334 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 6.349999, got 6.307667 graphics.c:4004: Test succeeded inside todo block: Expected 6.349999, got 6.307667 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4004: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333344 graphics.c:3987: Test succeeded inside todo block: Expected 18.000000, got 17.880001 graphics.c:4004: Test succeeded inside todo block: Expected 18.000000, got 17.879997 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333321 graphics.c:3987: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4004: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4004: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 12.700000, got 12.615334 graphics.c:4004: Test succeeded inside todo block: Expected 12.700000, got 12.615334 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 6.350000, got 6.307667 graphics.c:4004: Test succeeded inside todo block: Expected 6.350000, got 6.307667 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4004: Test succeeded inside todo block: Expected 36.000000, got 35.760002 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333344 graphics.c:3987: Test succeeded inside todo block: Expected 18.000000, got 17.880001 graphics.c:4004: Test succeeded inside todo block: Expected 18.000000, got 17.879997 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333321 graphics.c:3987: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4004: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4004: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 12.699999, got 12.615334 graphics.c:4004: Test succeeded inside todo block: Expected 12.699999, got 12.615334 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 6.349999, got 6.307667 graphics.c:4004: Test succeeded inside todo block: Expected 6.349999, got 6.307667 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 35.999996, got 35.760002 graphics.c:4004: Test succeeded inside todo block: Expected 35.999996, got 35.760002 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333344 graphics.c:3987: Test succeeded inside todo block: Expected 17.999998, got 17.880001 graphics.c:4004: Test succeeded inside todo block: Expected 17.999998, got 17.879997 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333321 graphics.c:3987: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4004: Test succeeded inside todo block: Expected 150.000000, got 149.000000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4004: Test succeeded inside todo block: Expected 75.000000, got 74.500000 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 12.700000, got 12.615334 graphics.c:4004: Test succeeded inside todo block: Expected 12.700000, got 12.615334 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 graphics.c:3987: Test succeeded inside todo block: Expected 6.350000, got 6.307667 graphics.c:4004: Test succeeded inside todo block: Expected 6.350000, got 6.307667 graphics.c:4016: Test succeeded inside todo block: Expected 100.000000, got 99.333336 ``` and one failure: ``` graphics.c:3444: Test failed: Expected 52.000000, got 50.000000 ``` I would need help with testing and reviewing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10788

3 2

Re: [PATCH v5 0/4] MR10680: scrrun: Implement IFile and IFolder Delete and Move methods.
by Nikolay Sivov (＠nsivov) April 30, 2026

April 30, 2026

Nikolay Sivov (@nsivov) commented about dlls/scrrun/tests/filesystem.c: > test_GetSpecialFolder(); > test_MoveFile(); > test_MoveFolder(); > + test_DoOpenPipeStream(); > test_File_Delete(); > - test_Folder_Delete(); > test_File_Move(); > - test_DoOpenPipeStream(); > + test_Folder_Delete(); > + test_Folder_Move(); > Why do you need to shuffle this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10680#note_138424

1 0

[PATCH v12 0/1] MR9840: winepulse.drv: A potential solution to audio crackling
by Dzmitry Keremsha (＠Vyrolian) April 30, 2026

April 30, 2026

I have noticed that winepulse leaves too little headroom when draining the buffer, which very often leads to crackling that can't be fully resolved by manipulating latency. Let's check some math: Let's assume that the buffer (tlength) is at 33ms, and minreq is at 13.3ms. If 13.2 ms were drained, the refill would be denied. If the next timer trigger takes 14ms due to jitter, that leaves us with a 6.1ms margin. As such, if we get any jitter longer than that during refill, we get an underflow. I think this is what leads to crackles. My solution increases timer polling to 5x the frequency, so if 13.2ms were drained, the next timer trigger would happen at around 16ms. That would leave us with a 17ms headroom. The math might not be 100% representation of what happens, but I think it's quite close to reality. On practice, this does indeed help to fully get rid of crackling for an indefinite amount of time, when before they were unevitable. I think this problem is quite urgent, because while this does not happen on every system, it's frequent enough that we see "Audio: Crackling" reports on most games on protondb and there are many forum threads about audio crackling. From my experience, the only solution was switching to winealsa, which is very consistent and does not crackle at all. My experience has been very consistent with forum threads when it came to the nature of crackling. I first noticed it in Balatro, which is a very light game and should not be crackling at all on any setup. Some games have very frequent crackling every 20-30 seconds, or buzzsaw crackling every 10-15 minutes. I hope my idea brings us closer to the ultimate fix, I really look forward to your feedback! -- v12: winepulse.drv: Increase timer frequency https://gitlab.winehq.org/wine/wine/-/merge_requests/9840

2 3

[PATCH 0/8] MR10791: mf/topology_loader: Implement optional nodes basic support.
by Rémi Bernon (＠rbernon) April 30, 2026

April 30, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10645 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10791

3 8

[PATCH v3 0/1] MR10785: msvcrt: Only reject negative timestamps with EINVAL in ctime_s
by Hendrik Borchardt (＠hborchardt) April 30, 2026

April 30, 2026

0 needs to be an allowed value, and negative values should not halt the program but just return EINVAL. This behavior has been observed with the following python script: ```python import ctypes ucrt = ctypes.CDLL("ucrtbase.dll") buf = ctypes.create_string_buffer(26) for i in [1, 0, -1]: print(f"_ctime64_s for time {i}:") t = ctypes.c_int64(i) err = ucrt._ctime64_s(buf, ctypes.c_size_t(26), ctypes.byref(t)) if err == 0: print(buf.value.decode()) else: print(f"Error: {err}") for i in [1, 0, -1]: print(f"_ctime32_s for time {i}:") t = ctypes.c_int32(i) err = ucrt._ctime32_s(buf, ctypes.c_size_t(26), ctypes.byref(t)) if err == 0: print(buf.value.decode()) else: print(f"Error: {err}") # _ctime64_s for time 1: # Thu Jan 1 01:00:01 1970 # # _ctime64_s for time 0: # Thu Jan 1 01:00:00 1970 # # _ctime64_s for time -1: # Error: 22 # # _ctime32_s for time 1: # Thu Jan 1 01:00:01 1970 # # _ctime32_s for time 0: # Thu Jan 1 01:00:00 1970 # # _ctime32_s for time -1: # Error: 22 ``` The bug https://bugs.winehq.org/show_bug.cgi?id=57261 is solved by this, because mongodb tries to pretty-print a 0 timestamp, and sets up its own invalid_parameter_handler, which crashes due to NULL arguments. -- v3: msvcrt: Only reject negative timestamps with EINVAL in ctime_s https://gitlab.winehq.org/wine/wine/-/merge_requests/10785

4 4

[PATCH 0/1] MR10790: hhctrl.ocx: Make Contents/Search/Index children of the tab control.
by Stefan Dösinger (＠stefan) April 30, 2026

April 30, 2026

Right now they are siblings of the tab control and occupy the same area. This causes issues when resizing the search tab: The tab control clears its entire area and the listview only redraws newly created space, causing part of the listview to disappear. The "Search" button is affected too. The contents tab is not affected because the treeview does a full redraw. --- I don't know htmlhelp well enough to be sure if this change is correct. hwndNavigation is exposed through the API and callers may expect to find a certain set of children in it. There are no tests for hhctrl.ocx. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10790

2 1

[PATCH 0/5] MR10779: winex11: Keyboard layouts rework, part 2
by Matteo Bruni (＠Mystral) April 30, 2026

April 30, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10779

3 19

[PATCH v3 0/3] MR6878: dinput: Fix a couple of regressions.
by Paul Gofman (＠gofman) April 30, 2026

April 30, 2026

-- v3: dinput: Once again support creating joystick device with GUID_Joystick. dinput: Derive DIPROP_JOYSTICKID from device path enumeration. dinput/tests: Add tests for joystick id. https://gitlab.winehq.org/wine/wine/-/merge_requests/6878

3 5

Re: [PATCH v3 0/1] MR10760: wusa: Split cabinet path before calling FDICopy. - closed
by David Carrasco Flores (＠dcf1007) April 30, 2026

April 30, 2026

This merge request was closed by David Carrasco Flores. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10760

1 0

[PATCH v2 0/2] MR10789: msvcp120: Ensure that segments are not being allocated when segments table is enlarged.
by Piotr Caban (＠piotr) April 30, 2026

April 30, 2026

-- v2: msvcp120: Don't count segments being allocated when reporting vector capacity. https://gitlab.winehq.org/wine/wine/-/merge_requests/10789

2 2