April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Ziqing Hui (＠zhui) April 12, 2026

April 12, 2026

> This one is confusing. Why would be do encode_sample() more than once? Is it possible to have multiple encoders one after another? Or is the helper name simply misleading and it means "process" in general, instead of "encode"? Sorry for the misleading name. Yes, it means "process" instead of "encode". It is used for transform processing in general, not only for encoding. > What is the idea behind next_transform? It looks like this code allows two transforms at maximum, is there a limit to this chain on Windows? next_transform is for the converter -> encoder case. We support at most two transforms: one converter and one encoder. As far as I now, there is no longer transform chain on Windows. We have 2 cases for the next_transform: 1. next_transform is NULL, in this case, there is only one transform for the stream, or we have already handled converter and we are passing converter output to encoder. 2. next_transform is a encoder, in this case we have converter -> encoder. Having the next_transform parameter makes us be able to handle each case in one single helper function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135891

1 0

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Ziqing Hui (＠zhui) April 12, 2026

April 12, 2026

On Sun Apr 12 01:30:25 2026 +0000, Nikolay Sivov wrote: > I would merge last two commits, because the second one does not do > anything on its own. OK, I'll merge last 2 commits in new version. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135890

1 0

Re: [PATCH v2 0/4] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 12, 2026

April 12, 2026

On Thu Apr 9 01:29:48 2026 +0000, Jan Robert Gerigk wrote: > Great detailed feedback, thanks! That is a lot to work through, I think > it will take me a while. I think I have addressed all feedback points: ntoskrnl: Removed the unnecessary comment and the if (parent_device) check. enumerate_new_device now receives the parent device object directly (no original_parent field). Uses wcslen/malloc instead of lstrlenW/HeapAlloc. Removed error handling gymnastics for get_device_instance_id, if it fails there's no point proceeding. Children and Siblings are stored in separate commits, comments removed. Removed unnecessary if (relations-\>Count \> 0) check. Siblings moved out to their own block. cfgmgr32: CM_Get_Parent implemented in cfgmgr32, setupapi forwards to it. Tests: Simplified CM_Get_Parent error check to CR_SUCCESS || CR_NO_SUCH_DEVNODE. Kept the if (ret == CR_SUCCESS) guard before CM_Get_Device_IDA. The test device is created manually via SetupDiCreateDeviceInfoW, not through bus enumeration, so DEVPKEY_Device_Parent is never stored for it. CM_Get_Parent returns CR_NO_SUCH_DEVNODE in this case, and calling CM_Get_Device_IDA on an uninitialized devnode would crash. Added ok() check for SetupDiRemoveDevice. New commit: cfgmgr32: Fix reading device properties stored as registry subkeys. While switching to cfgmgr32 s internal APIs (devnode_get_device + get_device_property), I found that query_property cannot read properties stored by SetupDiSetDevicePropertyW. It tries to read them as flat value names, but setupapi stores them as registry subkey hierarchies (Properties{GUID}\\XXXX with the data in the default value). Added a fallback to open the property subkey when the flat lookup fails. The final version has been tested locally with a freshly compiled Wine build including all these patches. All tests pass on my local maschine. (26430 ntoskrnl, 4366 setupapi devinst, 235 shcore, 0 failures). Also verified again with my real use-case, CM_Get_Parent correctly returns the USB parent device. The USB license dongle is correctly detected and used by the software. That was incredibly complex for me, I hope I did not miss anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_135887

1 0

[PATCH 0/4] MR10640: user32/tests: Refactor LB_GETCOUNT tests out of the monolithic check test.
by James Hawkins (＠truiken) April 12, 2026

April 12, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10640

2 4

[PATCH 0/1] MR10639: Draft: mscoree: Use coop-aware thread attach functions.
by Esme Povirk (＠madewokherd) April 11, 2026

April 11, 2026

This allows Mono to distinguish between CG-unsafe embedding code (which may access managed objects/data directly) and regular native code (which will not), which is necessary for cooperative suspend to work properly. See https://www.mono-project.com/docs/advanced/runtime/docs/coop-suspend/ Doing this requires that we bracket all uses of MonoObject and other unmanaged pointers. Some redesign was needed to make this possible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10639

2 1

[PATCH 0/3] MR10638: user32/tests: Refactor LB_GETTEXT tests out of the monolithic check test.
by James Hawkins (＠truiken) April 11, 2026

April 11, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10638

2 3

[PATCH 0/3] MR10637: vbscript: Return specific errors for Do keyword, End Class, and property arg count
by Francis De Brabandere (＠francisdb) April 11, 2026

April 11, 2026

Return proper error codes instead of generic 1002 (syntax error): - 1028: "Expected 'While', 'Until' or end of statement" for `Do For`, `Do If`, etc. - 1047: "Expected 'Class'" for mismatched `End` keyword inside class body - 1051: "Number of arguments must be consistent across properties specification" for Property Get/Let/Set arg count mismatch -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10637

2 3

[PATCH v2 0/2] MR10636: msvcp140: Implement basic_istream<char> move assignment.
by Theodoros Chatzigiannakis (＠TChatzigiannakis) April 11, 2026

April 11, 2026

This MR implements a missing operator that is invoked by Native Instruments Kontakt Player (and likely the full Kontakt too). --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issue and coming up with the fix._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v2: msvcp140: Implement basic_istream<char> move assignment. msvcp140/tests: Add basic_istream<char> move assignment tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10636

3 7

[PATCH 0/2] MR10636: Draft: Msvcp140 basic istream assign
by Theodoros Chatzigiannakis (＠TChatzigiannakis) April 11, 2026

April 11, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10636

3 3

[PATCH v7 0/3] MR10359: gdiplus: Implement software path fill for images.
by Conor McCarthy (＠cmccarthy) April 11, 2026

April 11, 2026

Implementation via region fill is relatively slow, and can cause issues in video playback where gdiplus paths are used to render a subtitle string once per frame. They Are Billions exhibits this issue. -- v7: gdiplus: Bypass span combination for intersected rects. https://gitlab.winehq.org/wine/wine/-/merge_requests/10359

3 5