May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/2] MR10809: comctl32: Fix VARHEIGHT rebar scaling when cyIntegral == 0
by Zhiyi Zhang (＠zhiyi) May 25, 2026

May 25, 2026

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > > DestroyWindow(hRebar); > > + /* VARHEIGHT resizing test with cyIntegral == 0 on a horizontal rebar */ > + hRebar = create_rebar_control(0); > + SetWindowLongA(hRebar, GWL_STYLE, GetWindowLongA(hRebar, GWL_STYLE) | RBS_AUTOSIZE); > + check_sizes(); > + rbi.fMask = RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_SIZE | RBBIM_STYLE; At this commit, the test fails, so it will introduce CI failures. You can put the fix in the same commit since the fix is pretty small. ``` mrebar.c:720: Test failed: invalid rect (client) (0,0)-(672,111) - expected (0,0)-(672,65) mrebar.c:720: Test failed: Height mismatch for row 0 - 65 vs 111 mrebar.c:720: Test failed: invalid rect (band) (0,0)-(90,111) - expected (0,0)-(90,65) mrebar.c:720: Test failed: invalid rect (band) (90,0)-(180,111) - expected (90,0)-(180,65) mrebar.c:720: Test failed: invalid rect (band) (180,0)-(672,111) - expected (180,0)-(672,65) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10809#note_141202

1 0

[PATCH 0/1] MR10987: winex11.drv: Wait for the previous request when transitioning from IconicState to NormalState.
by Zhiyi Zhang (＠zhiyi) May 25, 2026

May 25, 2026

Fix a regression from 4c07e556. ea44fc34 is also related. Due to ea44fc34, when calling window_set_wm_state(WithdrawnState), Wine doesn't wait for the previous WM_STATE update to be completed. So when calling window_set_wm_state(WithdrawnState) and then window_set_wm_state(NormalState), the queued NormalState can be overwritten by an unexpected IconicState property notify event from a previous request, causing a window to be stuck in IconicState. For example, ``` 40551.339:012c:fixme:x11drv:window_set_wm_state calling XIconifyWindow for hwnd 0x200ae. ... 40551.340:012c:warn:x11drv:window_set_wm_state window 0x200ae/aa00003 is iconic, remapping to workaround Mutter issues. data->current_state.wm_state 1 data->pending_state.wm_state 3. 40551.340:012c:trace:x11drv:window_set_wm_state window 0x200ae/aa00003, requesting WM_STATE 0x3 -> 0 serial 5227, foreground 0x10020, activate 0 ... 40551.342:012c:warn:x11drv:handle_state_change window 0x200ae/aa00003 mismatch WM_STATE 0x3/5232, expected 0/5227 ``` Fix RiME(493200) sometimes fails to restore from Alt+Tab. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10987

3 3

[PATCH v4 0/6] MR10865: windows.devices.bluetooth: Add an initial implementation for IBluetoothLEDevice, IGattService.
by Vibhav Pant (＠vibhavp) May 25, 2026

May 25, 2026

-- v4: windows.devices.bluetooth: Implement IGattDeviceService::get_AttributeHandle. windows.devices.bluetooth: Implement IGattDeviceService::get_Uuid. windows.devices.bluetooth: Implement IBluetoothLEDevice::get_GattServices. windows.devices.bluetooth: Implement IBluetoothLEDevice::get_DeviceId. windows.devices.bluetooth: Implement BluetoothLEDeviceStatics::FromBluetoothAddressAsync. https://gitlab.winehq.org/wine/wine/-/merge_requests/10865

3 11

Re: [PATCH v6 0/5] MR10942: msvcp90: Add _Sinh _FSinh _LSinh _Cosh _FCosh _LCosh implementation
by Bartosz Kosiorek (＠gang65) May 25, 2026

May 25, 2026

Thank you Piotr for approval and support -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10942#note_141198

1 0

[PATCH v2 0/2] MR10969: wkscli: Add new dll
by Alistair Leslie-Hughes (＠alesliehughes) May 25, 2026

May 25, 2026

-- v2: wkscli: Move some functsion from netapi32 wkscli: Add new dll https://gitlab.winehq.org/wine/wine/-/merge_requests/10969

2 2

Re: [PATCH v6 0/5] MR10942: msvcp90: Add _Sinh _FSinh _LSinh _Cosh _FCosh _LCosh implementation - approved
by Piotr Caban (＠piotr) May 25, 2026

May 25, 2026

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10942

1 0

[PATCH 0/4] MR10988: shell32: Correct several icon IDs and add the computer-turning-off icon.
by Alex Henrie (＠alexhenrie) May 24, 2026

May 24, 2026

I figured it would be less confusing to just add icon 8240 now than to have two comments about big gaps right next to each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10988

2 4

Re: [PATCH v6 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Joerg Rueppel (＠jrueppel) May 24, 2026

May 24, 2026

On Mon May 4 18:58:20 2026 +0000, Matteo Bruni wrote: > Interesting. Great investigation, again :smile: > Yeah, I still think that adding some padding before the data is the way > to go. If fixing that directly at parse time is too complicated we can > maybe make it work with separate allocations if we can also fix > `IDirectXFileData` refcounting. > It turns out that parent nodes apparently are supposed to keep > references to their children (see > [d3dxof-tests.txt](/uploads/a839f73f0f51d012d899b81850579663/d3dxof-tests.txt), > specifically the refcounting tests at the end). If we're lucky, the game > releases the various objects in the "proper" order such that there is no > use-after-free on Windows, and we can avoid it too by replicating this > implementation detail. > We usually don't go about matching native to this level of detail, but > when applications depend on it we effectively have to. Also I haven't > tested the game, so this might be entirely moot. I chose the "padding area in the buffer" path and also merged your additional tests. For the game to work actually only the ptr-4\>=2 test is relevant now though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_141181

1 0

[PATCH v5 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Joerg Rueppel (＠jrueppel) May 24, 2026

May 24, 2026

The original d3dxof.dll does it. Space Empires V writes into the returned buffers for some reason and overwrites adjacent data. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49722 -- v5: d3dxof: Pad with magic value before object data in parse_object(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10278

2 1

[PATCH 0/2] MR10953: Update default i386_CFLAGS
by Matteo Bruni (＠Mystral) May 24, 2026

May 24, 2026

The immediate reason for this is !10716, but I suspect it might come in handy in other places as well. FWIW I've been building Wine with similar CFLAGS for many, many years. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10953

6 16