May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10781: cmd: Fix handling of "ECHO.ON" - approved
by eric pouech (＠epo) May 1, 2026

May 1, 2026

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10781

1 0

[PATCH v4 0/1] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v4: cmd: Add a second set of illegal characters for the quotes strip https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

3 2

[PATCH v6 0/4] MR10680: scrrun: Implement IFile and IFolder Delete and Move methods.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

file_Delete wraps DeleteFileW, honouring the Force flag by clearing readonly attributes. folder_Delete recursively removes contents via the existing delete_file/delete_folder helpers, then RemoveDirectoryW. Both Move methods wrap MoveFileW. -- v6: scrrun: Implement IFolder::Move. scrrun: Implement IFile::Move. scrrun: Implement IFolder::Delete. scrrun: Implement IFile::Delete. https://gitlab.winehq.org/wine/wine/-/merge_requests/10680

3 6

Re: [PATCH v3 0/1] MR10771: msxml6/tests: Add some tests for XMLHTTP API.
by Nikolay Sivov (＠nsivov) May 1, 2026

May 1, 2026

On Fri May 1 10:09:58 2026 +0000, Bernhard Übelacker wrote: > Hello Nikolay, in my ASan gitlab runs I try to use the > "--enable-werror". llvm-mingw started around 2025-03-25 to emit > `warning: variable '...' set but not used.` for several files, which I > currently carry a workaround in [f03a11a3cb](https://gitlab.winehq.org/bernhardu/wine/-/commit/f03a11a3cb957…. > This patches new file dlls/msxml6/tests/httpreq.c in 674900a75b shows > some new such warnings [in this gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/261349#L105). > Because I observed some of this warning got fixed by @jacek (some are > linked in above workarounds commit message) by adding some missing > checks, I guess in this new file are also some checks missing? > And more generally, should these `variable '...' set but not used` be > fixed, even when they do not appear in the regular gcc-mingw builds? Sure, I think we should fix those warnings one way or another. For tests it will most likely mean removing what's unused. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10771#note_138518

1 0

[PATCH v3 0/1] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v3: cmd: Add a second set of illegal characters for the quotes strip https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

2 1

Re: [PATCH v3 0/1] MR10771: msxml6/tests: Add some tests for XMLHTTP API.
by Bernhard Übelacker (＠bernhardu) May 1, 2026

May 1, 2026

Hello Nikolay, in my ASan gitlab runs I try to use the "--enable-werror". llvm-mingw started around 2025-03-25 to emit `warning: variable '...' set but not used.` for several files, which I currently carry a workaround in [f03a11a3cb](https://gitlab.winehq.org/bernhardu/wine/-/commit/f03a11a3cb957…. This patches new file dlls/msxml6/tests/httpreq.c in 674900a75b shows some new such warnings [in this gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/261349#L105). Because I observed some of this warning got fixed by @jacek (some are linked in above workarounds commit message) by adding some missing checks, I guess in this new file are also some checks missing? And more generally, should these `variable '...' set but not used` be fixed, even when they do not appear in the regular gcc-mingw builds? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10771#note_138515

1 0

[PATCH v4 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569)
by Twaik Yont (＠twaik) May 1, 2026

May 1, 2026

Part of !10569. This series prepares wineandroid ioctl dispatch paths for execution on Java-originated threads that do not have a Wine TEB. It does three things: * pass JNIEnv explicitly through the ioctl dispatch path instead of relying on the global jni_env value in handlers * move native window registration from the APC/unixlib callback path to the direct JNI surface_changed callback on the Android UI thread * make logging in device.c context-aware so the same code remains safe both on Wine threads and on Java-only threads The JNIEnv change is a preparatory refactoring. It does not by itself complete the thread model transition, but it removes one of the major implicit dependencies on Wine thread context and makes follow-up changes smaller and easier to review. Moving native window registration to surface_changed removes another dependency on APC-based execution in the desktop process and puts window attachment on the thread that actually receives the Android surface callbacks. A shared lock is used to serialize registration against ioctl dispatch. Finally, logging in device.c is made context-aware. Upcoming changes will run parts of ioctl dispatch on Java-only threads, where the standard Wine TRACE/WARN/FIXME/ERR macros are unsafe because they depend on Wine TEB state. The local logging wrapper preserves normal Wine logging semantics on Wine threads and falls back to Android logging on non-Wine threads, allowing the existing code to keep using the standard logging macros without invasive per-call-site changes. Taken together, these patches remove several implicit Wine-thread-only assumptions from wineandroid ioctl dispatch code and prepare the path for running more of it directly on Java-side threads. -- v4: wineandroid: pass JNIEnv explicitly through ioctl handlers wineandroid: move native window registration to surface_changed wineandroid: use Android logging for ioctl paths https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

2 4

[PATCH v3 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569)
by Twaik Yont (＠twaik) May 1, 2026

May 1, 2026

Part of !10569. This series prepares wineandroid ioctl dispatch paths for execution on Java-originated threads that do not have a Wine TEB. It does three things: * pass JNIEnv explicitly through the ioctl dispatch path instead of relying on the global jni_env value in handlers * move native window registration from the APC/unixlib callback path to the direct JNI surface_changed callback on the Android UI thread * make logging in device.c context-aware so the same code remains safe both on Wine threads and on Java-only threads The JNIEnv change is a preparatory refactoring. It does not by itself complete the thread model transition, but it removes one of the major implicit dependencies on Wine thread context and makes follow-up changes smaller and easier to review. Moving native window registration to surface_changed removes another dependency on APC-based execution in the desktop process and puts window attachment on the thread that actually receives the Android surface callbacks. A shared lock is used to serialize registration against ioctl dispatch. Finally, logging in device.c is made context-aware. Upcoming changes will run parts of ioctl dispatch on Java-only threads, where the standard Wine TRACE/WARN/FIXME/ERR macros are unsafe because they depend on Wine TEB state. The local logging wrapper preserves normal Wine logging semantics on Wine threads and falls back to Android logging on non-Wine threads, allowing the existing code to keep using the standard logging macros without invasive per-call-site changes. Taken together, these patches remove several implicit Wine-thread-only assumptions from wineandroid ioctl dispatch code and prepare the path for running more of it directly on Java-side threads. -- v3: wineandroid: pass JNIEnv explicitly through ioctl handlers wineandroid: move native window registration to surface_changed wineandroid: use Android logging for ioctl paths https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

3 17

[PATCH 0/1] MR10798: shell32: Remove full path from executable file name when trying to retrive App Paths
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Execution from the link can't find DLLs placed at additional paths in `App Paths` due to the assumption that the file name (`szName` parameter) contains only the file name itself, without the path, or that the `App Paths` subkey in the registry can contain the full path. Since registry subkeys cannot contain a backslash, it is safe to remove the path from the file name and use only the file name as the subkey to check and retrieve the path value for the application. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=625 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10798

2 1

[PATCH v8 0/1] MR10509: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

-- v8: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

2 1