- Wine-GitLab - list.winehq.org

[PATCH v4 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Report user-visible error messages to stderr matching Windows behavior for unknown command-line options and missing script file. Display usage information with Wine version when invoked with no arguments. Implement //nologo and //logo flags to control the banner displayed before script execution. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- v4: wscript: Implement error messages, usage output, and //nologo banner. https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 1

[PATCH 0/1] MR10521: Certsetcertificatecontextproperty cert ncrypt key handle prop id
by Benoît Legat (＠blegat) March 31, 2026

March 31, 2026

This is part of my attempt to run the \[Niko Home Control programming software\](https://appdb.winehq.org/objectManager.php?sClass=application&iI… under Wine. This (.NET 8 / Electron app) is performing mTLS with a \[Connected controller voor Niko Home Control II\](https://products.niko.eu/nl-be/article/550-00003). Doing this, it calls `CertSetCertificateContextProperty` with `CERT_NCRYPT_KEY_HANDLE_PROP_ID`. Wine currently does not implement setting this property so it falls through to the default case, with the \``FIXME("%ld: stub\n", dwPropId);` that lead me to try to implement it. According to \[the documentation\](https://learn.microsoft.com/en-us/windows/win32/api/wincryp…, `dwKeySpec` should be set to `CERT_NCRYPT_KEY_SPEC`. This value didn't seem to be defined yet in Wine so I added its definition. \[Its value seems to be \`0xffffffff\`\](https://android.googlesource.com/toolchain/mingw/+/refs/heads/main/mingw-w64-v6.x/mingw-w64-headers/include/wincrypt.h#3434\]. I added tests. Before the changes in `dlls/crypt32/cert.c`, running the tests with `wine 11.5-1` (current version on ArchLinux) the tests give 7 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:553: Test failed: CertSetCertificateContextProperty failed: 80092004 cert.c:559: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:560: Test failed: Expected hCryptProv 0xBEEF1234, got 0 cert.c:562: Test failed: Expected dwKeySpec CERT_NCRYPT_KEY_SPEC, got 2 cert.c:569: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:570: Test failed: Expected handle 0xBEEF1234, got 0 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:587: Test failed: CertSetCertificateContextProperty failed: 80092004 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE871940, 00007FFFFE8530D8, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 7 failures), 0 skipped. ``` After applying my patches like so ``` sudo cp dlls/crypt32/x86_64-windows/crypt32.dll /usr/lib/wine/x86_64-windows/crypt32.dll sudo cp dlls/crypt32/crypt32.so /usr/lib/wine/x86_64-unix/crypt32.so ``` I get 0 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE872F70, 00007FFFFE854988, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 0 failures), 0 skipped. ``` Let me know if there is anything else I can do to help, this is my first contribution to this project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10521

2 1

[PATCH v3 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Report user-visible error messages to stderr matching Windows behavior for unknown command-line options and missing script file. Display usage information with Wine version when invoked with no arguments. Implement //nologo and //logo flags to control the banner displayed before script execution. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- v3: wscript: Implement error messages, usage output, and //nologo banner. https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 1

[PATCH v51 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 31, 2026

March 31, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v51: kernel32: Fix string termination of GetModuleFileName. https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v27 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 31, 2026

March 31, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v27: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v3 0/2] MR10466: ntdll: Consider cgroup CPU limits in init_cpu_info().
by Hiroki Awata (＠castaneai) March 31, 2026

March 31, 2026

On Linux, `init_cpu_info()` uses `sysconf(_SC_NPROCESSORS_ONLN)` which returns the host machine's total CPU count, ignoring cgroup CPU bandwidth limits. This causes applications that scale thread counts based on `GetSystemInfo().dwNumberOfProcessors` to over-subscribe CPUs in container environments (Docker, Kubernetes). This MR reads cgroup v2 `cpu.max` and cgroup v1 `cpu.cfs_quota_us`/`cpu.cfs_period_us` to determine the effective CPU limit, and clamps the reported processor count accordingly. For cgroup v2, it walks up the hierarchy to find the most restrictive quota. Falls back to `sysconf` when no cgroup limit is configured. GNU coreutils 9.8 (September 2025) added similar cgroup v2 awareness to `nproc`: https://github.com/coreutils/coreutils/issues/108 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59556 ## Verification Verified with Wine built from this branch running inside Docker containers (cgroup v2). **Environment:** Docker on Linux (4-core host), Wine 11.5 with this patch applied. ### Without CPU limit ``` $ cat /sys/fs/cgroup/cpu.max max 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 4 ``` All 4 host CPUs are reported. No override is applied when `cpu.max` is unlimited. ### With `--cpus=1.4` ``` $ cat /sys/fs/cgroup/cpu.max 140000 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 1 ``` ### With `--cpus=1.5` ``` $ cat /sys/fs/cgroup/cpu.max 150000 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 2 ``` ### With `--cpus=2.0` ``` $ cat /sys/fs/cgroup/cpu.max 200000 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 2 ``` ### With `--cpus=2.4` ``` $ cat /sys/fs/cgroup/cpu.max 240000 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 2 ``` ### With `--cpus=2.5` ``` $ cat /sys/fs/cgroup/cpu.max 250000 100000 $ wine cmd /c "echo %NUMBER_OF_PROCESSORS%" 3 ``` The rounding uses `(double)quota / period + 0.5`, which rounds to the nearest integer. For example, `--cpus=1.4` rounds down to 1, while `--cpus=1.5` rounds up to 2. -- v3: ntdll: Use system_cpu_mask in get_system_affinity_mask() when available. https://gitlab.winehq.org/wine/wine/-/merge_requests/10466

3 5

[PATCH v2 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 30, 2026

March 30, 2026

Report user-visible error messages to stderr matching Windows behavior for unknown command-line options and missing script file. Display usage information with Wine version when invoked with no arguments. Implement //nologo and //logo flags to control the banner displayed before script execution. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- v2: wscript: Implement error messages, usage output, and //nologo banner. https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 1

[PATCH 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 30, 2026

March 30, 2026

Report user-visible error messages to stderr matching Windows behavior for unknown command-line options and missing script file. Display usage information with Wine version when invoked with no arguments. Implement //nologo and //logo flags to control the banner displayed before script execution. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 1

[PATCH v50 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 30, 2026

March 30, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v50: kernel32: Fix string termination of GetModuleFileName https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v5 0/2] MR10438: configure: fail early on invalid Gradle/SDK
by Twaik Yont (＠twaik) March 30, 2026

March 30, 2026

This change is motivated by the long-standing issue that most Linux distributions ship an outdated Gradle, which is often too old for modern Android builds. In typical Android projects this is solved by using the Gradle wrapper, which ensures a compatible Gradle version is downloaded and used automatically. However, Wine cannot rely on the Gradle wrapper for this purpose, and integrating automatic downloads into the build system is not acceptable, since the build process must not fetch external resources. As a result, Gradle and the Android SDK effectively become external prerequisites that must be provided by the user or by higher-level build scripts. Previously, missing or outdated dependencies would only surface later during the build, often resulting in confusing or hard-to-diagnose errors. This change makes these requirements explicit and enforces them at configure time: - `gradle` is detected, its version is checked, and the resolved path is cached. - `ANDROID_HOME` is required and validated against the expected SDK layout. - A minimal sanity check ensures that a usable `build-tools` installation is present. This allows the build to fail early with clear error messages if the environment is not properly set up, instead of failing deep inside the Gradle build. Additionally, `GRADLE` and `ANDROID_HOME` are cached by configure, so they do not need to be re-specified when invoking make or even present in environment. -- v5: wineandroid: print hint for full APK build when using dummy target configure: validate Android build environment using minimal Gradle project https://gitlab.winehq.org/wine/wine/-/merge_requests/10438

3 13