- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10486: vbscript: Fix error character positions for Exit and Dim statements.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

For invalid Exit statements (e.g. Exit Do outside a Do loop), point the error position at the keyword after Exit (Do/For/Function/Property/Sub) instead of at Exit itself, matching Windows. For duplicate Dim declarations, store the identifier location in dim_decl_t and use it as the error position, so the error points at the duplicate name instead of the Dim keyword. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10486

2 1

[PATCH 0/1] MR10485: vbscript: Return proper errors for orphan Loop and Next keywords.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

When Loop or Next appear outside their enclosing Do/For blocks, Windows returns specific error codes: 1038 ("loop without do") and 1055 ("unexpected Next"). Detect these tokens in parser_error() and set the proper HRESULT instead of the generic E_FAIL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10485

2 1

[PATCH 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

[PATCH v2 0/4] MR10104: user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled
by Ivan Ivlev (＠iviv) March 28, 2026

March 28, 2026

Edit control does not release mouse capture after WM_LBUTTONDOWN has been processed two times in a row. This MR fixes this issue by releasing capture and setting it again on WM_LBUTTONDOWN if window was already captured. I have stumbled upon the app in which edit control process WM_LBUTTONDOWN twice on one mouse click. While in windows it causes no problem, wine edit does not release capture, so other buttons inside this app become unclickable. It happens because when WM_LBUTTONDOWN is processed twice, WM_CAPTURECHANGED is sent and bCaptureState is set to FALSE, then EDIT_WM_LButtonUp does not release capture because bCaptureState is already FALSE. Thing about tests: I have added test case for this problem to be visible. I also had to use todo_wine because SendMessageA for WM_LBUTTONDOWN and WM_LBUTTONUP returns 0 in wine and 1 in windows (which is not the case for combobox test, where SendMessageА for WM_LBUTTONDOWN also returns 1 in wine). -- v2: comctl32_v6/edit: Reset capture on WM_LBUTTONDOWN if already enabled user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled comctl32/tests/edit.c: Test WM_LBUTTONDOWN processing user32/tests/edit.c: Test WM_LBUTTONDOWN processing https://gitlab.winehq.org/wine/wine/-/merge_requests/10104

3 6

[PATCH 0/1] MR10483: vbscript: Return "Illegal assignment" error for Const and function assignment.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Assigning to a Const variable or a function/sub name should return error 501 (Illegal assignment), not 445 (Object doesn't support this action). Change the REF_CONST and REF_FUNC cases in assign_ident() to use MAKE_VBSERROR(VBSE_ILLEGAL_ASSIGNMENT). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10483

2 1

[PATCH v5 0/5] MR10060: Draft: comdlg32: Use XDG Desktop Portal for native file dialogs
by Alexander Wilms (＠Alexander-Wilms) March 28, 2026

March 28, 2026

This adds XDG desktop portal integration for Wine file dialogs, with compatibility fallbacks, and solves https://bugs.winehq.org/show_bug.cgi?id=51134 I used an LLM to create the patches, the wiki does not contain an LLM policy, so I don't know if this is eligible to be merged at all. I used the following sources: - https://github.com/MicrosoftDocs/win32 which contains the markdown sources for e.g. - https://learn.microsoft.com/en-us/windows/win32/menurc/resource-compiler - https://github.com/MicrosoftDocs/sdk-api which contains the markdown sources for e.g. - https://learn.microsoft.com/en-us/windows/win32/api/commdlg/nf-commdlg-geto… - https://github.com/flatpak/xdg-desktop-portal - https://github.com/notepad-plus-plus/notepad-plus-plus to determine what calls are made when choosing Save As, since it initially didn't work - Wine logs from manual testing after adding extensive TRACE calls: - Wine `notepad.exe`: `GetOpenFileNameW` / `GetSaveFileNameW` via portal - Wine `wordpad.exe`: `GetOpenFileNameW` / `GetSaveFileNameW` via portal - [`hammerplusplus.exe`](https://ficool2.github.io/HammerPlusPlus-Website/index.html) (32-bit): `IFileDialog` (`IFileDialog2_fnShow`) Open/Save As via portal - `SumatraPDF.exe`: Open via `GetOpenFileNameW` in auto; Save As uses `GetSaveFileNameW` and falls back in case of the auto policy, but uses portal when forced (WINE_FORCE_PORTAL=1) - `notepad++.exe`: `IFileDialog` (`IFileDialog2_fnShow`) Save As via portal after result-path handling fixes Implementation: - Add a portal backend in `comdlg32` for file open/save requests - Add portal handling for `GetOpenFileNameW`, `GetOpenFileNameA`, `GetSaveFileNameW`, and `GetSaveFileNameA` when requests are compatible with portal features - Route compatible `IFileDialog`/`IFileOpenDialog`/`IFileSaveDialog` paths through the portal - Keep native Wine dialogs in case of unsupported/customized dialog options - Add a combobox to `winecfg` to select the policy for XDG Desktop Portal file dialogs: auto / always / never ![image](/uploads/2a1ded4968485e84aebfc1f0ceed0aa4/image.png){width=900 height=486} ![image](/uploads/0c70d44a21fd9334de55ce64ccb4fa9b/image.png){width=900 height=486} ![image](/uploads/5f3821abbf42809cafd5edbcb343b0f8/image.png){width=485 height=600} -- v5: shell32: route SHBrowseForFolderW through portal when compatible comdlg32/tests: add IFileOpenDialog FOS_PICKFOLDERS runtime check winecfg: add portal file dialog policy and UI comdlg32: route IFileDialog through portal when compatible comdlg32: add XDG desktop portal backend for file dialogs https://gitlab.winehq.org/wine/wine/-/merge_requests/10060

4 8

[PATCH 0/2] MR10482: urlmon: Implement IsValidURL().
by Nello De Gregoris (＠bluechxin) March 28, 2026

March 28, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59552 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10482

2 2

Re: [PATCH v3 0/5] MR10255: dsound: Speed up resampling, part 4
by Anton Baskanov (＠baskanov) March 28, 2026

March 28, 2026

On Sat Mar 28 12:10:20 2026 +0000, Bernhard Übelacker wrote: > Hello Anton Baskanov, unfortunately a git bisect for [bug > #59548](https://bugs.winehq.org/show_bug.cgi?id=59548) about a crash in > function `downsample` is pointing at commit 97f3bffa60b173c43ceef6c96ed5d9a46fccef12. Thanks! Should be fixed by !10479. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255#note_134226

1 0

[PATCH 0/1] MR10481: mscms: Add WcsGetCalibrationManagementState stub.
by Gijs Vermeulen (＠gverm) March 28, 2026

March 28, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59576 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10481

2 1

[PATCH 0/5] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 28, 2026

March 28, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 5