- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR10929: gdi32: Validate count parameter in ExtCreateRegion
by Bartosz Kosiorek (＠gang65) May 17, 2026

May 17, 2026

-- v3: gdi32: Validate count parameter in ExtCreateRegion https://gitlab.winehq.org/wine/wine/-/merge_requests/10929

2 1

[PATCH v5 0/1] MR9038: Draft: msi: implement MsiProvideAssembly[AW]()
by Ratchanan Srirattanamet (＠ratchanan.sr) May 17, 2026

May 17, 2026

TODO: - make awstring version of MsiProvideComponent() and use that. - Actually implement MsiProvideAssemblyA() using the above. - Write conformance test? Dependency: - Have ACTION_PublishAssemblies() record feature (https://gitlab.winehq.org/wine/wine/-/merge_requests/9037) - Have MsiEnumFeatures() fixed. Currently it seems to just look for features at the wrong place and thus is useless for this purpose. (https://gitlab.winehq.org/wine/wine/-/merge_requests/9041) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58578 -- v5: [WIP] msi: implement MsiProvideAssembly[AW]() https://gitlab.winehq.org/wine/wine/-/merge_requests/9038

2 2

[PATCH v27 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) May 17, 2026

May 17, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v27: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 7

[PATCH v7 0/1] MR10541: vbscript: Fast-path assign_value for simple non-refcounted types.
by Francis De Brabandere (＠francisdb) May 17, 2026

May 17, 2026

Skip VariantCopyInd and VariantClear when both source and destination are simple scalar types (VT_I2, VT_I4, VT_R8, VT_BOOL, VT_EMPTY, etc.) that require no memory management. A direct struct assignment suffices for these types. Benchmarks (10M iterations, measured in isolation on top of master): - Do-While loop: 824 -> 472 ms (1.75×) - For + assignment: 324 -> 265 ms (1.22×) - Dict.Items iteration: 683 -> 324 ms (2.1×) - If-Else branching: 726 -> 644 ms (1.13×) Every variable assignment in the interpreter benefits. The fast path eliminates two cross-DLL calls to oleaut32 (VariantCopyInd + VariantClear) for each assignment of simple scalar types (VT_I2, VT_I4, VT_R8, VT_BOOL, etc.), replacing them with a single struct copy. -- v7: vbscript: Fast-path assign_value for simple non-refcounted types. https://gitlab.winehq.org/wine/wine/-/merge_requests/10541

3 5

[PATCH 0/1] MR10926: ntdll,msv1_0: Add fallback paths for systems without posix_spawn().
by Twaik Yont (＠twaik) May 17, 2026

May 17, 2026

This adds fallback implementations for posix_spawn() usage in ntdll and msv1_0. Older Android versions do not provide posix_spawn() or posix_spawnp(). The affected code paths only need simple helper process startup and only distinguish success from failure, so this keeps the existing posix_spawn() implementation where available and uses vfork() with execv()/execvp() otherwise. The ntdll loader path preserves the existing execv-style behavior for a fully built path. The msv1_0 ntlm_auth path preserves the posix_spawnp-style PATH lookup by using execvp() in the fallback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10926

3 2

[PATCH 0/1] MR10929: gdi32: Validate count parameter in ExtCreateRegion
by Bartosz Kosiorek (＠gang65) May 17, 2026

May 17, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10929

2 1

[PATCH v2 0/2] MR10889: ole32: Validate cached clipboard window handle in get_clipbrd_window.
by Aaron Yourk (＠ayourk) May 17, 2026

May 17, 2026

The OLE clipboard caches a per-process window handle. When the STA thread that created this window terminates, the window is destroyed but the stale handle remains cached. Subsequent OleSetClipboard calls use this stale handle, causing OpenClipboard to fail with CLIPBRD_E_CANT_OPEN. Check whether the cached window is still valid using IsWindow() before returning it. If the window has been destroyed, clear the cache so a fresh window is created on the current thread. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59519 -- v2: ole32: Validate cached clipboard window handle in get_clipbrd_window. ole32/tests: Add test for OLE clipboard reuse across STA threads. https://gitlab.winehq.org/wine/wine/-/merge_requests/10889

2 2

[PATCH v4 0/1] MR10906: sapi: Implement ISpVoice::GetStatus, SetPriority and GetPriority.
by Bohdan Tkachenko (＠BohdanTkachenko) May 17, 2026

May 17, 2026

Previously these three methods returned E_NOTIMPL. SetPriority/GetPriority store the priority on the voice and validate it against SPVPRI_NORMAL, SPVPRI_ALERT and SPVPRI_OVER. GetStatus populates SPVOICESTATUS from speech_voice state: - ulCurrentStream tracks the stream currently being processed by speak_proc (set at the start of the worker so it reflects the in-flight stream, and sticks at the last processed value when idle, per MSDN). Stored as last_stream_num on speech_voice. - ulLastStreamQueued reuses the existing cur_stream_num counter, which is incremented before each Speak queues a task. - hrLastResult is the HRESULT of the most recently completed speak (set at the end of speak_proc). - dwRunningState is derived from async_wait_queue_empty(&queue, 0) so it correctly reports SPRS_DONE both when idle and after a purge clears queued tasks. This unblocks Overwatch 2's Audio Captions accessibility TTS, which calls SetPriority during voice setup and tight-polls GetStatus for SPRS_DONE between Speak calls. Add tests covering priority round-trips, GetStatus with a NULL pointer, and status fields before, during and after sync and async Speak calls. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59749 -- v4: sapi: Implement ISpVoice::GetStatus, SetPriority and GetPriority. https://gitlab.winehq.org/wine/wine/-/merge_requests/10906

2 1

[PATCH v6 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Guillaume Raffin (＠TheElectronWill) May 16, 2026

May 16, 2026

These functions are necessary to make some smartcard-based programs work. They rely on the "SmartCard Database", which can be found in the windows registry, at \`HKLM\\SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards\`. I have added extensive unit tests and validated the implementation with a real application (an internal program based on Atos CardOS). As this is my first PR here, please don't hesitate to tell me if something's wrong! I was wondering if the database-related code should be moved to a dedicated file `winscard-database.c`? same for the tests?), let me know what you think. -- v6: winscard: Implement SCardGetCardTypeProviderNameA winscard: Implement SCardListCardsA winscard: Implement SCardListCardsW winscard: Implement SCardGetCardTypeProviderNameW https://gitlab.winehq.org/wine/wine/-/merge_requests/10751

2 9

[PATCH v4 0/3] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Guillaume Raffin (＠TheElectronWill) May 16, 2026

May 16, 2026

These functions are necessary to make some smartcard-based programs work. They rely on the "SmartCard Database", which can be found in the windows registry, at \`HKLM\\SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards\`. I have added extensive unit tests and validated the implementation with a real application (an internal program based on Atos CardOS). As this is my first PR here, please don't hesitate to tell me if something's wrong! I was wondering if the database-related code should be moved to a dedicated file `winscard-database.c`? same for the tests?), let me know what you think. -- v4: winscard: Implement SCardGetCardTypeProviderNameA winscard: Implement SCardListCardsA winscard: Implement SCardGetCardTypeProviderNameW https://gitlab.winehq.org/wine/wine/-/merge_requests/10751

2 4