- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10879: adsldp: Add support for ADS_SEARCHPREF_CHASE_REFERRALS. - approved
by Alexandre Julliard (＠julliard) May 13, 2026

May 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10879

1 0

Re: [PATCH v2 0/1] MR10878: crypt32: Use case-incensitive comparison for registered OID names. - approved
by Alexandre Julliard (＠julliard) May 13, 2026

May 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10878

1 0

Re: [PATCH v2 0/6] MR10880: More -Wunused-but-set-global fixes. - approved
by Alexandre Julliard (＠julliard) May 13, 2026

May 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10880

1 0

Re: [PATCH v2 0/3] MR10881: secur32/tests: Directly use secur32 functions in main.c. - approved
by Alexandre Julliard (＠julliard) May 13, 2026

May 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10881

1 0

[PATCH v4 0/4] MR4457: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) May 13, 2026

May 13, 2026

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- v4: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factor out get_inode_open_sharing. ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. https://gitlab.winehq.org/wine/wine/-/merge_requests/4457

3 5

[PATCH v3 0/1] MR10851: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances via ICreateTypeLib2.
by Francis De Brabandere (＠francisdb) May 13, 2026

May 13, 2026

Alternative to !10461 Build a TKIND_DISPATCH ITypeInfo for each class instance using oleaut32's ICreateTypeLib2 / ICreateTypeInfo API rather than hand-rolling the 22 ITypeInfo methods. The class name comes back from GetDocumentation(MEMBERID_NIL), public funcs and Dim'd properties are exposed via GetFuncDesc/GetVarDesc, and inherited typeinfo machinery (GetContainingTypeLib etc.) works for free. A few assertions are marked todo_wine because Wine's oleaut32 CreateTypeLib2 currently: - adds 7 phantom inherited IDispatch methods to TKIND_DISPATCH typeinfos, inflating cFuncs and zeroing cImplTypes; - returns E_INVALIDARG instead of TYPE_E_BADMODULEKIND from CreateInstance; - doesn't zero the out-parameter on AddressOfMember failure; - returns a reftype from GetRefTypeOfImplType that GetRefTypeInfo can't resolve. The new test passes with 0 failures on native Windows VBScript and on Wine (8 todo_wine on the assertions above). -- v3: vbscript: Implement IDispatch::GetTypeInfo for class instances via ICreateTypeLib2. https://gitlab.winehq.org/wine/wine/-/merge_requests/10851

3 3

[PATCH v3 0/1] MR10886: dsound: Remove unused DSOUND_renderers list and lock.
by Jon Koops (＠jonkoops) May 13, 2026

May 13, 2026

Follow-up to !10735, as suggested by @Mystral. With device sharing removed, the global DSOUND_renderers list is no longer used for lookups. Devices were still added to and removed from the list, but nothing read from it. Remove the list, the critical section protecting it, and the entry field from DirectSoundDevice. -- v3: dsound: Remove unused DSOUND_renderers list and lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/10886

2 2

[PATCH 0/1] MR10792: winepulse.drv: Don't advance read pointer past data not yet consumed by PA
by Dzmitry Keremsha (＠Vyrolian) May 13, 2026

May 13, 2026

Adds a simple throttling mechanism to prevent pointer overlaps when winepulse is faster than the audio server. Winepulse uses a fake clock to advance the pointers: ```c /* regardless of what PA does, advance one period */ adv_bytes = min(stream->period_bytes, stream->held_bytes); stream->lcl_offs_bytes += adv_bytes; stream->lcl_offs_bytes %= stream->real_bufsize_bytes; stream->held_bytes -= adv_bytes; ``` And if winepulse is just a little bit faster than the audio server (does not matter PW or PA), it inevitably leads to pointer overlaps and therefore crackling. This patch proposes a throttling mechanism that is somewhat similar to winealsa - don't ever tell the application we have more space than we actually do. The problem could probably be resolved by making the fake clock perfectly mimic the audio server, but this is orders of magnitude more difficult. Winealsa achieves similar idea this way: `data_frames_played = min(stream->data_in_alsa_frames, avail); stream->held_frames -= data_frames_played;` The issue I am trying to fix is very real - it can cause crackling in any game you try. You don't have to hear the crackling to see that it's mathematically inevitable by logging the difference between held_bytes and pa_held_bytes. If it becomes smaller and goes negative - crackling is inevitable, because pointers will overlap. The issue is not tied to PW or PA specifically, I observed the behavior with both. In regards to how it interacts with MR https://gitlab.winehq.org/wine/wine/-/merge_requests/8628 - no issues in GoWR in my testing, unless you try enabling PROTON_LOG for pulse (which is very spammy in this game), and spam yes on all threads - which would also cause stream resets with unchanged winepulse, just later. Additionally, this patch has already been implemented in Proton GE and Proton CachyOS for about two months now - no issues and it has helped some people. There are not a lot of open issues regarding audio because unfortunately crackling is very underreported - you can look at GoWR protondb page before the 8628 MR - it definitely crackled, but many reports were not stating so. There are a lot of reports of crackling on virtually any game on protondb. You can also see people solve crackling issues for Arc Raiders (which I personally had myself before patching winepulse) by using winealsa: https://github.com/ValveSoftware/Proton/issues/9164#issuecomment-3529760335. One thing to look out for though - in CI spatialaudio tests will fail, but they fail literally the same way they do with winealsa - this is because there is nowhere for audio to go in a virtual environment, pa_held_bytes balloons while held_bytes drops, they overlap and held_bytes stops moving, and the tests start failing. No issues locally. I have previously tried tackling crackling in this pr: https://gitlab.winehq.org/wine/wine/-/merge_requests/9840 (although it was for underflows instead). My approach was admittedly incorrect, however it did help me discover this issue. Good audio is fundamental in my opinion, I would really love to see crackling-free audio for everyone regardless of proton version. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10792

4 50

[PATCH v2 0/1] MR10886: dsound: Remove unused DSOUND_renderers list and lock.
by Jon Koops (＠jonkoops) May 13, 2026

May 13, 2026

Follow-up to !10735, as suggested by @Mystral. With device sharing removed, the global DSOUND_renderers list is no longer used for lookups. Devices were still added to and removed from the list, but nothing read from it. Remove the list, the critical section protecting it, and the entry field from DirectSoundDevice. -- v2: dsound: Remove unused DSOUND_renderers list and lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/10886

2 1

[PATCH 0/1] MR10886: dsound: Remove unused DSOUND_renderers list and lock.
by Jon Koops (＠jonkoops) May 13, 2026

May 13, 2026

Follow-up to !10735, as suggested by @Mystral. With device sharing removed, the global DSOUND_renderers list is no longer used for lookups. Devices were still added to and removed from the list, but nothing read from it. Remove the list, the critical section protecting it, and the entry field from DirectSoundDevice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10886

2 1