- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10760: wusa: Split cabinet path before calling FDICopy.
by David Carrasco Flores (＠dcf1007) April 27, 2026

April 27, 2026

Wine's wusa currently passes the full cabinet path as the `pszCabinet` argument to `FDICopy()` and passes `NULL` as `pszCabPath`. This works with Wine's builtin cabinet implementation, but it does not match the documented FDICopy parameter usage. `FDICopy()` expects `pszCabinet` to contain only the cabinet file name, while `pszCabPath` contains the directory path. Wine's own FDICopy API documentation follows that convention, describing `pszCabinet` as the cabinet filename and `pszCabPath` as the cabinet file path. Microsoft's FDI documentation is more explicit: `pszCabinet` is the cabinet file name excluding path information, and `pszCabPath` is the cabinet path excluding the file name. The full cabinet path is then constructed internally by appending `pszCabinet` to `pszCabPath`. `pszCabPath` is an input `LPSTR` parameter and is not documented as optional. Passing `NULL` is therefore outside the documented API behavior, even though Wine's builtin cabinet.dll currently tolerates it. Native cabinet.dll crashes in this context. These changes are based on the existing path-splitting pattern used by `SetupIterateCabinetA()` in `dlls/setupapi/setupcab.c`, as well as the FDI resource-handling pattern used by `extract_cabinet()` in `dlls/msi/media.c`: - resolve the input path with `GetFullPathNameA()`; - split the result into `pszCabPath` and `pszCabinet`; - pass both values separately to `FDICopy()`; - release allocated memory on failure paths; - destroy the FDI context after `FDICopy()`, regardless of whether extraction succeeds. This improves compatibility with native cabinet.dll, which does not tolerate passing `NULL` for `pszCabPath` in this context. After applying this patch both native (from VistaSP1 and Win7SP1) and built-in cabinet.dll allow the graceful execution of wusa.exe -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10760

2 2

[PATCH 0/1] MR10759: msxml3: Improve attribute value normalization in DOM.
by Nikolay Sivov (＠nsivov) April 27, 2026

April 27, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10759

2 1

[PATCH 0/2] MR10758: wusa: Split cabinet path before calling FDICopy
by David Carrasco Flores (＠dcf1007) April 27, 2026

April 27, 2026

Wine's wusa currently passes the full cabinet path as the `pszCabinet` argument to `FDICopy()` and passes `NULL` as `pszCabPath`. This works with Wine's builtin cabinet implementation, but it does not match the documented FDICopy parameter usage. `FDICopy()` expects `pszCabinet` to contain only the cabinet file name, while `pszCabPath` contains the directory path. Wine's own FDICopy API documentation follows that convention, describing `pszCabinet` as the cabinet filename and `pszCabPath` as the cabinet file path. Microsoft's FDI documentation is more explicit: `pszCabinet` is the cabinet file name excluding path information, and `pszCabPath` is the cabinet path excluding the file name. The full cabinet path is then constructed internally by appending `pszCabinet` to `pszCabPath`. `pszCabPath` is an input `LPSTR` parameter and is not documented as optional. Passing `NULL` is therefore outside the documented API behavior, even though Wine's builtin cabinet.dll currently tolerates it. Native cabinet.dll crashes in this context. These changes are based on the existing path-splitting pattern used by `SetupIterateCabinetA()` in `dlls/setupapi/setupcab.c`, as well as the FDI resource-handling pattern used by `extract_cabinet()` in `dlls/msi/media.c`: - resolve the input path with `GetFullPathNameA()`; - split the result into `pszCabPath` and `pszCabinet`; - pass both values separately to `FDICopy()`; - release allocated memory on failure paths; - destroy the FDI context after `FDICopy()`, regardless of whether extraction succeeds. This improves compatibility with native cabinet.dll, which does not tolerate passing `NULL` for `pszCabPath` in this context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10758

2 4

[PATCH v6 0/5] MR10748: wusa: Recognize runtime.syswow64 expressions.
by David Carrasco Flores (＠dcf1007) April 27, 2026

April 27, 2026

Some update manifests use $(runtime.syswow64) as an explicit target for the 32-bit system directory. wusa currently handles runtime.system32 with WoW64-aware redirection, but does not recognize runtime.syswow64, causing expression expansion to fail. Map runtime.syswow64 to CSIDL_SYSTEMX86 on x86_64, matching the existing runtime.programfilesx86 and runtime.commonfilesx86 handling. -- v6: Revert "wusa: Recognize runtime.syswow64 expressions." https://gitlab.winehq.org/wine/wine/-/merge_requests/10748

2 5

[PATCH v5 0/4] MR10748: wusa: Recognize runtime.syswow64 expressions.
by David Carrasco Flores (＠dcf1007) April 27, 2026

April 27, 2026

Some update manifests use $(runtime.syswow64) as an explicit target for the 32-bit system directory. wusa currently handles runtime.system32 with WoW64-aware redirection, but does not recognize runtime.syswow64, causing expression expansion to fail. Map runtime.syswow64 to CSIDL_SYSTEMX86 on x86_64, matching the existing runtime.programfilesx86 and runtime.commonfilesx86 handling. -- v5: Revert "Merge branch wine:master into master" https://gitlab.winehq.org/wine/wine/-/merge_requests/10748

2 3

[PATCH v5 0/1] MR10757: vbscript: Fix call depth decrement on early returns from exec_script.
by Francis De Brabandere (＠francisdb) April 27, 2026

April 27, 2026

The early-return paths in exec_script skip the call_depth decrement that the normal exit path performs, so any of them leak the depth counter and can spuriously trigger VBSE_OUT_OF_STACK. This is a fix for a regression introduced in !10592 -- v5: vbscript: Move call_depth check past exec_script's setup phase. https://gitlab.winehq.org/wine/wine/-/merge_requests/10757

3 2

Re: [PATCH v6 0/2] MR9775: gdiplus: Move X position calculation to callbacks. - approved
by Alexandre Julliard (＠julliard) April 27, 2026

April 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9775

1 0

Re: [PATCH v5 0/1] MR10485: vbscript: Return proper errors for orphan Loop and Next keywords. - approved
by Alexandre Julliard (＠julliard) April 27, 2026

April 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10485

1 0

Re: [PATCH v13 0/1] MR10314: vbscript: Convert string to number for comparison operators. - approved
by Alexandre Julliard (＠julliard) April 27, 2026

April 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

1 0

Re: [PATCH v5 0/1] MR10692: vbscript: Fix Sub first argument parentheses handling (alt parser-only). - approved
by Alexandre Julliard (＠julliard) April 27, 2026

April 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10692

1 0