- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/7] MR10281: Add some ninput function stubs. - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10281

1 0

Re: [PATCH v2 0/1] MR10282: wintypes: Return S_OK for api_information_statics_IsMethodPresent(). - approved
by Alexandre Julliard (＠julliard) March 10, 2026

March 10, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10282

1 0

Re: [PATCH v4 0/2] MR10250: Call abort if _wassert error behavior is set to _OUT_TO_STDERR and trigger a debug break.
by Piotr Caban (＠piotr) March 10, 2026

March 10, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/exit.c: > _cputs("\nabnormal program termination\n"); > } > #endif > + > raise(SIGABRT); > + > +#if _MSVCR_VER >= 140 > + if (MSVCRT_abort_behavior & _CALL_REPORTFAULT) > + __fastfail(FAST_FAIL_FATAL_APP_EXIT); > +#endif `_CALL_REPORTFAULT` was added in `msvcr80`. It should be probably changed to `_MSVCR_VER >= 80`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10250#note_131758

1 0

Re: [PATCH v4 0/2] MR10250: Call abort if _wassert error behavior is set to _OUT_TO_STDERR and trigger a debug break.
by Piotr Caban (＠piotr) March 10, 2026

March 10, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/exit.c: > wchar_t text[2048]; > _snwprintf(text, sizeof(text), L"File: %ls\nLine: %d\n\nExpression: \"%ls\"", file, line, str); > DoMessageBoxW(L"Assertion failed!", text); > + raise(SIGABRT); > + _exit(3); > } > else > fwprintf(stderr, L"Assertion failed: %ls, file %ls, line %d\n\n", str, file, line); > > - raise(SIGABRT); > - _exit(3); > + abort(); ```suggestion:-3+0 fwprintf(stderr, L"Assertion failed: %ls, file %ls, line %d\n\n", str, file, line); abort(); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10250#note_131757

1 0

Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Matteo Bruni (＠Mystral) March 10, 2026

March 10, 2026

I haven't tried but it seems preferable to always allocate and copy the data directly in `GetNextObject()` and then remove the `!data->level &&` condition from `Release()`, so you don't need to add another field to the struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131748

1 0

Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Matteo Bruni (＠Mystral) March 10, 2026

March 10, 2026

Matteo Bruni (@Mystral) commented about dlls/d3dxof/tests/d3dxof.c: > + hr = IDirectXFileEnumObject_GetNextDataObject(enum_object, &root_data); > + ok(hr == DXFILE_OK, "Unexpected hr %#lx.\n", hr); > + hr = IDirectXFileData_GetData(root_data, NULL, &root_size, &root_ptr); > + ok(hr == DXFILE_OK, "Unexpected hr %#lx.\n", hr); > + > + hr = IDirectXFileData_GetNextObject(root_data, &child_obj); > + ok(hr == DXFILE_OK, "Unexpected hr %#lx.\n", hr); > + > + hr = IDirectXFileObject_QueryInterface(child_obj, &IID_IDirectXFileData, (void** )&child_data); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + hr = IDirectXFileData_GetData(child_data, NULL, &child_size, &child_ptr); > + ok(hr == DXFILE_OK, "Unexpected hr %#lx.\n", hr); > + > + distance = (root_ptr > child_ptr) ? (BYTE*) root_ptr - (BYTE*) child_ptr : (BYTE*) child_ptr - (BYTE*) root_ptr; > + ok(distance > root_size + child_size, "GetData returned adjacent pointers into (likely) shared buffer, must be an isolated allocation\n"); ```suggestion:-0+0 ok(distance > root_size + child_size, "Unexpected distance %u.\n", distance); ``` I'd also add a couple of `ok()` to check for `root_size` and `child_size`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131747

1 0

Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Matteo Bruni (＠Mystral) March 10, 2026

March 10, 2026

Matteo Bruni (@Mystral) commented about dlls/d3dxof/tests/d3dxof.c: > IDirectXFile_Release(dxfile); > } > > +static void test_getdata_isolated_heap_alloc(void) Very much a nitpick, but we generally use "separate" rather than "isolated" in these cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131746

1 0

Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Matteo Bruni (＠Mystral) March 10, 2026

March 10, 2026

Matteo Bruni (@Mystral) commented about dlls/d3dxof/d3dxof.c: > if (!pcbSize || !ppvData) > return DXFILEERR_BADVALUE; > > + if (!This->pdata_user_copy && This->pobj->root->pdata && This->pobj->size > 0) > + { > + This->pdata_user_copy = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->pobj->size); No point in zeroing the memory to then overwrite it immediately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131745

1 0

[PATCH 0/1] MR10290: winebuild: Better handle file extensions.
by Bernhard Kölbl March 10, 2026

March 10, 2026

#### From the commit message: ``` Right now WinRT DLLs are treated as if their name's part after last dot is their extension. This means the string spec->file_name in main() will only carry the module's name, without any file extension. Later on this string will be used as the DLL's export name and written to the name field of IMAGE_DIRECTORY_ENTRY_EXPORT. Meaning the stored name is going to be "windows.foo.bar" instead of "windows.foo.bar.dll", for example. Looking innoncent at first this will cause Wine's DLL loader to get confused, as this string will be used later on to try load builtin DLLs. Loading WinRT DLLs only works by chance right now, because the loader will fall back to treat them as native DLLs. ``` Not sure if this is a good solution though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10290

2 2

[PATCH 0/1] MR10279: configure.ac: fixes libusb detection on FreeBSD
by Thibault Payet (＠thpayet) March 9, 2026

March 9, 2026

This fixes libusb detection on FreeBSD. I don't have a simple program to test though, nor a specific peripheral that need such access. I haven't build on GNU/Linux, but I think that it should not be impacted (hopefully, the build cluster will tell us). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10279

3 2