- Wine-GitLab - list.winehq.org

[PATCH v13 0/9] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 21, 2026

April 21, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59604 Implement CM_Get_Parent by storing device tree relationship properties when ntoskrnl enumerates child devices via IRP_MN_QUERY_DEVICE_RELATIONS: - DEVPKEY_Device_Parent on each child device - DEVPKEY_Device_Children on the parent device - DEVPKEY_Device_Siblings on each child device CM_Get_Parent reads DEVPKEY_Device_Parent through SetupDiGetDevicePropertyW. Also fix SETUPDI_EnumerateMatchingInterfaces to remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration results. --\> no more phantom devices Based on discussion with Rémi Bernon (Bug 59604) Tested on a fresh Wine 11.6 setup with KNX ETS 6.4.1: A USB HID license dongle (VID 2A07, PID 0102) is now correctly identified through CM_Get_Parent device tree navigation. -- v13: setupapi/tests: Add CM_Get_Parent tests. cfgmgr32: Implement CM_Get_Parent using DEVPKEY_Device_Parent property. ntoskrnl: Store DEVPKEY_Device_Siblings on each child after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Children test. ntoskrnl: Store DEVPKEY_Device_Children on parent after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Parent test. ntoskrnl: Store DEVPKEY_Device_Parent when enumerating child devices. setupapi/tests: Add test for DIGCF_DEVICEINTERFACE filter. setupapi: Remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10604

2 9

[PATCH v9 0/3] MR10659: combase: Implement restricted WinRT error handling APIs.
by Anna R Békefi (＠annareginabekefi) April 21, 2026

April 21, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58900 Bug 58900 This series implements restricted WinRT error handling in combase and\ adds conformance tests for the new behavior. Implemented APIs include restricted error creation / retrieval,\ error context capture, transform, matching, and unhandled error reporting\ paths. Tests were added under dlls/combase/tests and pass locally.\ The existing combase tests also continue to pass. -- v9: combase/tests: Temporarily disable restricted error handling test. https://gitlab.winehq.org/wine/wine/-/merge_requests/10659

2 3

[PATCH v4 0/1] MR10452: comctl32/tests: Print id field of logged/expected messages on failure
by Piotr Pawłowski (＠DEATH) April 21, 2026

April 21, 2026

Makes debugging of WM_NOTIFY message sequence errors much easier. -- v4: comctl32/tests: Print id field of logged/expected messages on failure https://gitlab.winehq.org/wine/wine/-/merge_requests/10452

2 1

[PATCH v12 0/9] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 21, 2026

April 21, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59604 Implement CM_Get_Parent by storing device tree relationship properties when ntoskrnl enumerates child devices via IRP_MN_QUERY_DEVICE_RELATIONS: - DEVPKEY_Device_Parent on each child device - DEVPKEY_Device_Children on the parent device - DEVPKEY_Device_Siblings on each child device CM_Get_Parent reads DEVPKEY_Device_Parent through SetupDiGetDevicePropertyW. Also fix SETUPDI_EnumerateMatchingInterfaces to remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration results. --\> no more phantom devices Based on discussion with Rémi Bernon (Bug 59604) Tested on a fresh Wine 11.6 setup with KNX ETS 6.4.1: A USB HID license dongle (VID 2A07, PID 0102) is now correctly identified through CM_Get_Parent device tree navigation. -- v12: setupapi/tests: Add CM_Get_Parent tests. cfgmgr32: Implement CM_Get_Parent using DEVPKEY_Device_Parent property. ntoskrnl: Store DEVPKEY_Device_Siblings on each child after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Children test. ntoskrnl: Store DEVPKEY_Device_Children on parent after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Parent test. ntoskrnl: Store DEVPKEY_Device_Parent when enumerating child devices. setupapi/tests: Add test for DIGCF_DEVICEINTERFACE filter. setupapi: Remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10604

2 9

Re: [PATCH v2 0/1] MR10704: Display invalid Indic syllables
by समीरसिंह Sameer Singh (＠ss141309) April 21, 2026

April 21, 2026

For `lex_Matra_pre` vowels (such as `ि` ) the dotted circle should appear after the vowel sign. I had this snippet for `mark_invalid_combinations` in my attempt to solve this, maybe this could help? ```c if (is_invalid) { original_clust = pwLogClust[i]; insert_pos = g; if (unicode_lex(pwcChars[i]) == lex_Matra_pre) insert_pos = g + 1; insert_glyph(pwGlyphs, pcGlyphs, cChars, write_dir, invalid_glyph, insert_pos, pwLogClust); if (insert_pos > original_clust && write_dir > 0) for (j = 0; j < cChars; j++) if (pwLogClust[j] == original_clust + 1) pwLogClust[j] = original_clust; g++; } ``` There are also some indic vowel signs such as `ൌ` or `ৌ` where the dotted circle should appear in the middle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10704#note_137254

1 0

[PATCH v11 0/10] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 21, 2026

April 21, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59604 Implement CM_Get_Parent by storing device tree relationship properties when ntoskrnl enumerates child devices via IRP_MN_QUERY_DEVICE_RELATIONS: - DEVPKEY_Device_Parent on each child device - DEVPKEY_Device_Children on the parent device - DEVPKEY_Device_Siblings on each child device CM_Get_Parent reads DEVPKEY_Device_Parent through SetupDiGetDevicePropertyW. Also fix SETUPDI_EnumerateMatchingInterfaces to remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration results. --\> no more phantom devices Based on discussion with Rémi Bernon (Bug 59604) Tested on a fresh Wine 11.6 setup with KNX ETS 6.4.1: A USB HID license dongle (VID 2A07, PID 0102) is now correctly identified through CM_Get_Parent device tree navigation. -- v11: setupapi/tests: Add CM_Get_Parent tests. cfgmgr32: Implement CM_Get_Parent using DEVPKEY_Device_Parent property. ntoskrnl/tests: Add DEVPKEY_Device_Siblings test. ntoskrnl: Store DEVPKEY_Device_Siblings on each child after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Children test. ntoskrnl: Store DEVPKEY_Device_Children on parent after bus enumeration. ntoskrnl/tests: Add DEVPKEY_Device_Parent test. ntoskrnl: Store DEVPKEY_Device_Parent when enumerating child devices. setupapi/tests: Add test for DIGCF_DEVICEINTERFACE filter. setupapi: Remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10604

2 12

[PATCH v11 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 21, 2026

April 21, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v11: gdi32: Add test for tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

2 4

[PATCH 0/1] MR10711: odbc32: Add missing object unlock on return in SQLSetEnvAttr().
by Nikolay Sivov (＠nsivov) April 21, 2026

April 21, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10711

4 3

[PATCH v2 0/1] MR10675: scrrun: Implement IFolder and IFile ShortName and ShortPath.
by Francis De Brabandere (＠francisdb) April 21, 2026

April 21, 2026

Both get_ShortPath methods wrap GetShortPathNameW on the stored long path; get_ShortName extracts the last component of the resulting short path. Add matching tests comparing against GetShortPathNameW directly. -- v2: scrrun: Implement IFolder and IFile ShortName and ShortPath. https://gitlab.winehq.org/wine/wine/-/merge_requests/10675

3 3

[PATCH v10 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 21, 2026

April 21, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v10: gdi32: Add test for tmExternalLeading for CFF fonts. tools: Suport generation of otf fonts. win32u/freetype: Fix tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

3 6