- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2
by Esme Povirk (＠madewokherd) Feb. 28, 2026

Feb. 28, 2026

Esme Povirk (@madewokherd) commented about dlls/comdlg32/tests/itemdlg.c: > + } > + oldproc = (WNDPROC)GetPropA(hwnd, "OLD_PROC"); > + if (oldproc) > + return CallWindowProcW(oldproc, hwnd, msg, wparam, lparam); > + return DefWindowProcW(hwnd, msg, wparam, lparam); > +} > + > +static void test_control_events_selection(void) > +{ > + IFileDialog *pfd; > + IFileDialogCustomize *pfdc; > + ITestEventsImpl *events; > + IFileDialogEvents *pEvents; > + DWORD cookie; > + HRESULT hr; > + static const WCHAR button_text[] = {'t','e','s','t','B','u','t','t','o','n', 0}; This pattern is no longer necessary. We can just use `L"testButton"`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10193#note_130842

1 0

Re: [PATCH v5 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2
by Esme Povirk (＠madewokherd) Feb. 28, 2026

Feb. 28, 2026

Esme Povirk (@madewokherd) commented about dlls/comdlg32/tests/itemdlg.c: > + HRESULT hr; > + IFileDialog *pfd; > + > + ok(dwIDCtl == This->button_id, "Expected button ID %lu, got %lu\n", This->button_id, dwIDCtl); > + > + hr = IFileDialogCustomize_QueryInterface(pfdc, &IID_IServiceProvider, (void**)&psp); > + ok(hr == S_OK, "QI for IServiceProvider failed: 0x%08lx\n", hr); > + if (FAILED(hr)) > + { > + return S_OK; > + } > + > + hr = IServiceProvider_QueryService(psp, &IID_IFolderView, &IID_IFolderView2, (void**)&pfv2); > + ok(hr == S_OK, "QueryService for IFolderView2 failed: 0x%08lx\n", hr); > + if (SUCCEEDED(hr)) { > + hr = IFolderView2_GetSelection(pfv2, TRUE, &psia); `psia` is not tested or released. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10193#note_130841

1 0

[PATCH v10 0/12] MR10209: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) Feb. 28, 2026

Feb. 28, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "en-US", search for file "en-US/myapp.exe.mui", and if found, utilize that file for the source of resource data. -- v10: Edit loader.c - found additional tab to space replacement https://gitlab.winehq.org/wine/wine/-/merge_requests/10209

4 16

[PATCH 0/1] MR10214: shell32: Only compute HASSUBFOLDER if requested.
by Tatsuyuki Ishi (＠ishitatsuyuki) Feb. 28, 2026

Feb. 28, 2026

SFGAO_HASSUBFOLDER enumerates the whole subdirectory and the slowness is immediately noticeable in the system file dialog when opening /. Most shell32 users don't require HASSUBFOLDER so skip the computation when not requested. Checked that the file dialog is no longer painfully slow with this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10214

3 3

[PATCH v8 0/11] MR10209: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) Feb. 28, 2026

Feb. 28, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "en-US", search for file "en-US/myapp.exe.mui", and if found, utilize that file for the source of resource data. -- v8: Edit loader.c - replaced positioning of a line of code with spaces instead of tabs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10209

2 11

[PATCH v7 0/10] MR10209: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) Feb. 28, 2026

Feb. 28, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "en-US", search for file "en-US/myapp.exe.mui", and if found, utilize that file for the source of resource data. -- v7: kernelbase/loader.c: Add rudimentary language resource searching https://gitlab.winehq.org/wine/wine/-/merge_requests/10209

2 10

[PATCH v6 0/9] MR10209: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) Feb. 28, 2026

Feb. 28, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "en-US", search for file "en-US/myapp.exe.mui", and if found, utilize that file for the source of resource data. -- v6: kernelbase/loader.c: Add rudimentary multilanguage resource support. https://gitlab.winehq.org/wine/wine/-/merge_requests/10209

2 9

[PATCH v3 0/4] MR10089: mciavi32: Fix handling of the end position in the play command.
by Akihiro Sagawa (＠sgwaki) Feb. 28, 2026

Feb. 28, 2026

In a certain game from 1996, the end of the logo animation was determined by checking whether the video playback had reached its end. However, Wine's avivideo incorrectly reports the end position as one frame short of the actual length. As a result, the app cannot detect the end of video playback without this change. -- v3: mciavi32: Fix handling of the end position in the step command. mciavi32: Fix handling of the end position in the seek command. mciavi32: Fix handling of the end position in the play command. winmm/tests: Add end position tests for avivideo. https://gitlab.winehq.org/wine/wine/-/merge_requests/10089

3 6

[PATCH v11 0/32] MR9928: Draft: dsound: Speed up resampling.
by Anton Baskanov (＠baskanov) Feb. 28, 2026

Feb. 28, 2026

This implements a number of optimizations, in particular: - Swapping around the resampling loops in case of downsampling, allowing the FIR step to stay fixed regardless of the resampling ratio. - Rearranging the FIR array elements to make the access sequential. - Adding SSE versions of the resampling functions. Together, these amount to more than a 5x reduction of `cp_fields_resample` execution time. The quality of the resampling should be the same, or even improve slightly, due to a more precise `rem` calculation and removal of the FIR step rounding, although I haven't yet conducted any measurements. **UPDATE** Added some more optimizations: - Using fixed point math inside the resampling functions. - Optimizing the SSE versions by hand. - Adding AVX+FMA3 versions of the resampling functions. - Getting and putting all channel samples in one go. Combined with the previous ones, these bring the total speedup to 15x for upsampling and 13x for downsampling compared to the upstream. -- v11: dsound: Add a 32-bit SSE version of putsamples_mono2stereo. dsound: Add a 32-bit SSE version of putsamples_stereo. dsound: Add a 32-bit SSE2 version of getsamples16. dsound: Add seperate functions to resample interleaved stereo. dsound: Don't interleave the samples in the put functions. dsound: Don't deinterleave the samples in the get functions. dsound: Perform mixing in the put functions. dsound: Apply volume in the put functions. dsound: Specialize putsamples by channel count. dsound: Get all channel samples in one go. dsound: Put all channel samples in one go. dsound: Get rid of get_aux and call the functions directly. dsound: Get rid of put_aux and call the functions directly. dsound: Name the parameters of bitsgetfunc, bitsputfunc and normfunc. dsound: Add a 32-bit AVX+FMA3 version of downsample. dsound: Add a 32-bit AVX+FMA3 version of upsample. dsound: Add a 32-bit SSE version of downsample. dsound: Add a 32-bit SSE version of upsample. dsound: Use #define for fir.h constants. dsound: Make rem_num signed. dsound: Use a 0.32 fixed point to represent the resampling ratio. dsound: Replace multiplications by fir_step and fir_width with bit shifts. dsound: Premultiply the input value by firgain and the interpolation weights in downsample. dsound: Transpose the FIR array to make the element access sequential. dsound: Calculate firgain more accurately. dsound: Calculate required_input more accurately. dsound: Swap around the two nested loops in downsample. dsound: Don't invert the remainder twice in upsample. dsound: Use a fixed upsampling loop boundary. dsound: Don't pass dsbfirstep to upsample. dsound: Don't apply firgain in upsample. dsound: Split resample into separate downsample and upsample functions. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/9928

1 1

[PATCH v10 0/23] MR9928: Draft: dsound: Speed up resampling.
by Anton Baskanov (＠baskanov) Feb. 28, 2026

Feb. 28, 2026

This implements a number of optimizations, in particular: - Swapping around the resampling loops in case of downsampling, allowing the FIR step to stay fixed regardless of the resampling ratio. - Rearranging the FIR array elements to make the access sequential. - Adding SSE versions of the resampling functions. Together, these amount to more than a 5x reduction of `cp_fields_resample` execution time. The quality of the resampling should be the same, or even improve slightly, due to a more precise `rem` calculation and removal of the FIR step rounding, although I haven't yet conducted any measurements. **UPDATE** Added some more optimizations: - Using fixed point math inside the resampling functions. - Optimizing the SSE versions by hand. - Adding AVX+FMA3 versions of the resampling functions. - Getting and putting all channel samples in one go. Combined with the previous ones, these bring the total speedup to 15x for upsampling and 13x for downsampling compared to the upstream. -- v10: dsound: Initialize freqAccNum to freqAdjustDen / 2. dsound: Get all channel samples in one go. dsound: Put all channel samples in one go. dsound: Get rid of get_aux and call the functions directly. dsound: Get rid of put_aux and call the functions directly. dsound: Add a 32-bit AVX+FMA3 version of downsample. dsound: Add a 32-bit AVX+FMA3 version of upsample. dsound: Add a 32-bit SSE version of downsample. dsound: Add a 32-bit SSE version of upsample. dsound: Use #define for fir.h contants. dsound: Use a 0.32 fixed point number to represent the resampling ratio. dsound: Replace multiplications by fir_step and fir_width with bit shifts. dsound: Premultiply the input value by firgain and the interpolation weights in downsample. dsound: Transpose the FIR array to make the element access sequential. dsound: Calculate firgain more accurately. dsound: Calculate required_input more accurately. dsound: Swap around the two nested loops in downsample. dsound: Don't invert the remainder twice in upsample. dsound: Use a fixed upsampling loop boundary. dsound: Don't pass dsbfirstep to upsample. dsound: Don't apply firgain in upsample. dsound: Split resample into separate downsample and upsample functions. dsound: Use signed int to calculate indices during resampling. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/9928

1 1