- Wine-GitLab - list.winehq.org

[PATCH v2 0/3] MR10190: winu32: Try harder to replace the old drawable everywhere.
by Paul Gofman (＠gofman) Feb. 26, 2026

Feb. 26, 2026

-- v2: win32u: Also try to use DC own drawable in get_updated_drawable() when context is flushed. win32u: Do not keep old drawable as window unused if it was replaced. opengl32: Don't access drawable after wgl_context_flush() in flush_context(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10190

2 4

[PATCH v2 0/6] MR10196: Implement VariantCompare.
by eric pouech (＠epo) Feb. 26, 2026

Feb. 26, 2026

-- v2: propsys: Implement VariantCompare(). propsys/tests: Add tests for VariantCompare(). propsys: Add stub for VariantCompare(). propsys: Add proper support for VT_R4 in PropVariantCompareEx? propsys/tests: Add some tests in PropVariantCompareEx. include: Add definition for VariantCompare in propvarutil.h https://gitlab.winehq.org/wine/wine/-/merge_requests/10196

3 9

[PATCH v24 0/18] MR7111: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) Feb. 26, 2026

Feb. 26, 2026

relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v24: configure: enable LTO by default [DO NOT MERGE] ntoskrnl: move i386 specific Rtl*ByteSwap() into separate source. ntoskrnl: move _chkstk() / __chkstk() into separate source. msvcrt: move i386 specific _ftol() into separate source. kernel32: move x86-64 specific GetProcAddress() into separate source. kernel32: move i386 specific Interlocked*() into separate source. kernel32: move i386 specific ExitProcess() into separate source. kernelbase: move x86-64 specific GetProcAddress() into separate source. ntdll: move i386 specific Rtl*ByteSwap() into separate source. tools: add LTO quirks. makedep: support skipping/disabling LTO. configure: enable building Wine with LTO. makedep: support LTO builds. winegcc: support LTO builds. winebuild: support LTO builds. tools: helper functions for LTO builds. ntdll: add attribute "used" to a few symbols that should not be discarded. loader: add attribute "used" to a few symbols that should not be discarded. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

1 2

Re: [PATCH v7 0/1] MR10174: bcryptprimitives: Abort if `ProcessPrng` fails
by Christopher Denton (＠cdenton) Feb. 26, 2026

Feb. 26, 2026

On Thu Feb 26 07:38:26 2026 +0000, Hans Leidekker wrote: > Even if called once it can still fail. I think we should pass the error > instead of asserting and give the app a chance to handle it. Likely only > a few will actually check for errors from RtlGenRandom() but those that > do will get a chance to clean up and notify the user. To be consistent with Windows behaviour, bcryptprimitives.dll could fail to load if it's not possible to get the `/dev/urandom` fd. This could be done by simply attempting to get some random data when in DllMain. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130602

1 0

[PATCH 0/1] MR10197: mmdevapi/tests: Use temporary during reallocation (ASan).
by Bernhard Übelacker Feb. 26, 2026

Feb. 26, 2026

Followup of d7e358c7. CC: @giomasce It seems `base_fmt` points to memory inside the `wave_formats`, which may be no longer valid after reallocation. <details> <summary>ASan details, [gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/231755#L2473)</summary> ``` ==mmdevapi_test.exe==848==ERROR: AddressSanitizer: heap-use-after-free on address 0x02400110 at pc 0x78654532 bp 0x0022f9e0 sp 0x0022f5b0 READ of size 40 at 0x02400110 thread T0 #0 0x78654531 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x00416bfc in push_wave_format_with_context /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:526:46 #2 0x00416b75 in repush_wave_format_as_unextensible /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:550:11 #3 0x00416041 in fill_wave_formats /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:705:5 #4 0x004181f3 in test_audioclient /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:260:9 #5 0x0041703d in func_render /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:3211:5 #6 0x004340a1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #7 0x00433b5a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #8 0x004359a5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #9 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #10 0x7be4677a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4677a) #11 0x7be470ea in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 0x02400110 is located 0 bytes inside of 44-byte region [0x02400110,0x0240013c) freed by thread T0 here: #0 0x78656013 in __asan::SharedReAlloc(void* (void*, unsigned long, void*, unsigned int) stdcall*, unsigned int (void*, unsigned long, void*) stdcall*, int (void*, unsigned long, void*) stdcall*, void* (void*, unsigned long, unsigned int) stdcall*, void*, unsigned long, void*, unsigned int) /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:276:3 #1 0x786563f8 in HeapReAlloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:408:10 #2 0x79ddf67a in realloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:462:20 #3 0x00416bd7 in push_wave_format_with_context /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:521:24 #4 0x00416b75 in repush_wave_format_as_unextensible /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:550:11 #5 0x00416041 in fill_wave_formats /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:705:5 #6 0x004181f3 in test_audioclient /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:260:9 #7 0x0041703d in func_render /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:3211:5 #8 0x004340a1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #9 0x00433b5a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #10 0x004359a5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #11 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #12 0x7be4677a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4677a) #13 0x7be470ea in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 previously allocated by thread T0 here: #0 0x78655d76 in HeapAlloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:237:3 #1 0x79ddeedc in msvcrt_heap_alloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:71:12 #2 0x79ddf618 in malloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:436:15 #3 0x79ddf682 in realloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:461:20 #4 0x00416bd7 in push_wave_format_with_context /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:521:24 #5 0x00416b2b in push_wave_format /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:534:12 #6 0x0041603c in fill_wave_formats /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:704:5 #7 0x004181f3 in test_audioclient /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:260:9 #8 0x0041703d in func_render /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:3211:5 #9 0x004340a1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #10 0x00433b5a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #11 0x004359a5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #12 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #13 0x7be4677a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4677a) #14 0x7be470ea in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 SUMMARY: AddressSanitizer: heap-use-after-free /builds/bernhardu/wine/build64/../dlls/mmdevapi/tests/render.c:526:46 in push_wave_format_with_context``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10197

3 4

Re: [PATCH v6 0/1] MR10187: bcryptprimitives: Ensure ProcessPrng fills the whole buffer
by Christopher Denton (＠cdenton) Feb. 26, 2026

Feb. 26, 2026

I'm not sure if this can be tested in CI due to the need for a single large allocation (>4gb). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10187#note_130600

1 0

[PATCH 0/2] MR10190: winu32: Try harder to replace the old drawable everywhere.
by Paul Gofman (＠gofman) Feb. 26, 2026

Feb. 26, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10190

3 6

[PATCH 0/5] MR10196: Implement VariantCompare.
by eric pouech (＠epo) Feb. 26, 2026

Feb. 26, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10196

3 6

[PATCH v5 0/1] MR10187: bcryptprimitives: Ensure ProcessPrng fills the whole buffer
by Christopher Denton (＠cdenton) Feb. 26, 2026

Feb. 26, 2026

[`ProcessPrng`](https://learn.microsoft.com/en-us/windows/win32/seccng/processprng) takes a `SIZE_T` argument for its length whereas [`RtlGenRandom`](https://learn.microsoft.com/en-us/windows/win32/api/ntsecapi/nf-ntsecapi-rtlgenrandom) takes a `ULONG`, which may be smaller. -- v5: bcryptprimitives: Ensure ProcessPrng fills the whole buffer https://gitlab.winehq.org/wine/wine/-/merge_requests/10187

2 1

[PATCH v11 0/4] MR10191: Draft: comctl32: Implement Tile view style
by Huw Campbell (＠HuwCampbell) Feb. 26, 2026

Feb. 26, 2026

The Tile View in common controls offers a compact and pretty nice way to show some additional context within the list view, without resorting to the full reports mode. It's used a lot in explorer like programs where things like the disk size and file type are shown. But, it's been sitting unimplemented in wine for a long time. I've just spent a few days implementing this by: - Building a small test program in windows to get a feel for how it works - Hacking just enough to get something displaying - Writing a test suite to try and understand the ownership model, getting, and setting, and the various messages passed by windows. - Fixing up the implementation. - Adjusting my program to use I_COLUMNCALLBACK in windows and testing that. - Fixing my implementation to match the behaviour observed. Full disclosure, I wrote this implementation within the ReactOS build system then copied back the diff as I had that compiling already on my Windows box, and my Mac is an M1 so doesn't play very nicely with Wine. So while I built this code on my Mac in Wine, I can't actually run it there. I'll install a Linux virtual machine at some point and do some testing there too. All bugs and misunderstandings are my own; I used clean room techniques (read MSDN, write a test program, write tests, compare results, iterate). Interesting things: - I initially wrote layout code for tiling mode as well, but a few rounds of playing with my test program and various layouts and settings (things like `LVS_ALIGNTOP`, `LVS_AUTOARRANGE` and `LVS_ALIGNLEFT`) for both tile mode and icon mode convinced me that they same layout logic (or close enough to). - I noticed some differences in Wine's Icon mode layout as compared to Windows 10. - I didn't fix these, one thing at a time. - I noticed and fixed a bug in SetView, where `UpdateItemSize` was called _after_ `Arrange`; that doesn't work. - The Text colours are really odd, if set to black the sub items show up gray, but any other colour and they're the same as the main. - Layout is tricky, in windows it looks like the first item (file name for example) can flow to 2 lines, and subitems are restricted to 1 - But this is really subtle, using GetItemMetrics kind of assumes there's no 'interference' from other items. - If we're on subitem 2, I don't want to have to fetch 0 and 1 to render their sizes before calculating my own, it seems like an `O(N^2)` situation off the bat. - I used a sidechannel from DrawItems, I'm open to other ideas here. - I haven't tested message passing, many of the test failures for listview at the moment look like sequencing errors for messages. I didn't look into it. - The auto mode on Windows 10 looks quite sophisticated, in that it examines many (all) items before deciding the best size. I haven't done anything interesting for auto size mode. - Not really interesting, but the tabs vs spaces situation in this file is a mess. Next Steps ========== - ~~Test with image lists loaded as well~~ - Test properly in Linux - Hope for feedback here (particularly for messages) - Think about auto sizing. If Merged ========= Now that I have a pretty good grasp of how this component works and lays things out, once this is merged I'll see if I can do Groups as well. Pictures: ======== ![image](/uploads/ce9ae8f09686182d84b399b8a8b0e2a4/image.png){width=400} ![image](/uploads/8c9d1eb4c362a07c74291b49989c4fd7/image.png){width=300} Test Program =========== ```C #include <windows.h> #include <commctrl.h> HINSTANCE g_hInst; HWND g_hLV; static void AddItems(HWND hLV) { static UINT puColumns[2] = {1,2}; LVITEMW it = {0}; it.mask = LVIF_TEXT | LVIF_COLUMNS; it.cColumns = I_COLUMNSCALLBACK; it.iItem = 0; it.iSubItem = 0; it.pszText = LPSTR_TEXTCALLBACK; ListView_InsertItem(hLV, &it); ListView_SetItemText(hLV, 0, 1, L"Static"); ListView_SetItemText(hLV, 0, 2, L"1 KB"); ListView_SetItemText(hLV, 0, 3, L"2026-02-23 12:00"); it.cColumns = 2; it.puColumns = puColumns; it.iItem = 1; it.iSubItem = 0; it.pszText = L"bravo.txt"; ListView_InsertItem(hLV, &it); ListView_SetItemText(hLV, 1, 1, L"Text"); ListView_SetItemText(hLV, 1, 2, L"12 KB"); ListView_SetItemText(hLV, 1, 3, L"2026-02-22 09:30"); } static void AddColumns(HWND hLV) { LVCOLUMNW col = {0}; col.mask = LVCF_TEXT | LVCF_WIDTH; col.cx = 160; col.pszText = L"Name"; ListView_InsertColumn(hLV, 0, &col); col.cx = 140; col.pszText = L"Type"; ListView_InsertColumn(hLV, 1, &col); col.cx = 100; col.pszText = L"Size"; ListView_InsertColumn(hLV, 2, &col); col.cx = 180; col.pszText = L"Modified"; ListView_InsertColumn(hLV, 3, &col); } static void EnableTileView(HWND hLV) { SIZE size = { 100, 70 }; LVTILEVIEWINFO tileViewInfo = {0}; tileViewInfo.cbSize = sizeof(tileViewInfo); tileViewInfo.dwFlags = LVTVIF_FIXEDSIZE; tileViewInfo.dwMask = LVTVIM_COLUMNS | LVTVIM_TILESIZE; tileViewInfo.cLines = 3; tileViewInfo.sizeTile = size; ListView_SetTileViewInfo(hLV, &tileViewInfo); ListView_SetView(hLV, LV_VIEW_TILE); } static void OnGetDispInfo(NMLVDISPINFO* pnmv) { if (pnmv->item.iItem < 0) { return; } if (pnmv->item.mask & LVIF_TEXT) { // Demonstrates that Windows is passing us a size 20 buffer to write to. pnmv->item.pszText = pnmv->item.cColumns == 20 ? L"Yes" : L"No"; } if (pnmv->item.mask & LVIF_IMAGE) { pnmv->item.iImage = -1; } if (pnmv->item.mask & LVIF_STATE) { pnmv->item.state = 0; } if (pnmv->item.mask & LVIF_COLUMNS) { pnmv->item.cColumns = 2; pnmv->item.puColumns[0] = 1; pnmv->item.puColumns[1] = 2; } } static LRESULT OnNotify(WPARAM wParam, LPARAM lParam) { switch (((LPNMHDR)lParam)->code) { case LVN_GETDISPINFO: OnGetDispInfo((NMLVDISPINFO*) lParam); break; } return TRUE; } static LRESULT CALLBACK WndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch (msg) { case WM_CREATE: { g_hLV = CreateWindowExW(WS_EX_CLIENTEDGE, WC_LISTVIEWW, L"", WS_CHILD | WS_VISIBLE | LVS_REPORT | LVS_ALIGNTOP | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_AUTOARRANGE, 0, 0, 0, 0, hWnd, (HMENU)1, g_hInst, NULL); ListView_SetExtendedListViewStyle(g_hLV, LVS_EX_DOUBLEBUFFER | LVS_EX_INFOTIP); AddColumns(g_hLV); AddItems(g_hLV); EnableTileView(g_hLV); return 0; } case WM_SIZE: if (g_hLV) MoveWindow(g_hLV, 0, 0, LOWORD(lParam), HIWORD(lParam), TRUE); return 0; case WM_DESTROY: PostQuitMessage(0); return 0; case WM_NOTIFY: OnNotify(wParam, lParam); return 0; } return DefWindowProcW(hWnd, msg, wParam, lParam); } int WINAPI wWinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPWSTR lpCmdLine, int nCmdShow) { INITCOMMONCONTROLSEX iccx; g_hInst = hInstance; /* Initialize common controls */ iccx.dwSize = sizeof(iccx); iccx.dwICC = ICC_STANDARD_CLASSES | ICC_WIN95_CLASSES; InitCommonControlsEx(&iccx); WNDCLASSW wc = {0}; wc.lpfnWndProc = WndProc; wc.hInstance = hInstance; wc.lpszClassName = L"WineLvTileSmoke"; wc.hCursor = LoadCursor(NULL, IDC_ARROW); RegisterClassW(&wc); HWND hWnd = CreateWindowExW(0, wc.lpszClassName, L"ListView Tile puColumns Smoke Test", WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, 700, 450, NULL, NULL, hInstance, NULL); ShowWindow(hWnd, nCmdShow); MSG msg; while (GetMessageW(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessageW(&msg); } return (int)msg.wParam; } ``` -- v11: Fixup icon size setting https://gitlab.winehq.org/wine/wine/-/merge_requests/10191

2 4