- Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 14, 2026

April 14, 2026

On Tue Apr 14 10:17:23 2026 +0000, Rémi Bernon wrote: > It will probably need to be done without adding todo_wine, these tests > more or less closely mimic some application calls, and it will break > what currently works if these tests don't pass anymore. the two todos on success status (lines user32/tests/input.c:5419 and win32u/tests/win32u.c:1810) are because X11 is sending a EnterNotify event when windows open (even though we set the cursor position to 500, 500, outside the window bounds) which winex11.drv converts into a mouse event, that then becomes a pointer event, so we end up with a pointer in history that we shouldn't really --- the todos on GetLastError is because i can't really tell yet what causes INVALID_PARAMETER versus NOACCESS -- as per win32u/tests/win32u.c:1872..1890 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136056

1 0

[PATCH v2 0/1] MR10591: winebth.sys: Support building with dbus older than 1.12.
by Vitaly Lipatov (＠lav) April 14, 2026

April 14, 2026

DBUS_MESSAGE_ITER_INIT_CLOSED and dbus_message_iter_abandon_container_if_open were added in dbus 1.12. Provide a fallback definition for the macro and load the function optionally via dlsym to allow building on systems with older dbus. -- v2: winebth.sys: Support building with dbus older than 1.12. https://gitlab.winehq.org/wine/wine/-/merge_requests/10591

2 2

[PATCH v9 0/5] MR9992: Draft: Introduce ImeToAsciiEx() user driver function for use in winemac
by Marc-Aurel Zent (＠mzent) April 14, 2026

April 14, 2026

-- v9: win32u: Remove builtin WINE_IME_PROCESS_KEY driver call. winemac: Move macdrv_ImeProcessKey logic to ImeProcessKey and macdrv_ImeToAsciiEx. winemac: Implement and use macdrv_ImeToAsciiEx(). win32u: Move IME processing to ImeToAsciiEx. win32u: Introduce new ImeToAsciiEx user driver call. https://gitlab.winehq.org/wine/wine/-/merge_requests/9992

3 9

[PATCH v7 0/1] MR10589: vbscript: Add missing runtime error constants and tests.
by Francis De Brabandere (＠francisdb) April 14, 2026

April 14, 2026

Add VBSE_DUPLICATE_KEY (457) and VBSE_CLASS_NOT_DEFINED (506) error code definitions with their string resources, and add tests for runtime errors 11, 94, 429, 451, 457, and 506. Errors 94 and 506 are marked todo_wine as Wine currently returns incorrect error codes for those cases. Error 28 (out of stack space) is included commented out as Wine crashes with a stack overflow instead of raising the error. -- v7: vbscript: Add missing runtime error constants and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10589

2 1

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > + return pointer; > +} > + > +static struct pointer *find_pointerid(UINT32 id) { > + struct pointer_thread_data *thread_data = get_pointer_thread_data(); > + struct pointer *pointer; > + > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} Are we truly confident that this should be a per-thread list of pointer (and I assume, later, frame history)? If there isn't already we will need tests to make sure it is and that querying pointer info and pointer history from a thread that has never processed any message indeed returns an error. Fwiw we already maintain a list of pointers on wineserver side, I suspect it should perhaps work globally instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136039

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} > + > +static POINT pixel_to_himetric(POINT px) { > + UINT dpi = HIMETRIC / get_system_dpi(); > + > + return (POINT) { > + .x = px.x * dpi, > + .y = px.y * dpi, > + }; We don't use these constructs in Wine yet. It's perhaps acceptable to introduce new usages but it will only make it more difficult to get your patches accepted if you add extra portability questions to be considered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136038

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > +#define HIMETRIC 2540 > + > +static LONG last_frame = 0; > + > +struct pointer { > + UINT32 id; > + struct list entry; > + POINTER_INPUT_TYPE type; > + POINTER_INFO info; > +}; > + > +struct pointer_thread_data { > + struct list known_pointers; > +}; > + There's various style inconsistencies, it will need to be fixed to match win32u code style (spaces in paren, allman braces, etc...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136037

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/user32/tests/input.c: > > memset( &pointer_info, 0xcd, sizeof(pointer_info) ); > ret = pGetPointerInfo( 1, &pointer_info ); > + todo_wine > ok( !ret, "GetPointerInfo succeeded\n" ); > + todo_wine > ok( GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError() ); It will probably need to be done without adding todo_wine, these tests more or less closely mimic some application calls, and it will break what currently works if these tests don't pass anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136036

1 0

[PATCH 0/1] MR10657: cfgmgr32: Fix querying unnamed properties.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10657

2 1

[PATCH 0/1] MR10656: opengl32: Check for GL_EXT_memory_object_fd before filtering extensions.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Fixes: 97f2945b4ca7e3d72e9692592b373dd89b6003f9 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10656

2 1