- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/3] MR10359: gdiplus: Implement software path fill for images.
by Conor McCarthy (＠cmccarthy) March 30, 2026

March 30, 2026

On Fri Mar 27 21:52:12 2026 +0000, Esme Povirk wrote: > My thinking was that if we can represent a single rectangle, and we know > the bounds of span lists, we can almost always skip the loop in > `combine_regions_to_spans` in practice. The combined clipping region and > bounds will almost always be a rectangle, and span lists will fall > within that rectangle. I added a commit for a simple bypass check. Is that something like what you had in mind? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10359#note_134314

1 0

Re: [PATCH v5 0/3] MR10359: gdiplus: Implement software path fill for images.
by Conor McCarthy (＠cmccarthy) March 30, 2026

March 30, 2026

On Fri Mar 27 21:47:55 2026 +0000, Esme Povirk wrote: > This seems wrong in the case where `x > cur_left->x && y < cur_left->y` Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10359#note_134313

1 0

Re: [PATCH v5 0/3] MR10359: gdiplus: Implement software path fill for images.
by Conor McCarthy (＠cmccarthy) March 30, 2026

March 30, 2026

On Mon Mar 30 04:51:35 2026 +0000, Conor McCarthy wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/10359/diffs?diff_id=255510&start_sha=b5512223f77dfb888d18d0b7f3e2b9f8d03ee8f4#6a877dffbf61a8026d9868c8d974e1fd7d3f43d7_2329_2348) Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10359#note_134312

1 0

Re: [PATCH v5 0/3] MR10359: gdiplus: Implement software path fill for images.
by Conor McCarthy (＠cmccarthy) March 30, 2026

March 30, 2026

On Mon Mar 30 04:51:35 2026 +0000, Conor McCarthy wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/10359/diffs?diff_id=255510&start_sha=b5512223f77dfb888d18d0b7f3e2b9f8d03ee8f4#aaf93e29527c1cbc47ec54679da5828ebd679128_4985_4982) Fixed (I think). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10359#note_134311

1 0

[PATCH v25 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 30, 2026

March 30, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v25: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 3

[PATCH v5 0/3] MR10009: mf/topology_loader: Fix some topology loader test failures.
by Conor McCarthy (＠cmccarthy) March 30, 2026

March 30, 2026

A followup MR will move converter connection behaviour closer to native, and maybe revise decoder connection a bit. -- v5: mf/topology_loader: Load the down connection method in topology_branch_connect(). mf/topology_loader: Enumerate branch up types if the node has no current type. mf/topology: Actually set the input type for transforms in IsMediaTypeSupported(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10009

2 4

Re: [PATCH v24 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 29, 2026

March 29, 2026

On Sun Mar 29 23:20:28 2026 +0000, eric pouech wrote: > thanks for updating this > the good news is that this passes the tests, with some interesting coverage > the bad news is that the MR fails on the first real .exe I tested > against (only the flags CERT_PE_IMAGE_DIGEST_RESOURCES > |CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO generate correct information) (for > the other flags, the tests show different values for nt header and > section blobs; to start with) > I tested then only this flag combination on a greater deal of images, > and some fail; it seems however they all fail the same way: they miss to > report an entire section; didn't investigate further the cause; but this > doesn't look to complicated > what I suggest for the next step is to concentrate on this set of flags > (it seems you're not too far way for getting it right); and put a FIXME > at the start of function in case the flags don't match that set; then in > subsequent commits (could be even a different MR) start implementing the > extra flag combination > (test used mainly prints size + md5 of each blob reported in callback > and compare text output on native & biultin) The flags == 0 case is marked as todo_wine. I can add a FIXME but I think it's mostly abandoned on Windows also. CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO should work, as should CERT_PE_IMAGE_DIGEST_RESOURCES |CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO but I haven't done much testing for the CERT_PE_IMAGE_DIGEST_DEBUG_INFO flag, although it probably works. There's 32 bit and 64 bit, and then there's signed vs unsigned binaries. Lots of combinations here. I have written a similar test program and tried a bunch of exes and dlls. I'll try a bunch more. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10295#note_134293

1 0

[PATCH v47 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 29, 2026

March 29, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v47: kernel32: Fix string termination of GetModuleFileName Add tests for GetModuleFileName string termination. https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v6 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v6: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 3

[PATCH v5 0/6] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 29, 2026

March 29, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- v5: gdiplus: Make function which using GdipGetImage* more reboust gdiplus: Fix GdipGetImageHeight gdiplus: Fix GdipGetImageWidth gdiplus: Fix GdipGetImageVerticalResolution gdiplus: Fix GdipGetImageHorizontalResolution https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 6