- Wine-GitLab - list.winehq.org

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about dlls/ws2_32/socket.c: > } > > > -static BOOL protocol_matches_filter( const int *filter, int protocol ) > +static BOOL protocol_matches_filter( const int *filter, unsigned int index ) Would it be more clear to accept `const WSAPROTOCOL_INFOW *` instead of an index into the `supported_protocols` array? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3811

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about dlls/ws2_32/tests/sock.c: > + sum += s; > + carry = s > sum; > + count -= 2; > + } > + sum += carry; /* This won't produce another carry */ > + sum = (sum & 0xffff) + (sum >> 16); > + > + if (count) sum += *data; /* LE-only */ > + > + sum = (sum & 0xffff) + (sum >> 16); > + /* fold in any carry */ > + sum = (sum & 0xffff) + (sum >> 16); > + > + check = ~sum; > + return check; > +} It's much simpler to implement 1's complement checksum without the use of an explicit `carry` variable. How about the following: ```suggestion:-25+0 static UINT16 chksum(BYTE *data, unsigned int count) { UINT16 *ptr = (UINT16 *)data, *end = ptr + count / 2; unsigned int sum = 0; while (ptr != end) { sum += *ptr++; sum = (sum & 0xffff) + (sum >> 16); } if (count % 2) { sum += *(BYTE *)ptr; /* LE-only */ sum = (sum & 0xffff) + (sum >> 16); } return ~sum; } ``` Note that `sum` is in range `[0, 0xfffe]` at the start of each iteration. After addition, the range extends to `[0, 0x1fffd]`; however, since `0xfffd + 0x1 = 0xfffe`, the range folds back to `[0, 0xfffe]`. Ditto for tests in ntdll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3810

1 0

Re: [PATCH v3 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior 2. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/405

1 0

Re: [PATCH v5 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/375

1 0

Re: [PATCH v2 0/1] MR404: mscms: Merge the profile and transform handle tables. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/404

1 0

Re: [PATCH v2 0/2] MR403: ddraw/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/403

1 0

Re: [PATCH v2 0/2] MR402: http.sys: Add support for relative URLs. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/402

1 0

[PATCH v2 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior.
by Rémi Bernon July 8, 2022

July 8, 2022

-- v2: winegstreamer: Check H264 ProcessOutput sample against actual image size. winegstreamer: Use H264 input media type frame size when specified. winegstreamer: Implement H264 SetOutputType by reconfiguring the pipeline. https://gitlab.winehq.org/wine/wine/-/merge_requests/405

2 5

[PATCH 0/1] MR409: crypt32: Recognize 'Microsoft Root Certificate Authority 2011' when verifying...
by Paul Gofman (＠gofman) July 8, 2022

July 8, 2022

crypt32: Recognize 'Microsoft Root Certificate Authority 2011' when verifying the Microsoft root policy. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/409

2 1

[PATCH v5 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) July 8, 2022

July 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v5: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder. https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 9