- Wine-GitLab - list.winehq.org

[PATCH 0/8] MR717: Implement application hives in the registry
by Santino Mazza (＠tati1454) Aug. 26, 2022

Aug. 26, 2022

Initial implementation for registry application hives, this is a step forward to get Visual Studio to run. :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/717

3 11

[PATCH v2 0/3] MR713: mfplat: Partially implement some format description conversion helpers.
by Nikolay Sivov (＠nsivov) Aug. 26, 2022

Aug. 26, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: mfplat: Partially implement MFInitMediaTypeFromAMMediaType(). mfplat: Partially implement MFInitMediaTypeFromVideoInfoHeader(). mfplat/tests: Add some tests for legacy media type conersion functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/713

3 6

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 26, 2022

Aug. 26, 2022

On Fri Aug 26 00:36:32 2022 +0000, Davide Beatrici wrote: > What do you mean? A complex piece of software like this has rigid > standards in order to prevent potential issues from arising, whether > immediately or in the future. > I too made a few mistakes in my merge requests, but I have always taken > the time to fix them and make things look nice. This is what improving > is about. > Also, consider that generally the more reviewers the better: > - @julliard noticed that you changed the WinAPI definitions and > explained that you cannot do that. > - @jhol spotted the icon issue. > - I tested your changes and reported back the results. > Imagine if this merge request was accepted as it was right at the > beginning: guaranteed breakage. > If you deem your contribution(s) important to the project, please put on > hold the MR until you have time to fix it. OK, fair enough. I'm unemployed at the moment, so I have plenty of time, but, it's not always enjoyable. I suppose I can keep it open and work on it when I'm doing better. I found it difficult finding implementations for COM interfaces in the code, and would like to have C++ classes instead, as I notice through public debugging symbols for DLL's on Windows 10, especially comdlg32, that developers at Microsoft are writing significant parts in C++. I bought that up before, but it was dismissed because it may add complexity that others do not want to deal with, and, I agree that C code is more transparent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6971

1 0

[PATCH 0/6] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) Aug. 26, 2022

Aug. 26, 2022

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 7

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 26, 2022

Aug. 26, 2022

On Thu Aug 25 22:59:28 2022 +0000, Ben Cottrell wrote: > I wish you had cut to the point. I'm closing this merge request for now, > and reconsidering whether I should contribute again, because this has > been more difficult than it should have been. What do you mean? A complex piece of software like this has rigid standards in order to prevent potential issues from arising, whether immediately or in the future. I too made a few mistakes in my merge requests, but I have always taken the time to fix them and make things look nice. This is what improving is about. Also, consider that generally the more reviewers the better: - @julliard noticed that you changed the WinAPI definitions and explained that you cannot do that. - @jhol spotted the icon issue. - I tested your changes and reported back the results. Imagine if this merge request was accepted as it was right at the beginning: guaranteed breakage. If you deem your contribution(s) important to the project, please put on hold the MR until you have time to fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6968

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 25, 2022

Aug. 25, 2022

On Thu Aug 25 18:51:50 2022 +0000, jhol wrote: > It looks like you just rotated the up arrow 90-degrees, and it isn't > aligned with the pixel grid making it look blurry. > The original icon was derrived from > `tango-icon-theme-0.8.90/scalable/actions/go-XXX.svg`, but with the > layout adjusted to reduce the size to 24x24 while preserving the > 1-pixel. The end result should match > `tango-icon-theme-0.8.90/22x22/actions/go-XXX.svg` with a 1-pixel > transparent border all around. I wish you had cut to the point. I'm closing this merge request for now, and reconsidering whether I should contribute again, because this has been more difficult than it should have been. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6965

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes - closed
by Ben Cottrell (＠bgc) Aug. 25, 2022

Aug. 25, 2022

This merge request was closed by Ben Cottrell. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672

1 0

Re: [PATCH v3 0/1] MR715: wow64: Take all ARM32 machine types into account - approved
by Alexandre Julliard (＠julliard) Aug. 25, 2022

Aug. 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/715

1 0

Re: [PATCH v2 0/1] MR712: wintypes: Add RoResolveNamespace stub. - approved
by Alexandre Julliard (＠julliard) Aug. 25, 2022

Aug. 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/712

1 0

Re: [PATCH v2 0/2] MR707: shell32: Return NULL from ExtractIcon() for all error cases. - approved
by Alexandre Julliard (＠julliard) Aug. 25, 2022

Aug. 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/707

1 0