- Wine-GitLab - list.winehq.org

Re: [PATCH v28 0/1] MR9442: comctl32/treeview: check for child item before SendExpanding
by Thomas Csovcsity (＠thc13) Dec. 31, 2025

Dec. 31, 2025

On Thu Dec 18 01:04:31 2025 +0000, Zhiyi Zhang wrote: > Please stop rebasing this MR every day. It triggers a notification each > time you rebase the MR. The change in this MR seems simple. Try to see > how to reproduce the bug in a test. That will help you get this MR in > sooner. Otherwise, I will need to figure it out myself when I have time. Ok. Sorry, will stop it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9442#note_126265

1 0

[PATCH v3 0/4] MR9822: Fix possible EA launcher hangs.
by Zhiyi Zhang (＠zhiyi) Dec. 30, 2025

Dec. 30, 2025

Registering window classes in DllMain() is prone to deadlocks. Tests show that comctl32 window classes should probably be registered in RegisterClassNameW(). Fix possible EA launcher hangs due to deadlocks. A deadlock can happen, like the following, based on Tim Clem's findings. Say there are two threads, T1 and T2. T1: does some COM stuff that results in registering the window class OleMainThreadWndClass.\ T1: NtUserRegisterClassExWOW() does get_desktop_window(). Because this is not a built-in class.\ T1: doesn't yet have a desktop window, so it makes one and calls register_builtin_classes().\ T1: starts the pthread_once in register_builtin_classes() to actually register the classes.\ T1: starts calling NtUserRegisterClassExWOW() with its classes.\ T2: loads comctl32.dll, calls its PROCESS_ATTACH. It grabs the loader lock.\ T2: comctl32's DllMain starts registering its classes.\ T2: comctl32's attempts to register classes also call get_desktop_window().\ T2: get_desktop_window hits the pthread_once in register_builtin_classes() and starts waiting for T1 to finish it.\ T1: some built-in class registration results in a LoadImageW call for a class's cursor.\ T1: LoadImage has to grab a resource, so it tries to grab the loader lock.\ T1: the loader lock is held by T2. Deadlock; T2 is waiting on T1, which is waiting on T2. -- v3: comctl32: Register window classes in RegisterClassNameW() instead of DllMain(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9822

3 6

Re: [PATCH v3 0/1] MR9834: user32: Test DlgDirList in a temp directory. - approved
by Alexandre Julliard (＠julliard) Dec. 30, 2025

Dec. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9834

1 0

Re: [PATCH v2 0/1] MR9836: wow64: Only compare the valid segment selector part - approved
by Alexandre Julliard (＠julliard) Dec. 30, 2025

Dec. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9836

1 0

Re: [PATCH v2 0/2] MR9813: iccvid: Implement extended decompression. - approved
by Alexandre Julliard (＠julliard) Dec. 30, 2025

Dec. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9813

1 0

Re: [PATCH v2 0/1] MR9833: wined3d: Invalidate lights when the view matrix changes. - approved
by Alexandre Julliard (＠julliard) Dec. 30, 2025

Dec. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9833

1 0

[PATCH 0/1] MR9840: winepulse: A potential solution to audio crackling
by Dzmitry Keremsha (＠Vyrolian) Dec. 30, 2025

Dec. 30, 2025

I have noticed that winepulse leaves too little headroom when draining the buffer, which very often leads to crackling that can't be fully resolved by manipulating latency. Let's check some math: Let's assume that the buffer (tlength) is at 33ms, and minreq is at 13.3ms. If 13.2 ms were drained, the refill would be denied. If the next timer trigger takes 14ms due to jitter, that leaves us with a 6.1ms margin. As such, if we get any jitter longer than that during refill, we get an underflow. I think this is roughly what leads to crackles. My solution increases timer polling to 5x the frequency, so if 13.2ms were drained, the next timer trigger would happen at around 16ms. That would leave us with a 17ms headroom. The math might not be 100% representation of what happens, but I think it's quite close to reality. On practice, this does indeed help to fully get rid of crackling for an indefinite amount of time, when before they were unevitable. I understand that this might be not the most elegant approach, the 5x increase is arbitrary. I also had to remove the adv_bytes logic and use to_write to move pointers within pulse_write instead. I think this problem is quite urgent, because while this does not happen on every system, it's frequent enough that we see "Audio: Crackling" reports on most games in protondb and there are many forum threads about audio crackling. From my experience, the only solution was switching to winealsa, which is very consistent and does not crackle at all. My experience has been very consistent with forum threads when it came to the nature of crackling. I first noticed it in Balatro, which is a very light game and should not be crackling at all on any setup. Some games have very frequent crackling every 20-30 seconds, or a buzzsaw crackling every 10-15 minutes. I hope my idea brings us closer to the ultimate fix, I really look forward to your feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9840

2 1

[PATCH v8 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński Dec. 30, 2025

Dec. 30, 2025

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v8: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

2 10

[PATCH 0/3] MR9839: dcomp: Create stub implementations for DirectComposition
by Jaakko Hannikainen (＠jgke) Dec. 30, 2025

Dec. 30, 2025

These stub implementations enable Dorico to successfully boot. They don't implement any real rendering or linkings to rendering contexts, they just create various interfaces with methods returning E_NOTIMPL. Notably, the `CompositionDevice` family has some interesting inheritance relations: * `IDCompositionDevice` inherits from `IUnknown` * `IDCompositionDevice2` also inherits from `IUnknown`, rather than `IDCompositionDevice` * `IDCompositionDesktopDevice` and `IDCompositionDevice3` both inherit from `IDCompositionDevice2`, rather than one inheriting from the other This means that a implementation of these needs to provide separate interfaces for at least `IDCompositionDevice` , `IDCompositionDesktopDevice` and `IDCompositionDevice3` . This MR also provides an 'implementation' for `IDCompositionDevice2` . The three commits here are: * Implement bare minimum of the `DCompositionCreateDevice` and `DCompositionCreateDevice2` to get Dorico to boot, ie. return the appropriate interfaces from those functions, which do nothing expect for some additional allocation functions, such as `IDCompositionDevice:CreateTargetForHwnd` . * Implement rest of `DCompositionCreateDevice`, `DCompositionCreateDevice2` and `DCompositionCreateDevice3`, and use shared 1implementations' for all of the related interfaces * Return fake S_OK responses from `IDCompositionDevice:Commit`, `IDCompositionTarget:SetRoot` and `IDCompositionVisual:SetContent` -- Dorico has one tool window where the software actually checks the response codes from all of these, and if any of these return E_NOTIMPL the entire software crashes. These prevent the crash, but the window in question will be rendered completely white. This is my first contribution for Wine, if there's some weird code it's most likely because of me, and not Microsoft. I don't have a bug for Dorico because the installer seems to require half of the internet through winetricks, but I believe this Cubase bug is caused by the same code: https://bugs.winehq.org/show_bug.cgi?id=57680 -- which I couldn't verify because the installers for Cubase currently don't seem work under Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9839

3 7

[PATCH v2 0/1] MR9834: user32: Test DlgDirList in a temp directory.
by James Hawkins (＠truiken) Dec. 29, 2025

Dec. 29, 2025

DlgDirList can fail to enumerate files for the ListBox in some scenarios, e.g., when the current directory is a UNC mount provided by the WSL 2 9P server. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=2948wq -- v2: user32: Test DlgDirList in a temp directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9834

2 1