- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

On Wed Jun 3 18:43:03 2026 +0000, Rose Hellsing wrote: > Is the loop actually necessary? From how I understand it it keeps > re-rolling the cookie until it's no longer the same as the default > sentinel, but the chance for that to happen should be pretty low. Sure, but low is not zero. Some apps crash when the cookie is not set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142125

1 0

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Rose Hellsing (＠axtlos) June 3, 2026

June 3, 2026

On Wed Jun 3 18:42:40 2026 +0000, Alexandre Julliard wrote: > I don't think you should be removing the loop. Is the loop actually necessary? From how I understand it it keeps re-rolling the cookie until it's no longer the same as the default sentinel, but the chance for that to happen should be pretty low. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142124

1 0

[PATCH 0/1] MR11061: hnetcfg: Report 0 returned elements from IEnumVARIANT::Next.
by Tim Clem (＠tclem) June 3, 2026

June 3, 2026

A regression from !10957. MSDN documents that the final argument should be set to the number of returned elements, even if the function returns S_FALSE. steamservice.exe crashes on launch without this; it passes an uninitialized variable as pCeltFetched, so it proceeds to loop over some arbitrary number of (nonexistent) variants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11061

3 2

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

I don't think you should be removing the loop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142122

1 0

Re: [PATCH v6 0/4] MR10992: ddraw: Allow attaching flip chain surfaces surfaces (for v1 surfaces).
by Paul Gofman (＠gofman) June 3, 2026

June 3, 2026

Thanks for spotting this. Also, unsurprisingly, shows up as a test crash if running the test with WINEDEBUG=warn+heap. I've sent https://gitlab.winehq.org/wine/wine/-/merge_requests/11060. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10992#note_142117

1 0

[PATCH v11 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) June 3, 2026

June 3, 2026

-- v11: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 static controls. win32u/tests: Add a test for real window class name retrieval. comctl32/tests: Add tests for RealGetWindowClass. user32/tests: Add tests for RealGetWindowClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

3 8

[PATCH v2 0/3] MR11054: ole32: Implement IStorage::MoveElementTo().
by Dmitry Timoshkov (＠dmitry) June 3, 2026

June 3, 2026

-- v2: ole32: Implement IStorage::MoveElementTo() for storage element. ole32: Implement IStorage::MoveElementTo() for stream element. ole32/tests: Add some tests for IStorage::MoveElementTo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/11054

3 4

[PATCH v4 0/3] MR11003: Isinf
by Bartosz Kosiorek (＠gang65) June 3, 2026

June 3, 2026

-- v4: msvcp90: Add _Isinf long double implementation. msvcp90: Add _Isinf double implementation. msvcp90: Add _Isinf float implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/11003

3 4

[PATCH 0/1] MR11058: winemac: Implement ExtEscape queries for Metal layer creation and release.
by Marc-Aurel Zent (＠mzent) June 3, 2026

June 3, 2026

This exposes similar functionality to `vkCreateWin32SurfaceKHR`, just for projects that implement some sort of graphics backend directly on top of Metal that do not use Vulkan as an in-between layer, like DXMT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11058

3 6

Re: [PATCH v6 0/4] MR10992: ddraw: Allow attaching flip chain surfaces surfaces (for v1 surfaces).
by Bernhard Übelacker (＠bernhardu) June 3, 2026

June 3, 2026

Hello @gofman, it seems this commit triggers new ASan report ([x86](https://gitlab.winehq.org/bernhardu/wine/-/jobs/272959#L2541), [x86_64](https://gitlab.winehq.org/bernhardu/wine/-/jobs/272960#L2532)) By releasing `surface1` in line 6508 it looks like `backbuffer1` got released, too. Therefore the explicit release of `backbuffer1` in line 6510 triggers ASan. Could this be the related to the comment about increased reference counter in [line 6476](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ddraw/tests/dd… ``` /* Looks like here is a ddraw bug here, when deleting a surface the next one in chain gets an extra reference. */ ``` <details> <summary>ASan x86 details></summary> ``` ==ddraw_test.exe==988==ERROR: AddressSanitizer: heap-use-after-free on address 0x02311d50 at pc 0x0043d2b6 bp 0x0022f514 sp 0x0022f510 READ of size 4 at 0x02311d50 thread T0 #0 0x0043d2b5 in test_surface_attachment /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:6510:11 #1 0x004127c5 in func_ddraw1 /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:17101:5 #2 0x0069e311 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #3 0x0069ddca in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #4 0x006a0075 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 #5 0x7bcc35df in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b8235df) #6 0x7be36b9a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc46b9a) #7 0x7be3750a in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:502:9 0x02311d50 is located 16 bytes inside of 300-byte region [0x02311d40,0x02311e6c) freed by thread T0 here: #0 0x766c5aab in free /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:78:3 #1 0x78df7155 in ddraw_surface_wined3d_object_destroyed /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:6235:5 #2 0x777af5d1 in wined3d_texture_sub_resources_destroyed /builds/bernhardu/wine/build64/../dlls/wined3d/texture.c:453:13 #3 0x77633065 in adapter_gl_destroy_texture /builds/bernhardu/wine/build64/../dlls/wined3d/adapter_gl.c:4550:5 #4 0x777aff81 in wined3d_texture_decref /builds/bernhardu/wine/build64/../dlls/wined3d/texture.c:724:9 #5 0x78df2cef in ddraw_surface_cleanup /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:646:5 #6 0x78df2ac2 in ddraw_surface_cleanup /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:625:13 #7 0x78df270e in ddraw_surface_release_iface /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:678:9 #8 0x78df69df in ddraw_surface1_Release /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:789:9 #9 0x0043b21e in test_surface_attachment /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:6508:11 #10 0x004127c5 in func_ddraw1 /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:17101:5 #11 0x0069e311 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #12 0x0069ddca in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #13 0x006a0075 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 #14 0x7bcc35df in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b8235df) #15 0x7be36b9a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc46b9a) #16 0x7be3750a in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:502:9 previously allocated by thread T0 here: #0 0x766c5cae in calloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:98:3 #1 0x78deb031 in ddraw_texture_init /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:6546:25 #2 0x78de9dc9 in ddraw_surface_create /builds/bernhardu/wine/build64/../dlls/ddraw/surface.c:7160:29 #3 0x78dbe3e4 in ddraw1_CreateSurface /builds/bernhardu/wine/build64/../dlls/ddraw/ddraw.c:3112:10 #4 0x00439fad in test_surface_attachment /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:6372:10 #5 0x004127c5 in func_ddraw1 /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:17101:5 #6 0x0069e311 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #7 0x0069ddca in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #8 0x006a0075 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 #9 0x7bcc35df in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b8235df) #10 0x7be36b9a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc46b9a) #11 0x7be3750a in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:502:9 SUMMARY: AddressSanitizer: heap-use-after-free /builds/bernhardu/wine/build64/../dlls/ddraw/tests/ddraw1.c:6510:11 in test_surface_attachment ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10992#note_142086

1 0