- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR10494: vbscript: Return error 1005 for missing opening parenthesis in Sub/Function.
by Francis De Brabandere (＠francisdb) April 9, 2026

April 9, 2026

When a Sub or Function declaration has a closing parenthesis without a matching opening one (e.g. "Sub x)"), Windows returns error 1005 ("expected '('"). Add error productions in FunctionDecl that detect this and set the correct VBSE_EXPECTED_LPAREN error code. -- v3: vbscript: Return error 1005 for missing opening parenthesis in Sub/Function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10494

3 2

[PATCH v3 0/1] MR10491: vbscript: Return error 1054 for Property Let/Set without arguments.
by Francis De Brabandere (＠francisdb) April 9, 2026

April 9, 2026

Add error productions in PropertyDecl that detect when Property Let or Property Set is declared without a parameter list. Windows returns error 1054 (Property Let/Set needs at least one argument) in this case. Previously Wine fell through to the generic E_FAIL path, returning error code 16389. -- v3: vbscript: Return error 1054 for Property Let/Set without arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/10491

3 2

[PATCH v2 0/1] MR10590: vbscript: Reject 'Set Me' with error 1037 instead of crashing.
by Francis De Brabandere (＠francisdb) April 9, 2026

April 9, 2026

Add a check in the Set statement grammar rule to report error 1037 "Invalid use of 'Me' keyword" for 'Set Me = ...', matching Windows. -- v2: vbscript: Reject 'Set Me' with error 1037 instead of crashing. https://gitlab.winehq.org/wine/wine/-/merge_requests/10590

3 2

[PATCH v6 0/1] MR10505: vbscript: Implement Filter function.
by Francis De Brabandere (＠francisdb) April 9, 2026

April 9, 2026

-- v6: vbscript: Implement Filter function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10505

3 3

Re: [PATCH v5 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values
by micha k (＠breiti) April 9, 2026

April 9, 2026

Hi @vibhavp , i just came across this PR by chance because i was researching a bit because we [Zwift on Linux users are looking to use Bluetooth pairing of our fitness equipment.](https://github.com/netbrain/zwift/issues/188#issuecomment-41320… However, when scanning the changelogs/code, i noticed that there is a small typo that occurs in the codebase: `characterisitic` (notice the superfluous "i" before the "t". correct: `characteristic`). Examples of symbols that use this: `winebth_gatt_service_read_characterisitic_value_params`, `IOCTL_WINEBTH_GATT_SERVICE_READ_CHARACTERISITIC_VALUE` Sorry for the noise on this already merged MR, i wanted to mention it somewhere so there is a chance that it can be remedied in a later MR at some point. Thank you for your work on bluetooth in wine. :raised_hands: Greatly appreciated! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10208#note_135670

1 0

[PATCH v6 0/2] MR10571: ntdll: Add NtCreateWaitablePort stub
by Rose Hellsing (＠axtlos) April 9, 2026

April 9, 2026

Some application call NtCreateWaitablePort, which made them crash since it wasn't available. By implementing a stub applications will at least not completely crash. Tested with StarMoney 10, which now throws an internal error instead of crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59494 -- v6: Add test for NtCreateWaitablePort https://gitlab.winehq.org/wine/wine/-/merge_requests/10571

2 4

Re: [PATCH v58 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 9, 2026

April 9, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c: > + /* Handle \\?\ prefix (Extended Length Path) */ > + if (lstrlenW(shortpath) >= 4 && shortpath[0] == '\\' && shortpath[1] == '\\' > + && shortpath[2] == '?' && shortpath[3] == '\\') > + { > + if (wcsnicmp(shortpath + 4, L"UNC\\", 4) == 0) > + { > + FIXME("UNC Extended pathname %s\n", debugstr_w(shortpath)); > + tmplen = lstrlenW(shortpath); > + if (tmplen < longlen) > + { > + if (longpath != shortpath) lstrcpyW(longpath, shortpath); > + return tmplen; > + } > + return tmplen + 1; > + } > + else if ( isalpha(shortpath[4]) && shortpath[5] == ':') I have some reservations about using `isalpha` with `WCHAR`, since its behavior is not defined for wide characters and may vary depending on the locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135664

1 0

Re: [PATCH v58 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 9, 2026

April 9, 2026

On Thu Apr 9 12:53:40 2026 +0000, Vishnunithyasoundhar S wrote: > Changed length of tmplongpath to maximum that can be reached by extended > file length path I'm a bit concerned about allocating 32KB on the stack, as that's quite large. Since adding proper length validation would make this patch more complex, I understand why you avoided it here. Would you leave the buffer size unchanged in this patch and create a follow-up patch that allocates the 32KB temporary buffer on the heap instead? That way we can avoid the stack usage issue without expanding the scope of this merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135663

1 0

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

I would merge last two commits, because the second one does not do anything on its own. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135655

1 0

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/writer.c: > + HRESULT hr = S_OK; > + DWORD status; > + > + while (SUCCEEDED(hr)) > + { > + memset(&output_buffer, 0, sizeof(output_buffer)); > + if (FAILED(hr = allocate_transform_output(transform, &output_buffer.pSample))) > + break; > + > + if (SUCCEEDED(hr = IMFTransform_ProcessOutput(transform, 0, 1, &output_buffer, &status))) > + { > + if (next_transform) > + hr = stream_encode_sample(stream, output_buffer.pSample, next_transform, NULL); > + else > + hr = stream_queue_sample(stream, output_buffer.pSample); > + } This one is confusing. Why would be do encode_sample() more than once? Is it possible to have multiple encoders one after another? Or is the helper name simply misleading and it means "process" in general, instead of "encode"? What is the idea behind next_transform? It looks like this code allows two transforms at maximum, is there a limit to this chain on Windows? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135654

1 0