- Wine-GitLab - list.winehq.org

[PATCH 0/2] MR10605: wmvcore: Initialize COM in async_reader_callback_thread().
by Paul Gofman (＠gofman) April 9, 2026

April 9, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10605

3 4

[PATCH 0/2] MR10583: amstream: Don't return MediaType if it hasn't changed.
by Brendan McGrath (＠redmcg) April 9, 2026

April 9, 2026

Windows will only include a media type on a sample if there was a change in media type compared to the last time the buffer was retrieved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10583

3 3

Re: [PATCH v2 0/4] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Elizabeth Figura (＠zfigura) April 8, 2026

April 8, 2026

It should be possible to test a lot more of this. 1/4 can be tested in setupapi. 2/4 can be tested in ntoskrnl, not just the CM APIs but also retrieving the devpkeys directly. From 2/4: ``` + /* Store parent device relationship for CM_Get_Parent. */ ``` This comment is unnecessary. ``` + if (parent_device) ``` Why are we checking this? When can it be NULL? ``` + { + WCHAR parent_id[MAX_DEVICE_ID_LEN]; + if (!get_device_instance_id( parent_device, parent_id )) + { + if (!SetupDiSetDevicePropertyW( set, &sp_device, &DEVPKEY_Device_Parent, DEVPROP_TYPE_STRING, + (BYTE *)parent_id, (lstrlenW( parent_id ) + 1) * sizeof(WCHAR), 0 )) ``` wcslen() ``` + WARN("Failed to set parent device property.\n"); ``` Precedent notwithstanding, I would make this an ERR since it should never legitimately happen. Or just delete it. ``` + DEVICE_OBJECT *original_parent = parent; ``` FDOs are supposed to pass through IRP_MN_QUERY_ID. You'll note that get_device_id() calls IoGetAttachedDevice() anyway, so this isn't actually accomplishing anything. ``` + /* Store DEVPKEY_Device_Children on the parent and DEVPKEY_Device_Siblings on each child. */ ``` That's more than what the commit message says. Mentioning it in the commit message would be an improvement, but splitting the DEVPKEY_Device_Children and DEVPKEY_Device_Siblings parts to their own commits would be even better. As elsewhere the comment isn't really adding anything. ``` + if (relations->Count > 0) ``` That's unnecessary; the for loop takes care of it. ``` + if (!get_device_instance_id( relations->Objects[i], child_ids[valid_count] )) + { + multi_len += lstrlenW( child_ids[valid_count] ) + 1; + valid_count++; + if (valid_count >= 64) break; + } ``` Error handling here doesn't really make sense. We don't expect get_device_instance_id() to fail other than memory exhaustion, and if it does there's no point proceeding. As elsewhere I would avoid lstr*() functions in favor of simple wcs*(). ``` + children_multi = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, multi_len * sizeof(WCHAR) ); + if (children_multi) ``` You can use malloc(), which is simpler. I also wouldn't bother with checking for memory exhaustion for small allocations in new code. ``` + /* Set DEVPKEY_Device_Siblings on each child (all other children). */ + for (i = 0; i < valid_count; ++i) ``` You can move this out of the "if (valid_count > 0)" block and save a level of indentation. 3/4 should be implemented in cfgmgr32 on top of cfgmgr32 APIs, and setupapi should forward to it. We're in the middle of moving that right now. 4/4: ``` + ok(ret == CR_SUCCESS || ret == CR_FAILURE || ret == CR_NO_SUCH_DEVNODE + || ret == CR_INVALID_DEVNODE, ``` When can all of these happen? Same with the check later. ``` + ok(ret == CR_SUCCESS, "CM_Get_Device_IDA on parent: got %#lx\n", ret); + if (ret == CR_SUCCESS) + trace("Parent of ROOT\\LEGACY_BOGUS\\0000: %s\n", buffer); ``` You don't need that if(). What's the parent ID? Can it be checked? ``` + SetupDiRemoveDevice(set, &device); ``` I would check that this succeeds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_135598

1 0

[PATCH v3 0/1] MR10600: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

For VT_DISPATCH arguments, call the object's default property (DISPID_VALUE) to get a string value instead of returning the object via VariantCopy (Eval) or returning type mismatch (Execute/ ExecuteGlobal). This matches Windows behavior where passing a dispatch object without a default property fails with error 438, and objects with a default property have it invoked to obtain the string to evaluate or execute. -- v3: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10600

2 1

[PATCH v6 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- v6: vbscript: Return "Invalid for loop control variable" error for member expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

[PATCH v5 0/7] MR10569: wineandroid: move ioctl handling to dedicated Java-only thread
by Twaik Yont (＠twaik) April 8, 2026

April 8, 2026

Move ioctl handling out of the Wine APC/unixlib execution path into a dedicated Java-only thread without Wine context. On Android 10+ a number of syscalls are restricted inside the activity process via seccomp, while processes started via fork/exec are not subject to the same limitations. Decoupling ioctl handling from the Wine context is required to eventually run this code outside of the activity process. This change introduces a new transport and execution model where ioctl dispatch no longer depends on Wine thread state, preparing for moving the Android backend into a separate process. The refactor is intentionally split into multiple bisect-safe commits to keep intermediate states functional while gradually migrating the dispatch path. Since this is a fairly large chunk of work, I’d like to make sure we’re aligned before continuing. -- v5: wineandroid: remove legacy unixlib ioctl backend wineandroid: drop old ioctl backend startup and switch to socket transport wineandroid: add socket-based ioctl backend (unused) wineandroid: add reply_fd plumbing to ioctl handlers wineandroid: move native window registration to surface_changed wineandroid: migrate ioctl dispatch logging to Android log wineandroid: simplify client pid handling https://gitlab.winehq.org/wine/wine/-/merge_requests/10569

2 8

Re: [PATCH v13 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i). - approved
by Alexandre Julliard (＠julliard) April 8, 2026

April 8, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

1 0

Re: [PATCH v13 0/3] MR10588: vbscript: Add missing compiler error constants, messages, tests and fixes - approved
by Alexandre Julliard (＠julliard) April 8, 2026

April 8, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

1 0

Re: [PATCH v3 0/1] MR10598: winex11: Use unsigned long for monitor indices generation. - approved
by Alexandre Julliard (＠julliard) April 8, 2026

April 8, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10598

1 0

Re: [PATCH v4 0/8] MR10599: msxml3/tests: Add some more xml() tests. - approved
by Alexandre Julliard (＠julliard) April 8, 2026

April 8, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10599

1 0