- Wine-GitLab - list.winehq.org

[PATCH v6 0/3] MR10565: shcore: Implement Set/GetCurrentProcessExplicitAppUserModelID.
by Jan Robert Gerigk (＠RgSg86) April 8, 2026

April 8, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59625 Set/GetCurrentProcessExplicitAppUserModelID were stubs. Set returned S_OK but discarded the value, Get always returned NULL with E_NOTIMPL. This broke .NET WPF applications that set an AppUserModelID during startup and later retrieve it, causing "String argument cannot be null or empty" crashes. Implement both using a process-wide variable protected by a critical section. Callers receive CoTaskMemAlloc'd copies per the API contract. -- v6: shcore/tests: Add tests for Set/GetCurrentProcessExplicitAppUserModelID. shcore: Implement Set/GetCurrentProcessExplicitAppUserModelID. include: Add identity string length constants to appmodel.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/10565

3 8

[PATCH v5 0/1] MR10505: vbscript: Implement Filter function.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

-- v5: vbscript: Implement Filter function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10505

3 5

[PATCH v2 0/5] MR10569: wineandroid: move ioctl handling to dedicated Java-only thread
by Twaik Yont (＠twaik) April 8, 2026

April 8, 2026

Move ioctl handling out of the Wine APC/unixlib execution path into a dedicated Java-only thread without Wine context. On Android 10+ a number of syscalls are restricted inside the activity process via seccomp, while processes started via fork/exec are not subject to the same limitations. Decoupling ioctl handling from the Wine context is required to eventually run this code outside of the activity process. This change introduces a new transport and execution model where ioctl dispatch no longer depends on Wine thread state, preparing for moving the Android backend into a separate process. The refactor is intentionally split into multiple bisect-safe commits to keep intermediate states functional while gradually migrating the dispatch path. Since this is a fairly large chunk of work, I’d like to make sure we’re aligned before continuing. -- v2: wineandroid: drop old ioctl backend startup and switch to socket transport wineandroid: add socket-based ioctl backend (unused) wineandroid: move native window registration to surface_changed wineandroid: migrate ioctl dispatch logging to Android log wineandroid: Remove redundant backend DPI scaling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10569

2 5

Re: [PATCH v4 0/1] MR10505: vbscript: Implement Filter function.
by Jacek Caban (＠jacek) April 8, 2026

April 8, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + if(!SysStringLen(search)) > + found = 1; > + else > + found = FindStringOrdinal(FIND_FROMSTART, str, SysStringLen(str), > + search, SysStringLen(search), mode) >= 0; > + > + if(conv_str) > + SysFreeString(conv_str); > + > + if(include ? found : !found) > + match_count++; > + } > + > + /* Create result array */ > + bounds.lLbound = 0; > + bounds.cElements = match_count ? match_count : 0; You could just assign `match_count` here, there is no need to check for 0 if we're assigning 0 anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10505#note_135529

1 0

Re: [PATCH v4 0/1] MR10505: vbscript: Implement Filter function.
by Jacek Caban (＠jacek) April 8, 2026

April 8, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + } > + > + SafeArrayUnaccessData(out_sa); > + } > + > + SafeArrayUnaccessData(sa); > + > + if(res) { > + V_VT(res) = VT_ARRAY|VT_VARIANT; > + V_ARRAY(res) = out_sa; > + }else { > + SafeArrayDestroy(out_sa); > + } > + > + SysFreeString(conv_search); > + return S_OK; You could just remove it and share the code with done label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10505#note_135530

1 0

Re: [PATCH v4 0/1] MR10505: vbscript: Implement Filter function.
by Jacek Caban (＠jacek) April 8, 2026

April 8, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + hres = to_string(&data[i - lbound], &conv_str); > + if(FAILED(hres)) { > + SafeArrayUnaccessData(sa); > + goto done; > + } > + str = conv_str; > + } > + > + if(!SysStringLen(search)) > + found = 1; > + else > + found = FindStringOrdinal(FIND_FROMSTART, str, SysStringLen(str), > + search, SysStringLen(search), mode) >= 0; > + > + if(conv_str) > + SysFreeString(conv_str); It's fine to pass NULL to `SysFreeString`, so this check is not needed (same in other cases). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10505#note_135528

1 0

[PATCH v12 0/3] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with string resources and test entries. Fix 6 of the 12 tests by adding error productions for mismatched End keywords in blocks (1012, 1015, 1016, 1022, 1029, 1050). The remaining 6 tests (1006, 1007, 1040, 1052, 1058) are todo_wine pending further parser work. -- v12: vbscript: Return specific errors for unclosed parens, multiple defaults, and default on Property Let/Set. vbscript: Return specific errors for mismatched End keywords in blocks. vbscript: Add missing compiler error constants, messages, and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

3 4

[PATCH v12 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i).
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Treat '(' after tEMPTYBRACKETS as an argument list opener in the lexer, so that expressions like GetArr()(0) or dict.Keys()(i) parse correctly. Also dereference VT_BYREF|VT_VARIANT results in vcall so chained indexing on call results works at runtime. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58051 This includes some of the work done in !10308, preferably that one is merged first. -- v12: vbscript: Support chained call syntax like dict.Keys()(i). https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

3 3

[PATCH v5 0/3] MR10565: shcore: Implement Set/GetCurrentProcessExplicitAppUserModelID.
by Jan Robert Gerigk (＠RgSg86) April 8, 2026

April 8, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59625 Set/GetCurrentProcessExplicitAppUserModelID were stubs. Set returned S_OK but discarded the value, Get always returned NULL with E_NOTIMPL. This broke .NET WPF applications that set an AppUserModelID during startup and later retrieve it, causing "String argument cannot be null or empty" crashes. Implement both using a process-wide variable protected by a critical section. Callers receive CoTaskMemAlloc'd copies per the API contract. -- v5: shcore/tests: Add tests for Set/GetCurrentProcessExplicitAppUserModelID. shcore: Implement Set/GetCurrentProcessExplicitAppUserModelID. include: Add APPLICATION_USER_MODEL_ID length constants to appmodel.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/10565

3 5

[PATCH v10 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i).
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Treat '(' after tEMPTYBRACKETS as an argument list opener in the lexer, so that expressions like GetArr()(0) or dict.Keys()(i) parse correctly. Also dereference VT_BYREF|VT_VARIANT results in vcall so chained indexing on call results works at runtime. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58051 This includes some of the work done in !10308, preferably that one is merged first. -- v10: vbscript: Support chained call syntax like dict.Keys()(i). https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

2 1