- Wine-GitLab - list.winehq.org

[PATCH v6 0/2] MR10546: vbscript: Use indexed lookup for global functions and variables.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

Replace O(N) linear scans through `global_funcs[]` and `global_vars[]` with O(log N) tree lookups for global function and variable resolution. **Global functions:** Scripts that use `ExecuteGlobal` to dynamically generate functions (e.g. Visual Pinball's GLF framework generates ~1000 functions at startup) hit pathological O(N) scan behavior on every `GetRef` call and `GetDispID` lookup. With this change, `GetRef` dispatch over 1000 functions drops from 503ms to 58ms (**8.7x**), reaching parity with Windows (62ms). | Benchmark (1000 dynamic functions) | Before | After | Speedup | Windows | |-----------|--------|-------|---------|---------| | GetRef varied x100K | 503 ms | 58 ms | **8.7x** | 62 ms | | GetRef loop x200K | 292 ms | 82 ms | **3.6x** | 125 ms | | GetRef cached x200K | 35 ms | 35 ms | 1.0x | 85 ms | | Direct call x200K | 35 ms | 46 ms | ~1.0x | 31 ms | **Global variables:** Profiling a real-world 75K-line Visual Pinball table script with 3000+ global variables (registered via multiple `ExecuteGlobal` calls) shows `lookup_identifier`'s linear scan over `global_vars[]` consuming ~55% of total CPU time. Compile-time binding (`bind_local`) does not help here because it only resolves variables declared within the same compilation unit, variables from prior `ExecuteGlobal` calls remain unbound at runtime. Depends on !10544 for the fast `vbs_wcsicmp` used in the tree comparators. -- v6: vbscript: Use indexed lookup for global variables. vbscript: Use indexed lookup for global functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10546

2 2

[PATCH 0/1] MR10594: Draft: vbscript: Log call stack trace on runtime errors.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

Add WARN-level trace output showing the call chain when a runtime error propagates through nested function calls. This helps diagnose errors in ExecuteGlobal/Execute code where the reported error location has no context about which call chain led to it. ``` Example output for WINEDEBUG=warn+vbscript: error 0x80020012 in L"Broken", line 3 called from L"Wrapper", line 2 called from <global>, line 16 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10594

2 2

[PATCH v7 0/3] MR10025: mshtml/msxml3: Add XMLSerializer, embedded XML declaration handling
by Phiality (＠PhialsBasement) April 7, 2026

April 7, 2026

This patchset adds XMLSerializer support and fixes several compatibility issues for Adobe Creative Cloud installer and similar applications. XMLSerializer implementation (mshtml) - Implements the `IXMLSerializer` interface with `serializeToString()` method - Allows JavaScript to serialize DOM elements to XML strings Embedded XML declaration handling (msxml3) - Adds CDATA wrapping for embedded `<?xml?>` declarations inside elements - Windows MSXML tolerates these nested declarations but libxml2 rejects them - The preprocessing step wraps problematic content in CDATA sections before parsing ~~DISPATCH_METHOD|DISPATCH_PROPERTYGET fixes (jscript/mshtml)~~ This was already done !10004 Also added tests for XMLSerializer (empty elements, text nodes, special characters, nested elements, multiple children), embedded XML declaration handling (multiple declarations, deeply nested, encoding attributes, self-closing elements) and DISPATCH_METHOD|DISPATCH_PROPERTYGET behavior in both quirks and standards modes - Filip Bakreski -- v7: mshtml/msxml3/tests: Add tests for XMLSerializer and embedded XML declarations. libs/xml2: Tolerate embedded XML declarations inside elements. mshtml: Add IXMLSerializer implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/10025

6 10

[PATCH v2 0/1] MR10495: vbscript: Return error 1010 for keyword used where identifier expected in Dim.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

When a reserved keyword like If appears after Dim where an identifier is expected (e.g. "Dim If"), Windows returns error 1010 ("expected identifier"). Add an error production in DimDeclList that sets the correct VBSE_EXPECTED_IDENTIFIER error code. -- v2: vbscript: Return error 1010 for keyword used where identifier expected in Dim. https://gitlab.winehq.org/wine/wine/-/merge_requests/10495

2 1

Re: [PATCH v15 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Jinoh Kang (＠iamahuman) April 7, 2026

April 7, 2026

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/signal_x86_64.c: > } > } > > + block_sigusr1(); Is there a reason we're temporarily unblocking here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10419#note_135375

1 0

[PATCH v4 0/1] MR10589: Draft: vbscript: Add missing runtime error constants and tests.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

Add VBSE_DUPLICATE_KEY (457) and VBSE_CLASS_NOT_DEFINED (506) error code definitions with their string resources, and add tests for runtime errors 11, 94, 429, 451, 457, and 506. Errors 94 and 506 are marked todo_wine as Wine currently returns incorrect error codes for those cases. Error 28 (out of stack space) is included commented out as Wine crashes with a stack overflow instead of raising the error. -- v4: vbscript: Add missing runtime error constants and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10589

2 1

Re: [PATCH v3 0/1] MR10511: wineandroid: remove redundant backend DPI scaling - approved
by Alexandre Julliard (＠julliard) April 7, 2026

April 7, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10511

1 0

[PATCH v4 0/1] MR10593: taskmgr: Fix CPU and Memory usage history graphs
by Steven Don (＠shdon) April 7, 2026

April 7, 2026

The graphs on the Task Manager "Performance" tab did not update their size correctly when the window was being resized. This resulted to the graphs being clipped to the default (small) size. This patch releases the existing memory DC and bitmaps when the control is resized and allocates new ones. It also switches from having only 4 horizontal grid lines to having a grid line every 10 rows, making for a grid of squares rather than vertically stretched rectangles. Before: ![taskmgr-before.png](/uploads/89dd9cbf71f87d94e7cb7b5d369b6f8a/taskmgr-before.png){width=574 height=535} After: ![taskmgr-after.png](/uploads/c4d63de40ecf3aac9d42dbfde672c7a8/taskmgr-after.png){width=574 height=535} -- v4: taskmgr: Fix CPU and Memory usage history graphs https://gitlab.winehq.org/wine/wine/-/merge_requests/10593

2 1

Re: [PATCH v2 0/1] MR10572: d3dcompiler: Fix misplaced parentheses. - approved
by Alexandre Julliard (＠julliard) April 7, 2026

April 7, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10572

1 0

Re: [PATCH v9 0/1] MR10404: vbscript: Reject arguments on Class_Initialize and Class_Terminate. - approved
by Alexandre Julliard (＠julliard) April 7, 2026

April 7, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10404

1 0