- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/6] MR10584: cfgmgr32: Implement CM_Get_DevNode_Property* and CM_Get_Device_ID_List*.
by Rémi Bernon (＠rbernon) April 7, 2026

April 7, 2026

v2: Add some broken test results for GitlabCI Windows VMs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10584#note_135290

1 0

[PATCH v8 0/1] MR10404: vbscript: Reject arguments on Class_Initialize and Class_Terminate.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

Windows returns error 1053 when Class_Initialize or Class_Terminate are declared with arguments. Add the same check in compile_class() and store source location in function_decl_t for accurate error reporting. -- v8: vbscript: Reject arguments on Class_Initialize and Class_Terminate. https://gitlab.winehq.org/wine/wine/-/merge_requests/10404

3 2

[PATCH v5 0/1] MR10366: vbscript: Fix For loop getting stuck when expression evaluation fails with On Error Resume Next.
by Francis De Brabandere (＠francisdb) April 7, 2026

April 7, 2026

When a For..To loop's bound expression fails (e.g. UBound on Empty) and On Error Resume Next is active, the error handler fills the step/to stack slots with VT_EMPTY. On the next iteration, VarCmp fails on these values and the error propagates back into the loop, causing an infinite loop. Fix this by handling VarCmp failures in interp_step: exit the loop and report error 92 (For loop not initialized). Also make interp_incc ignore VarAdd failures so execution reaches interp_step for proper cleanup. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54291 -- v5: vbscript: Fix For loop getting stuck when expression evaluation fails with On Error Resume Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/10366

3 2

[PATCH v2 0/6] MR10584: cfgmgr32: Implement CM_Get_DevNode_Property* and CM_Get_Device_ID_List*.
by Rémi Bernon (＠rbernon) April 7, 2026

April 7, 2026

And move remaining stubs from setupapi. -- v2: cfgmgr32: Move remaining stubs from setupapi. setupapi: Forward CM_Get_Device_ID_List(_Size)(_Ex)(A|W) to cfgmgr32. cfgmgr32: Implement CM_Get_Device_ID_List(_Size)(_Ex)(A|W). cfgmgr32: Implement CM_Get_DevNode_Property_Keys(_Ex). setupapi: Forward CM_Get_DevNode_Property(_Ex)(A|W) to cfgmgr32. cfgmgr32: Implement CM_Get_DevNode_Property(_Ex)(A|W). https://gitlab.winehq.org/wine/wine/-/merge_requests/10584

2 6

[PATCH 0/7] MR10585: mf/topology_loader: Always try setting current up type when connecting directly.
by Rémi Bernon (＠rbernon) April 7, 2026

April 7, 2026

And misc refactoring in preparation for further fixes for !10009. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10585

3 9

[PATCH 0/1] MR10587: server: Update user_time when receive MSG_NOTIFY message.
by Yongjie Yao (＠yaoyongjie) April 7, 2026

April 7, 2026

For some applications, such as bean buns, ima， The pop-up menu can be displayed normally when right clicking on the tray icon of an application for the first time, but it will not be displayed every time the tray icon of an application is right clicked in the future. doubao download url: https://www.doubao.com/download/desktop Signed-off-by: yaoyongjie <yaoyongjie(a)uniontech.com> Change-Id: I50d1e3a73b79a4164e53b12f461490ac0a8a540c -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10587

2 1

[PATCH v2 0/2] MR10523: winemac.drv: Try to get GPU VendorId/DeviceId from Vulkan/MoltenVK.
by Jactry Zeng (＠jactry) April 7, 2026

April 7, 2026

Some PlayStation PC SDK games get the vendor id and device id from dxgi adapter's GetDesc() and then construct a path based on it and try to find out the matched device from 'HKLM\System\CurrentControlSet\Enum\PCI' as an active GPU. Currently, device id can be inconsistent in winemac.drv and wined3d for Apple Silicon on macOS. The first patch tries to query it from Vulkan to make it consistent with the device id in wined3d. -- v2: wined3d/vk: Make deviceID always PCI-compatible. winemac.drv: Try to get GPU VendorId/DeviceId from Vulkan/MoltenVK. https://gitlab.winehq.org/wine/wine/-/merge_requests/10523

3 4

Re: [PATCH v54 0/2] MR10291: Fix GetModuleFileName string termination
by Alexandre Julliard (＠julliard) April 7, 2026

April 7, 2026

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/loader.c: > +static void test_getmodulefilenamew_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + size_t dll_name_len, dll_name_term; > + DWORD rv, err; > + > + SetLastError(0xdeadbeef); > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + err = GetLastError(); > + ok(err == ERROR_SUCCESS, "error getting path for NULL module: %lu\n", err); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + > + memset(dll_name, '*', sizeof(dll_name)); > + SetLastError(0xdeadbeef); > + rv = GetModuleFileNameW(NULL, dll_name, dll_name_len); You should test the return value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_135279

1 0

Re: [PATCH v54 0/2] MR10291: Fix GetModuleFileName string termination
by Alexandre Julliard (＠julliard) April 7, 2026

April 7, 2026

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/loader.c: > + > + SetLastError(0xdeadbeef); > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + err = GetLastError(); > + ok(err == ERROR_SUCCESS, "error getting path for NULL module: %lu\n", err); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + > + memset(dll_name, '*', sizeof(dll_name)); > + SetLastError(0xdeadbeef); > + rv = GetModuleFileNameW(NULL, dll_name, dll_name_len); > + err = GetLastError(); > + ok(err == ERROR_INSUFFICIENT_BUFFER, "didn't get expected error getting path for NULL module with short buffer: %lu\n", err); > + dll_name_term = wcsnlen(dll_name, MAX_PATH); > + ok(dll_name_term > 0, "can't get path for NULL module with short buffer, dll_name_term=%Iu\n", dll_name_term); > + ok(dll_name_term == dll_name_len - 1, "incorrect path termination for NULL module with short buffer. Expected %Iu got %Iu. rv=%lu\n", dll_name_len - 1, dll_name_term, rv); It doesn't seem useful to test length twice. You should also test that the buffer has not been overflowed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_135278

1 0

[PATCH 0/6] MR10586: winhttp/tests: Fix test failures on old Windows versions.
by Hans Leidekker (＠hans) April 7, 2026

April 7, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10586

2 6