- Wine-GitLab - list.winehq.org

[PATCH v5 0/8] MR10364: dinput: Add support for generating consistent guidInstance values for devices.
by Connor McAdams (＠cmcadams) April 20, 2026

April 20, 2026

This MR adds support for creating `guidInstance` values for joystick devices in a way that matches native behavior. Our current method of creating a `guidInstance` value uses the device's rawinput handle, which changes each time a controller is plugged in. Fixes a bug in Rocket League where a controller plug/unplug cycle results in a new controller being detected each time. The process is like this: - Controller is connected, the game gets its `guidInstance` value from `EnumDevices()`, stores it and associates it with player 1. - Controller is disconnected. - The same controller is reconnected, the game calls `EnumDevices()`, and finds a new `guidInstance` value. - It then assumes this is a new controller, creates a new player, and behaves as though player 1's controller is unplugged. This MR implements `guidInstance` in a way that matches native, and ensures that the `guidInstance` value remains consistent. Doing things this way also makes it easier to add support for `DIPROP_JOYSTICKID` and `GUID_Joystick` in a future MR. I've implemented those in a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/dinput-instance-gu… using this system. -- v5: dinput: Refresh joystick devices when an unknown GUID is used to create a device. dinput: Return E_FAIL when opening a joystick device that is currently disconnected. dinput: Create a version 1 UUID for dinput joystick devices. dinput: Create registry entries for HID joysticks. dinput: Use joystick cache in hid_joystick_create_device(). dinput: Use joystick cache in hid_joystick_enum_device(). dinput: Create a cache of currently connected HID joysticks. dinput: Only pass instance name string to device_instance_is_disabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10364

2 10

Re: [PATCH v2 0/7] MR10688: msxml3: Improvements to setAttribute().
by Nikolay Sivov (＠nsivov) April 20, 2026

April 20, 2026

On Mon Apr 20 11:42:09 2026 +0000, Bernhard Übelacker wrote: > Hello Nikolay, I just wanted to forward a note that some of the recent > msxml3 changes may started causing following ASan findings. > Unfortunately in the past I was carrying the patch from !9279, but > dropped it as it stopped to apply to current git. Therefore I currently > cannot say if that is a new issue or if it is caused by recent patches. > Since [this gitlab > run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/253410#L3065) ASan > gets triggered. > This run was based on top of [1b13526a5f](https://gitlab.winehq.org/wine/wine/-/commits/1b13526a5fcfa55de…. > <details> > <summary>ASan details</summary> > ``` > ==msxml3_test.exe==1616==ERROR: AddressSanitizer: heap-use-after-free on > address 0x101f4050e318 at pc 0x6ffff922e8e9 bp 0x7ffffe1ff820 sp 0x7ffffe1ff868 > READ of size 8 at 0x101f4050e318 thread T0 > #0 0x6ffff922e8e8 in domnode_drop_refs /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1247:15 > #1 0x6ffff922e7d8 in domnode_release /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1385:11 > #2 0x6ffff91eea23 in domdoc_Release /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:449:9 > #3 0x00014007a586 in IXMLDOMDocument_Release /builds/bernhardu/wine/build64/include/msxml.h:1584:12 > #4 0x00014003bf0f in test_put_nodeTypedValue /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:9047:5 > #5 0x00014000114b in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16907:5 > #6 0x0001400eab42 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #7 0x0001400ea54b in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > #8 0x0001400ec7da in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 > #9 0x6fffffc37b94 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027b94) > #10 0x6fffffdc0be6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x170050be6) > 0x101f4050e318 is located 104 bytes inside of 176-byte region [0x101f4050e2b0,0x101f4050e360) > freed by thread T0 here: > #0 0x6ffffe82d861 in free /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:78:3 > #1 0x6ffff922def4 in domnode_destroy_tree /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1378:5 > #2 0x6ffff922e7f8 in domnode_release /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1387:9 > #3 0x6ffff91fcefa in domelem_Release /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:115:9 > #4 0x00014007a7e6 in IXMLDOMElement_Release /builds/bernhardu/wine/build64/include/msxml.h:3969:12 > #5 0x00014003bf06 in test_put_nodeTypedValue /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:9046:5 > #6 0x00014000114b in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16907:5 > #7 0x0001400eab42 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #8 0x0001400ea54b in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > #9 0x0001400ec7da in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 > #10 0x6fffffc37b94 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027b94) > #11 0x6fffffdc0be6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x170050be6) > previously allocated by thread T0 here: > #0 0x6ffffe82da86 in calloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:98:3 > #1 0x6ffff922c969 in domnode_create /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1053:20 > #2 0x6ffff91edd7c in dom_document_create /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:2536:21 > #3 0x6ffff9209586 in DOMClassFactory_CreateInstance /builds/bernhardu/wine/build64/../dlls/msxml3/factory.c:246:9 > #4 0x6ffffcc31b07 in IClassFactory_CreateInstance /builds/bernhardu/wine/build64/include/unknwn.h:248:12 > #5 0x6ffffcc30f29 in CoCreateInstanceEx /builds/bernhardu/wine/build64/../dlls/combase/combase.c:1947:10 > #6 0x6ffffcc30526 in CoCreateInstance /builds/bernhardu/wine/build64/../dlls/combase/combase.c:1736:10 > #7 0x00014007a1d9 in _create_object /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:1207:10 > #8 0x00014003a1f5 in test_put_nodeTypedValue /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:8860:11 > #9 0x00014000114b in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16907:5 > #10 0x0001400eab42 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #11 0x0001400ea54b in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > #12 0x0001400ec7da in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:70:11 > #13 0x6fffffc37b94 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027b94) > #14 0x6fffffdc0be6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x170050be6) > SUMMARY: AddressSanitizer: heap-use-after-free > /builds/bernhardu/wine/build64/../dlls/msxml3/node.c:1247:15 in domnode_drop_refs > ``` > </details> Great, thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688#note_137090

1 0

[PATCH 0/3] MR10690: android: refactoring and cleanup changes (part of !10569)
by Twaik Yont (＠twaik) April 20, 2026

April 20, 2026

This MR contains a subset of changes extracted from MR !10569. Included changes: 1. Simplify client PID handling in Android driver * Pass PID explicitly via `ioctl_android_dequeueBuffer` instead of thread-local `driver_data` * Remove `ioctl_params` wrapper and pass IRP directly * Remove implicit `client_id` propagation through ioctl dispatch and Java calls * Restrict PID usage to `dequeueBuffer` where it is actually required 2. Simplify Android initialization and AHardwareBuffer handling * Load AHardwareBuffer symbols together with other Android APIs in `load_android_libs()` * Remove separate `init_ahardwarebuffers()` path * Treat libandroid and AHardwareBuffer as part of standard platform API 3. Switch `java_*` variables to direct linking * Replace dlsym-based resolution with direct references (`java_vm`, `java_object`, `java_gdt_sel`) * Remove indirect pointer layer and simplify initialization logic Reason: This MR is split out from !10569 to simplify review by isolating refactoring and cleanup changes from functional fixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10690

2 4

[PATCH v3 0/2] MR10696: shcore: 0 terminate params->WindowTitle when turning into WCHAR
by Marcus Meissner (＠msmeissn) April 20, 2026

April 20, 2026

WindowTitle is not necessarily NUL terminated. Reported-By: Dirk Mueller <dmueller(a)suse.de> Found-by: Gemini 3.1 Pro Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- v3: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/10696

2 2

[PATCH 0/1] MR10699: Revert "win32u: Don't forcefully activate windows before restoring them."
by Zhiyi Zhang (＠zhiyi) April 20, 2026

April 20, 2026

This reverts commit f82b115dfcf3eefbbb533d31976d178e21bf1237. f82b115d was intended to fix SDL3 applications unexpectedly switching to the native display mode. However, after further investigations, the bug is caused by other issues rather than the NtUserSetActiveWindow() call. In fact, by tracing the message sequence when restoring a window, there should be a WM_ACTIVATE message before WM_SYSCOMMAND SC_RESTORE. Fix Warhammer: Vermintide 2 (552500) failing to enter fullscreen mode after focus loss. The game needs a WM_ACTIVATE message before WM_SYSCOMMAND SC_RESTORE. The SDL3 application unexpectedly switches to the native display mode bug is caused by the following: **(1) The 16-bit display mode format gets overwritten** Please see https://gitlab.winehq.org/wine/wine/-/merge_requests/10697 for details. **(2) Window managers restore minimized windows with the current display mode** For example, an SDL3 game on a 1920x1080 monitor uses 1024x768 display mode. When the game gets minimized, say by Alt+Tab, it will set the display mode back to 1920x1080. When the game window gets restored, the window manager will resize the window to 1920x1080 because the window still has __NET_WM_STATE_FULLSCREEN set even though it's minimized. So a WM_WINDOWPOSCHANGE (1920x1080) is sent to the game window. The game processes the WM_WINDOWPOSCHANGE and changes to the previous 1024x768 display mode. So a WM_WINDOWPOSCHANGE (1024x768) will be sent later once the WM finishes processing the display change event. However, there might be a delay between the WM_WINDOWPOSCHANGE (1920x1080) and WM_WINDOWPOSCHANGE (1024x768). So if the game finishes WM_WINDOWPOSCHANGE (1920x1080) and it can't find more messages, then it will trigger a render update and use the current window size (1920x1080) to adjust the display mode, causing it to revert to the native display mode instead of the specified one. See SDL3 testwm.c main message loop for example. The root cause is the difference in the behavior of WM on Linux and Windows. Windows still uses the old window size when restoring a window, even though the display mode is changed. The presence of `__NET_WM_STATE_FULLSCREEN` on Linux makes the WM choose the current display size instead of the previous window size. I tried removing `__NET_WM_STATE_FULLSCREEN` for a window when it gets minimized. But it will trigger unexpected size changes because removing `__NET_WM_STATE_FULLSCREEN` causes WMs to restore the window to its previous size before fullscreen. Unfortunately, I haven't thought of a reliable way to fix this. Anyway, it did prove that it's not related to the NtUserSetActiveWindow() call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10699

3 2

[PATCH v3 0/5] MR10689: winex11: Keyboard layouts rework, part 1
by Rémi Bernon (＠rbernon) April 20, 2026

April 20, 2026

Same as https://gitlab.winehq.org/wine/wine/-/merge_requests/10550 with misc tweaks. -- v3: winex11: Decode current keyboard layout from the Xkb group name. https://gitlab.winehq.org/wine/wine/-/merge_requests/10689

4 15

[PATCH v6 0/5] MR10550: winex11: Keyboard layouts rework, part 1
by Matteo Bruni (＠Mystral) April 20, 2026

April 20, 2026

The idea is to improve the detection of the available keyboard layouts, normally via Xkb group names + xkbregistry, and then propagate the current layout to win32u and the PE / win32 side state. Along the way also start using `KBDTABLES` and the related newer win32u machinery that was introduced for winewayland. I'm taking a lot of inspiration (and also actual patches, or pieces of code) from the winewayland driver and Rémi's draft MR !2122. The main difference from that attempt is that I'm going to keep around `X11DRV_KEYBOARD_DetectLayout()` and use it as a fallback detection mechanism (e.g. for vncserver), but still move winex11 to `KBDTABLES` and such. You can find the current (still WIP, especially for later patches) branch at https://gitlab.winehq.org/Mystral/wine/-/commits/hl-kbl?ref_type=heads -- v6: winex11: Decode current keyboard layout from the Xkb group name. https://gitlab.winehq.org/wine/wine/-/merge_requests/10550

4 9

[PATCH 0/3] MR10703: opengl32: Misc client-side handle table fixes.
by Rémi Bernon (＠rbernon) April 20, 2026

April 20, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10703

2 3

[PATCH v2 0/1] MR10556: odbc32: Report SQL_TIMESTAMP format for timestamp data in ODBC 2.x application.
by Piotr Caban (＠piotr) April 20, 2026

April 20, 2026

-- v2: odbc32: Support data type conversion on version mismatch. https://gitlab.winehq.org/wine/wine/-/merge_requests/10556

3 3

[PATCH 0/1] MR10439: crypt32: Protect certificate context from repeated releases.
by Dmitry Timoshkov (＠dmitry) April 20, 2026

April 20, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10439

3 14