- Wine-GitLab - list.winehq.org

[PATCH v3 0/2] MR10980: vbscript: Propagate errors from a script-invoked function reference.
by Francis De Brabandere (＠francisdb) May 26, 2026

May 26, 2026

FuncRef_Invoke always ran the referenced function as an external caller, so an error raised through a GetRef reference was reported to the host via IActiveScriptSite::OnScriptError even when the reference was called from within running script. A direct call propagates the error as an HRESULT to the caller's On Error Resume Next instead. Treat the reference as an external caller only when the engine is not already executing script. -- v3: vbscript: Run a script-invoked function reference as an internal call. vbscript/tests: Add tests for error reporting from a GetRef reference. https://gitlab.winehq.org/wine/wine/-/merge_requests/10980

2 4

[PATCH 0/5] MR10999: win32u: Move private control info to the shared memory.
by Rémi Bernon (＠rbernon) May 26, 2026

May 26, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10999

2 6

[PATCH 0/3] MR10998: gdi32/uniscribe: Reworking mark_invalid_combinations()
by समीरसिंह Sameer Singh (＠ss141309) May 26, 2026

May 26, 2026

Hi, while solving #59680 I noticed some discrepancies in the behaviour of mark_invalid_combinations in wine and in windows. In wine, combinations are only marked invalid when two adjacent characters shared the same context type, so for example a single arabic fatha `َ` will not be displayed with a dotted_circle under wine. This is not the case for windows. Thus in the game Path of Exile, the combination of latin+thai_mark, the single thai_mark is invisible, because the itemizer separates the latin and thai in two different runs, the thai mark is an isolated character with no base to be attached to, the game expects that this mark will appear with a base character. This can also be seen with this program: ```c #include <windows.h> #include <usp10.h> #include <stdio.h> #define MAKE_OPENTYPE_TAG(a,b,c,d) ((OPENTYPE_TAG)(a) | ((OPENTYPE_TAG)(b) << 8) | ((OPENTYPE_TAG)(c) << 16) | ((OPENTYPE_TAG)(d) << 24)) int dump_unicode_for_glyph(HDC hdc, WORD target_gid) { for (DWORD i = 0x0020; i <= 0xFFFF; i++) { WCHAR ch = (WCHAR)i; WORD gid = 0xFFFF; if (GetGlyphIndicesW(hdc, &ch, 1, &gid, GGI_MARK_NONEXISTING_GLYPHS) != GDI_ERROR) { if (gid == target_gid) return i; } } } void dump_shape_results(HDC hdc, const WCHAR *pwcChars, int cChars, const WORD *pwOutGlyphs, int cGlyphs, const WORD *pwLogClust, const SCRIPT_CHARPROP *pCharProps, const SCRIPT_GLYPHPROP *pGlyphProps) { printf("cChars=%d cGlyphs=%d\n\n", cChars, cGlyphs); printf("Input characters:\n"); for (int i = 0; i < cChars; i++) printf(" pwcChars[%d] = U+%04X LogClust=%d\n", i, pwcChars[i], pwLogClust[i]); printf("\nOutput glyphs:\n"); for (int i = 0; i < cGlyphs; i++) { printf(" glyph[%d] = %d (U+%04X) fDiacritic=%d fZeroWidth=%d\n", i, pwOutGlyphs[i], dump_unicode_for_glyph(hdc, pwOutGlyphs[i]), pGlyphProps[i].sva.fDiacritic, pGlyphProps[i].sva.fZeroWidth); } printf("\n\n"); } void test_shape(HDC hdc, const WCHAR *pwcChars, OPENTYPE_TAG tagScript) { SCRIPT_ITEM items[2]; int num_items = 0; ScriptItemize(pwcChars, 1, 2, NULL, NULL, items, &num_items); SCRIPT_CACHE sc = NULL; SCRIPT_ANALYSIS sa = items[0].a; WORD glyphs[8], log_clust[8]; SCRIPT_CHARPROP char_props[8]; SCRIPT_GLYPHPROP glyph_props[8]; int glyph_count = 0; ScriptShapeOpenType(hdc, &sc, &sa, tagScript, 0, NULL, NULL, 0, pwcChars, 1, 8, log_clust, char_props, glyphs, glyph_props, &glyph_count); dump_shape_results(hdc, pwcChars, 1, glyphs, glyph_count, log_clust, char_props, glyph_props); ScriptFreeCache(&sc); } int main(void) { WCHAR arabic_lone_mark[1] = { 0x064E }; OPENTYPE_TAG arabic_tag = MAKE_OPENTYPE_TAG('a', 'r', 'a', 'b'); HDC hdc = CreateCompatibleDC(NULL); HFONT arabic_font = CreateFontW(32, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH, L"Noto Naskh Arabic"); HFONT old_font = SelectObject(hdc, arabic_font); printf("Shaping Arabic\n"); test_shape(hdc, arabic_lone_mark, arabic_tag); WCHAR thai_lone_mark[1] = { 0x0E4E }; OPENTYPE_TAG thai_tag = MAKE_OPENTYPE_TAG('t', 'h', 'a', 'i'); HFONT thai_font = CreateFontW(32, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH, L"Kanit"); old_font = SelectObject(hdc, thai_font); printf("Shaping Thai\n"); test_shape(hdc, thai_lone_mark, thai_tag); DeleteObject(arabic_font); DeleteObject(thai_font); DeleteDC(hdc); return 0; } ``` When run under windows, the output is: ``` PS C:\Users\ss141309\Desktop\Shared> .\up32.exe Shaping Arabic cChars=1 cGlyphs=2 Input characters: pwcChars[0] = U+064E LogClust=1 Output glyphs: glyph[0] = 379 (U+064E) fDiacritic=1 fZeroWidth=1 glyph[1] = 235 (U+25CC) fDiacritic=0 fZeroWidth=0 Shaping Thai cChars=1 cGlyphs=2 Input characters: pwcChars[0] = U+0E4E LogClust=0 Output glyphs: glyph[0] = 593 (U+0020) fDiacritic=0 fZeroWidth=1 glyph[1] = 737 (U+0E4E) fDiacritic=1 fZeroWidth=1 ``` Even the microsoft documentation, does not mention that combining marks are only invalid when they are succeeded by the same class of mark. [See:](https://learn.microsoft.com/en-us/typography/script-development/arabi… > ## Handling Invalid Combining Marks > > Combining marks and signs that appear in text not in conjunction with a valid consonant base are considered _invalid._ Uniscribe displays these marks using the fallback rendering mechanism defined in the Unicode Standard (section 5.12, 'Rendering Non-Spacing Marks' of the Unicode Standard 3.1), i.e. positioned on a dotted circle. > > Please note that to render a sign standalone (in apparent isolation from any base) one should apply it on a space (see section 2.5 'Combining Marks' of Unicode Standard 3.1). Uniscribe requires a ZWJ to be placed between the space and a mark for them to combine into a standalone sign. > > For the fallback mechanism to work properly, an Arabic OTL font should contain a glyph for the dotted circle (U+25CC). In case this glyph is missing form the font, the invalid signs will be displayed on the missing glyph shape (white box). > > In addition to the 'dotted circle,' other Unicode code points that are recommended for inclusion in any Arabic font are: ZWNJ (zero width non-joiner; U+200C), ZWJ (zero width joiner U+200D), LTR (left to right mark; U+200E), and RTL (right to left mark; U+200F). The ZWNJ can be used between two letters to prevent them from forming a cursive connection. > > ![Illustration that shows suggested glyphs for the five Unicode code points.](https://learn.microsoft.com/en-us/typography/script-development/im… > > If an invalid combination is found, like two fathas on the same base character, the diacritic that causes the invalid state is placed on a dotted circle to indicate to the user the invalid combination. The shaping engine for non-OpenType fonts will cause invalid mark combinations to overstrike. This is the problem that inserting the dotted circle for the invalid base solves. It should also be noted that the dotted circle is not inserted into the application's backing store. This is a run-time insertion into the glyph array that is returned from the **ScriptShape** function. > > The invalid diacritic logic for Arabic is based on the classes listed below. There is a check to make sure more than one mark of a class is not placed on the same base. Additionally, DIAC1 and DIAC2 classes should not be applied on the same base character. So was there a historical reason for this behaviour? If I get a go ahead with this approach, I will fix the tests next. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10998

2 3

[PATCH 0/4] MR10995: combase: Implement IContextCallback::ContextCallback.
by Piotr Caban (＠piotr) May 26, 2026

May 26, 2026

IRundown definition is based on https://www.mdsec.co.uk/2022/04/process-injection-via-component-object-mode… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10995

3 5

[PATCH v6 0/3] MR10874: wined3d: Disallow locking of multisampled back buffers.
by Conor McCarthy (＠cmccarthy) May 26, 2026

May 26, 2026

-- v6: wined3d: Disallow locking of multisampled back buffers. d3d9/tests: Test multisampled back buffer locking. d3d8/tests: Test multisampled back buffer locking. https://gitlab.winehq.org/wine/wine/-/merge_requests/10874

3 5

[PATCH v2 0/2] MR10993: crypt32: handle CERT_NCRYPT_KEY_HANDLE_PROP_ID setting as implemented (not documented)
by Trent Waddington (＠trent.waddington) May 26, 2026

May 26, 2026

The [documentation for CertSetCertificateContextProperty](https://learn.microsoft.com/en-us/window… says pvData should contain a pointer to an NCRYPT_KEY_HANDLE, however the actual implementation of this function expects just the handle. This is easily shown by passing a "dead beef" value in pvData, it will not be dereferenced on Windows and the value retrieved later will be the same as provided. Yes, this means there are consumers of this function out there passing a stack pointer which is dutifully stored away. It's only when that value is used that anything goes wrong. -- v2: crypt32: make CertContext_SetProperty of CERT_NCRYPT_KEY_HANDLE_PROP_ID behave as implemented, not as documented. Add tests to demonstrate undocumented behavior of crypt32 CERT_NCRYPT_KEY_HANDLE_PROP_ID setting https://gitlab.winehq.org/wine/wine/-/merge_requests/10993

3 3

[PATCH v3 0/2] MR10960: scrrun/dictionary: Match Empty keys against zero-valued and empty-string keys.
by Francis De Brabandere (＠francisdb) May 26, 2026

May 26, 2026

An uninitialized VBScript variable is Empty, so scripts can end up using Empty as a dictionary key alongside a numeric 0 or "". Native treats those as the same key; Wine kept Empty distinct from every other type. Match an Empty key against any numeric zero or the empty string, while keeping it distinct from Null and from non-zero/non-empty keys. -- v3: scrrun/dictionary: Match Empty keys against zero-valued and empty-string keys. scrrun/tests: Add tests for Empty dictionary keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/10960

2 2

[PATCH 0/2] MR10993: crypt32: handle CERT_NCRYPT_KEY_HANDLE_PROP_ID setting as implemented (not documented)
by Trent Waddington (＠trent.waddington) May 26, 2026

May 26, 2026

The [documentation for CertSetCertificateContextProperty](https://learn.microsoft.com/en-us/window… says pvData should contain a pointer to an NCRYPT_KEY_HANDLE, however the actual implementation of this function expects just the handle. This is easily shown by passing a "dead beef" value in pvData, it will not be dereferenced on Windows and the value retrieved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10993

2 3

[PATCH v10 0/2] MR10906: sapi: Implement ISpVoice::SetPriority and GetPriority.
by Bohdan Tkachenko (＠BohdanTkachenko) May 26, 2026

May 26, 2026

sapi: Implement ISpVoice::SetPriority and GetPriority. Previously both methods returned E_NOTIMPL. Store the priority on the speech_voice struct and validate the value against SPVPRI_NORMAL,\ SPVPRI_ALERT and SPVPRI_OVER. This unblocks Overwatch 2's Audio Captions accessibility TTS, which calls\ SetPriority during voice setup and aborts on any non-S_OK result. Add tests covering priority round-trips between SPVPRI_NORMAL, SPVPRI_ALERT and SPVPRI_OVER, and verify the default is SPVPRI_NORMAL. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59749 -- v10: https://gitlab.winehq.org/wine/wine/-/merge_requests/10906

2 3

[PATCH 0/1] MR10986: sapi: Implement ISpVoice::GetStatus.
by Bohdan Tkachenko (＠BohdanTkachenko) May 26, 2026

May 26, 2026

Previously this method returned E_NOTIMPL. Populate SPVOICESTATUS from speech_voice state: - ulCurrentStream tracks the stream currently being processed by speak_proc (set at the start of the worker so it reflects the in-flight stream, and sticks at the last processed value when idle, per MSDN). Stored as last_stream_num on speech_voice. - ulLastStreamQueued reuses the existing cur_stream_num counter, which is incremented before each Speak queues a task. - hrLastResult is the HRESULT of the most recently completed speak (set at the end of speak_proc). - dwRunningState is derived from async_wait_queue_empty(&queue, 0) so it correctly reports SPRS_DONE both when idle and after a purge clears queued tasks. This unblocks Overwatch 2's Audio Captions accessibility TTS, which tight-polls GetStatus for SPRS_DONE between Speak calls; the previous E_NOTIMPL stub left the status struct untouched, leaving the game wedged forever waiting for SPRS_DONE. Add tests covering GetStatus with a NULL pointer and status fields before, during and after sync and async Speak calls. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59749 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10986

2 2