- Wine-GitLab - list.winehq.org

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Vishnunithyasoundhar S (＠svishnunithyasoundhar) April 3, 2026

April 3, 2026

On Fri Apr 3 19:15:22 2026 +0000, Akihiro Sagawa wrote: > Thanks for the update -- the changes look much better overall. There are > still a few areas that need some refinement, though. > Since this will start handling extended-length path prefix in > GetLongPathNameW function, you may also need to pay attention to the > length of `tmplongpath`. Understood. I will look into them thanks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134969

1 0

[PATCH v2 0/1] MR10483: vbscript: Return "Illegal assignment" error for Const and function assignment.
by Francis De Brabandere (＠francisdb) April 3, 2026

April 3, 2026

Assigning to a Const variable or a function/sub name should return error 501 (Illegal assignment), not 445 (Object doesn't support this action). Change the REF_CONST and REF_FUNC cases in assign_ident() to use MAKE_VBSERROR(VBSE_ILLEGAL_ASSIGNMENT). -- v2: vbscript: Return "Illegal assignment" error for Const and function assignment. https://gitlab.winehq.org/wine/wine/-/merge_requests/10483

3 2

[PATCH v2 0/1] MR10486: vbscript: Fix error character positions for Exit and Dim statements.
by Francis De Brabandere (＠francisdb) April 3, 2026

April 3, 2026

For invalid Exit statements (e.g. Exit Do outside a Do loop), point the error position at the keyword after Exit (Do/For/Function/Property/Sub) instead of at Exit itself, matching Windows. For duplicate Dim declarations, store the identifier location in dim_decl_t and use it as the error position, so the error points at the duplicate name instead of the Dim keyword. -- v2: vbscript: Fix error character positions for Exit and Dim statements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10486

3 2

[PATCH v3 0/1] MR10544: vbscript: Use ASCII-only case-insensitive compare for identifier lookups.
by Francis De Brabandere (＠francisdb) April 3, 2026

April 3, 2026

VBScript identifiers are ASCII-only, Windows rejects all non-ASCII characters (Latin-1, Cyrillic, CJK) at the lexer level with error 1032 "Invalid character". Replace the locale-aware `wcsicmp()` with an inline ASCII-only `vbs_wcsicmp()` for all identifier comparisons. This avoids the expensive locale grab/free cycle (`get_current_locale_noalloc`/`free_locinfo`) that dominated profiling at 87–95% of CPU time in identifier lookup paths. Also restrict the lexer's `is_identifier_char()` and identifier-start check to ASCII-only, matching Windows behavior. Tests added for non-ASCII character rejection (é, ß, ü, Cyrillic) in identifiers. ### Benchmark results (best-of-3, before → after) | Benchmark | Before | After | Change | |---|---:|---:|---:| | Class prop read ×500k | 2558 ms | 160 ms | **−93.7%** | | GetRef loop ×200k | 15988 ms | 296 ms | **−98.1%** | | Empty For 10M | 4808 ms | 242 ms | **−95.0%** | | Nested For 10M | 6367 ms | 253 ms | **−96.0%** | | Local vars 10M | 9437 ms | 390 ms | **−95.9%** | | Dict.Exists ×100k | 300 ms | 113 ms | **−62.3%** | | If boolvar 10M | 7882 ms | 988 ms | **−87.5%** | | String concat ×2000 | 78 ms | 70 ms | −10.3% | Identifier-heavy operations see **10–50× speedups**. String concat (I/O-bound, not lookup-bound) is unchanged as expected. -- v3: vbscript: Use ASCII-only case-insensitive compare for identifier lookups. https://gitlab.winehq.org/wine/wine/-/merge_requests/10544

3 4

[PATCH 0/1] MR10554: gdiplus: Initial implementation of GdipWarpPath
by Bartosz Kosiorek (＠gang65) April 3, 2026

April 3, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10554

2 2

[PATCH 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Nikolai Abdusamatov (＠n-abdusamatov) April 3, 2026

April 3, 2026

### What this changes - Adds a MAC validity predicate for adapter entries. - In GetAdaptersInfo, counts adapters with valid physical MAC. - If valid adapters exist, excludes entries with invalid MAC from returned list. ### Why On macOS, pseudo interfaces without usable physical address can appear before real hardware adapters. Legacy clients that pick the first adapter may send empty MAC and fail auth. ### Scope - Module: iphlpapi - API path: GetAdaptersInfo - Platform impact: mainly macOS-like interface layouts with pseudo/tunnel adapters exposed early. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59614 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553

3 2

[PATCH v9 0/1] MR10464: Draft: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) April 3, 2026

April 3, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function, duplicate class members), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store source locations in const_decl_t, dim_decl_t, function_decl_t, and class_decl_t so errors point to the duplicate name. Also fix duplicate Sub/Function/Property/Dim detection inside classes, including the case where a Property collides with an existing Sub/Function. -- v9: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH v8 0/1] MR10464: Draft: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) April 3, 2026

April 3, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function, duplicate class members), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store source locations in const_decl_t, dim_decl_t, function_decl_t, and class_decl_t so errors point to the duplicate name. Also fix duplicate Sub/Function/Property/Dim detection inside classes, including the case where a Property collides with an existing Sub/Function. -- v8: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH 0/1] MR10552: bcrypt: Handle SHA512 in key_asymmetric_verify().
by Hans Leidekker (＠hans) April 3, 2026

April 3, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10552

2 1

[PATCH v4 0/1] MR10551: Draft: Check Font Height without Graphics
by Bartosz Kosiorek (＠gang65) April 3, 2026

April 3, 2026

-- v4: gdiplus/tests: Check Font Height without GpGraphics https://gitlab.winehq.org/wine/wine/-/merge_requests/10551

2 2