- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10979: winebth.sys: Return the correct boolean value in bluez_gatt_characteristic_props_from_dict_entry.
by Vibhav Pant (＠vibhavp) May 22, 2026

May 22, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10979

2 1

[PATCH v2 0/1] MR10949: winex11.drv: Return WithdrawnState when get_window_wm_state() fails.
by Zhiyi Zhang (＠zhiyi) May 22, 2026

May 22, 2026

KWin deletes WM_STATE property from a window when entering WithdrawnState. Please see X11Window::exportMappingState() in the KWin source code. So when get_window_wm_state() fails, -1 is returned before this patch. Since -1 is not a valid WM_STATE, it might cause Wine to expect an invalid value. We also can't simply ignore the invalid -1 because we might be expecting the WM_STATE property notify event to change to the desired state. Treating missing WM_STATE property as WithdrawnState seems like the best way to go. Help fix RiME(493200) sometimes fails to restore from Alt+Tab. -- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/10949

3 3

Re: [PATCH v2 0/1] MR10976: server: Do not drop the fd reference for mapping views on removable devices.
by Alexandre Julliard (＠julliard) May 22, 2026

May 22, 2026

On Fri May 22 14:01:42 2026 +0000, Hieu Le Minh wrote: > Per my testing, it will only do so when programs are running or files > are being accessed, which matches Windows behavior. Are there any other > cases where this could be an issue? For old installers that come on multiple disks, it's necessary to unmount/remount the device while files are open, that's why we have all that complexity about removable devices. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10976#note_141055

1 0

Re: [PATCH v2 0/1] MR10976: server: Do not drop the fd reference for mapping views on removable devices.
by Hieu Le Minh (＠hieu1m) May 22, 2026

May 22, 2026

On Fri May 22 14:01:42 2026 +0000, Alexandre Julliard wrote: > This will prevent unmounting removable devices. Per my testing, it will only do so when programs are running or files are being accessed, which matches Windows behavior. Are there any other cases where this could be an issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10976#note_141054

1 0

Re: [PATCH v2 0/2] MR10961: scrrun/dictionary: Rename keys in place in put_Key.
by Francis De Brabandere (＠francisdb) May 22, 2026

May 22, 2026

On Fri May 22 09:31:22 2026 +0000, Nikolay Sivov wrote: > This pretty much duplicates existing logic, it's not a lot but could you > try to share some of this with add_keyitem_pair()? extracted to link_keyitem_to_bucket -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10961#note_141044

1 0

Re: [PATCH v2 0/2] MR10961: scrrun/dictionary: Rename keys in place in put_Key.
by Francis De Brabandere (＠francisdb) May 22, 2026

May 22, 2026

On Fri May 22 09:30:36 2026 +0000, Nikolay Sivov wrote: > We don't need to call same lookup twice. cleaned up -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10961#note_141043

1 0

[PATCH 0/2] MR10978: scrrun/dictionary: Report key-hashing failures from lookups.
by Francis De Brabandere (＠francisdb) May 22, 2026

May 22, 2026

An object key that can no longer be hashed is reported as absent by Exists and not-found by Remove, instead of surfacing the hashing error like native — verified across all six key-taking methods. Method Native Wine pre-fix Wine post-fix ----------- ------------ ------------------------------- ------------ Add 0x800a0005 0x800a0005 (ok) 0x800a0005 Item read 0x800a0005 0x800a0005 (ok) 0x800a0005 Item write 0x800a0005 0x800a0005 (ok) 0x800a0005 Key rename 0x800a0005 S_OK, created bogus key (DIFF) 0x800a0005 Exists 0x800a0005 S_OK / False (DIFF) 0x800a0005 Remove 0x800a0005 0x800a802b (not-found) (DIFF) 0x800a0005 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10978

3 4

[PATCH v4 0/2] MR10950: shell32: Add an Info icon.
by Stefan Dösinger (＠stefan) May 22, 2026

May 22, 2026

Hi Alex, I ran into an application that needed SIID_INFO. I noticed you added a lot of icons to shell32, so maybe you can help me with two issues: 1) On my WinXP and Win11, the (i) Icon has index 221, not 215. The power off icon however has index 215. Can you double check if you used the correct value for IDI_SHELL_POWER_OFF back in 9954c08dc8dc? 2) It seems the other shell icon SVGs have a rasterized image embedded, which tools/buildimage needs. For this .svg it writes "no render directive found in dlls/shell32/resources/info.svg". How did you generate those for the icons you added? Other Wikimedia Commons Tango icons don't seem to have them, so I guess they were added by one of us. -- v4: shell32: Use IDI_SHELL_INFO icon for SIID_INFO. shell32: Add an Info icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/10950

2 2

[PATCH v6 0/1] MR10929: gdi32: Validate count parameter in ExtCreateRegion
by Bartosz Kosiorek (＠gang65) May 22, 2026

May 22, 2026

-- v6: gdi32: Validate count parameter in ExtCreateRegion https://gitlab.winehq.org/wine/wine/-/merge_requests/10929

3 5

[PATCH 0/1] MR10969: wkscli: Add new dll
by Alistair Leslie-Hughes (＠alesliehughes) May 22, 2026

May 22, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10969

3 2