- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10525: server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read.
by Paul Gofman (＠gofman) March 31, 2026

March 31, 2026

-- v2: server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read. https://gitlab.winehq.org/wine/wine/-/merge_requests/10525

2 2

[PATCH v8 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Report user-visible "Input Error" messages to stdout matching Windows behavior for missing script files and nonexistent files. Display usage information with Wine version when invoked with no arguments. Script runtime errors (OnScriptError) remain on stderr. Implement //nologo and //logo flags to control the banner displayed before script execution. Treat unrecognized options as filenames to support Unix-style paths on Wine. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- v8: wscript: Implement error messages, usage output, and //nologo banner. https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 2

Re: [PATCH v9 0/2] MR10460: msvcrt: Add support for %Z printf specifier.
by Elizabeth Figura (＠zfigura) March 31, 2026

March 31, 2026

On Tue Mar 31 17:52:11 2026 +0000, Piotr Caban wrote: > This is not portable, please define ANSI_STRING/UNICODE_STRING > structures separately and use pointers to them here. > Please also add %Z format test in swprintf test (to show that it uses ANSI_STRING). > Please also check the function behavior with ucrtbase - current > implementation will fail there. Its behavior probably changes based on > \_CRT_INTERNAL_PRINTF_LEGACY_WIDE_SPECIFIERS or > \_CRT_INTERNAL_PRINTF_LEGACY_MSVCRT_COMPATIBILITY flag. Please also add > tests to ucrtbase. I believe we have some of those structures elsewhere already. Is there a known compiler that doesn't support them? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10460#note_134561

1 0

[PATCH v7 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Report user-visible "Input Error" messages to stdout matching Windows behavior for missing script files and nonexistent files. Display usage information with Wine version when invoked with no arguments. Script runtime errors (OnScriptError) remain on stderr. Implement //nologo and //logo flags to control the banner displayed before script execution. Treat unrecognized options as filenames to support Unix-style paths on Wine. Add FIXME stubs for other recognized but unimplemented options (//X, //S, //E:, //H:, //Job:, //T:). -- v7: wscript: Implement error messages, usage output, and //nologo banner. https://gitlab.winehq.org/wine/wine/-/merge_requests/10518

2 2

[PATCH 0/1] MR10525: server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read.
by Paul Gofman (＠gofman) March 31, 2026

March 31, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10525

2 2

[PATCH v17 0/1] MR10368: vbscript: Implement Eval, Execute, and ExecuteGlobal.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Eval compiles the string as an expression and returns the result. ExecuteGlobal compiles and executes the string at global scope. Execute compiles and executes the string in the calling scope. When called from within a Sub or Function, Eval and Execute use the calling scope for variable resolution, accessing local variables and arguments. When called from global scope, they fall back to exec_global_code. ExecuteGlobal always executes in global scope. The calling scope is passed through script_ctx_t.caller_exec, which exec_script picks up and stores on exec_ctx_t.caller. The interpreter's lookup_identifier checks the caller's locals, arguments, and dynamic vars when running FUNC_GLOBAL code with a caller context set. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49908 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53962 -- v17: vbscript: Implement Eval, Execute, and ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10368

3 3

[PATCH v8 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v8: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

Re: [PATCH v9 0/2] MR10460: msvcrt: Add support for %Z printf specifier.
by Piotr Caban (＠piotr) March 31, 2026

March 31, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/printf.h: > { > int r, ret; > > + /* UNICODE_STRING passes the number of bytes. */ > + if(len > 0 && flags->Format == 'Z') > + len /= sizeof(wchar_t); I think the code is easier to follow if pf_output_format_wstr always takes length in characters. Please change the caller instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10460#note_134549

1 0

Re: [PATCH v9 0/2] MR10460: msvcrt: Add support for %Z printf specifier.
by Piotr Caban (＠piotr) March 31, 2026

March 31, 2026

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/printf.c: > { "% d", " 1", 0, INT_ARG, 1 }, > { "%+ d", "+1", 0, INT_ARG, 1 }, > { "%S", "wide", 0, PTR_ARG, 0, 0, 0, L"wide" }, > + { "%Z", "ansi", 0, PTR_ARG, 0, 0, 0, &(ANSI_STRING){ 4, 4, (char *)"ansi" } }, This is not portable, please define ANSI_STRING/UNICODE_STRING structures separately and use pointers to them here. Please also add %Z format test in swprintf test (to show that it uses ANSI_STRING). Please also check the function behavior with ucrtbase - current implementation will fail there. Its behavior probably changes based on \_CRT_INTERNAL_PRINTF_LEGACY_WIDE_SPECIFIERS or \_CRT_INTERNAL_PRINTF_LEGACY_MSVCRT_COMPATIBILITY flag. Please also add tests to ucrtbase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10460#note_134548

1 0

[PATCH v3 0/1] MR10521: Certsetcertificatecontextproperty cert ncrypt key handle prop id
by Benoît Legat (＠blegat) March 31, 2026

March 31, 2026

This is part of my attempt to run the [Niko Home Control programming software](https://appdb.winehq.org/objectManager.php?sClass=application&iId… under Wine. This (.NET 8 / Electron app) is performing mTLS with a [Connected controller voor Niko Home Control II](https://products.niko.eu/nl-be/article/550-00003). Doing this, it calls `CertSetCertificateContextProperty` with `CERT_NCRYPT_KEY_HANDLE_PROP_ID`. Wine currently does not implement setting this property so it falls through to the default case, with the \``FIXME("%ld: stub\n", dwPropId);` that lead me to try to implement it. This patch seems to work for the Niko Home Control app so I added test to contribute it upstream. According to [the documentation](https://learn.microsoft.com/en-us/windows/win32/api/wincrypt…, `dwKeySpec` should be set to `CERT_NCRYPT_KEY_SPEC`. This value didn't seem to be defined yet in Wine so I added its definition. [Its value seems to be \`0xffffffff\`](https://android.googlesource.com/toolchain/mingw/+/refs/heads/main/mingw-w64-v6.x/mingw-w64-headers/include/wincrypt.h#3434). I added tests. Before the changes in `dlls/crypt32/cert.c`, running the tests with `wine 11.5-1` (current version on ArchLinux) the tests give 7 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:553: Test failed: CertSetCertificateContextProperty failed: 80092004 cert.c:559: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:560: Test failed: Expected hCryptProv 0xBEEF1234, got 0 cert.c:562: Test failed: Expected dwKeySpec CERT_NCRYPT_KEY_SPEC, got 2 cert.c:569: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:570: Test failed: Expected handle 0xBEEF1234, got 0 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:587: Test failed: CertSetCertificateContextProperty failed: 80092004 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE871940, 00007FFFFE8530D8, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 7 failures), 0 skipped. ``` After applying my patches like so ``` sudo cp dlls/crypt32/x86_64-windows/crypt32.dll /usr/lib/wine/x86_64-windows/crypt32.dll sudo cp dlls/crypt32/crypt32.so /usr/lib/wine/x86_64-unix/crypt32.so ``` I get 0 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE872F70, 00007FFFFE854988, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 0 failures), 0 skipped. ``` Let me know if there is anything else I can do to help, this is my first contribution to this project. -- v3: crypt32: Implement CERT_NCRYPT_KEY_HANDLE_PROP_ID support https://gitlab.winehq.org/wine/wine/-/merge_requests/10521

3 3