- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10805: Draft: msvcrt: only convert _tolower_l if not exact match already
by Stephan Seitz (＠theHamsta) May 2, 2026

May 2, 2026

This optimizations brought some speed-ups in https://gitlab.winehq.org/wine/wine/-/merge_requests/10804 for the equivalent `memicmp_strW` function as it avoids converting and locale lookup for exact matches. -- v2: msvcrt: only convert _tolower_l if not exact match already https://gitlab.winehq.org/wine/wine/-/merge_requests/10805

2 1

[PATCH 0/1] MR10805: Draft: msvcrt: only convert _tolower_l if not exact match already
by Stephan Seitz (＠theHamsta) May 2, 2026

May 2, 2026

This optimizations brought some speed-ups in https://gitlab.winehq.org/wine/wine/-/merge_requests/10804 for the equivalent `memicmp_strW` function as it avoids converting and locale lookup for exact matches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10805

1 0

[PATCH 0/1] MR10792: winepulse.drv: Don't advance read pointer past data not yet consumed by PA
by Dzmitry Keremsha (＠Vyrolian) May 2, 2026

May 2, 2026

Adds a simple throttling mechanism to prevent pointer overlaps when winepulse is faster than the audio server. Winepulse uses a fake clock to advance the pointers: ```c /* regardless of what PA does, advance one period */ adv_bytes = min(stream->period_bytes, stream->held_bytes); stream->lcl_offs_bytes += adv_bytes; stream->lcl_offs_bytes %= stream->real_bufsize_bytes; stream->held_bytes -= adv_bytes; ``` And if winepulse is just a little bit faster than the audio server (does not matter PW or PA), it inevitably leads to pointer overlaps and therefore crackling. This patch proposes a throttling mechanism that is somewhat similar to winealsa - don't ever tell the application we have more space than we actually do. The problem could probably be resolved by making the fake clock perfectly mimic the audio server, but this is orders of magnitude more difficult. Winealsa achieves similar idea this way: `data_frames_played = min(stream->data_in_alsa_frames, avail); stream->held_frames -= data_frames_played;` The issue I am trying to fix is very real - it can cause crackling in any game you try. You don't have to hear the crackling to see that it's mathematically inevitable by logging the difference between held_bytes and pa_held_bytes. If it becomes smaller and goes negative - crackling is inevitable, because pointers will overlap. The issue is not tied to PW or PA specifically, I observed the behavior with both. In regards to how it interacts with MR https://gitlab.winehq.org/wine/wine/-/merge_requests/8628 - no issues in GoWR in my testing, unless you try enabling PROTON_LOG for pulse (which is very spammy in this game), and spam yes on all threads - which would also cause stream resets with unchanged winepulse, just later. Additionally, this patch has already been implemented in Proton GE and Proton CachyOS for about two months now - no issues and it has helped some people. There are not a lot of open issues regarding audio because unfortunately crackling is very underreported - you can look at GoWR protondb page before the 8628 MR - it definitely crackled, but many reports were not stating so. There are a lot of reports of crackling on virtually any game on protondb. You can also see people solve crackling issues for Arc Raiders (which I personally had myself before patching winepulse) by using winealsa: https://github.com/ValveSoftware/Proton/issues/9164#issuecomment-3529760335. One thing to look out for though - in CI spatialaudio tests will fail, but they fail literally the same way they do with winealsa - this is because there is nowhere for audio to go in a virtual environment, pa_held_bytes balloons while held_bytes drops, they overlap and held_bytes stops moving, and the tests start failing. No issues locally. I have previously tried tackling crackling in this pr: https://gitlab.winehq.org/wine/wine/-/merge_requests/9840 (although it was for underflows instead). My approach was admittedly incorrect, however it did help me discover this issue. Good audio is fundamental in my opinion, I would really love to see crackling-free audio for everyone regardless of proton version. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10792

3 11

[PATCH v2 0/2] MR10804: Draft: unicode: optimize memicmp_strW by doing case-sensitive comparision first
by Stephan Seitz (＠theHamsta) May 2, 2026

May 2, 2026

Call to slow `to_lower` can be avoided, if characters already match case-sensitive. This cuts the time for wine boot in half `17.165 s` -> `8879.9 ms` Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=59695 -- v2: registry: optimize `find_subkey` for sorted data https://gitlab.winehq.org/wine/wine/-/merge_requests/10804

2 7

[PATCH 0/1] MR10804: Draft: unicode: optimize memicmp_strW by doing case-sensitive comparision first
by Stephan Seitz (＠theHamsta) May 2, 2026

May 2, 2026

Call to slow `to_lower` can be avoided, if characters already match case-sensitive. This cuts the time for wine boot in half `17.165 s` -> `8879.9 ms` Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=59695 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10804

3 4

[PATCH 0/1] MR10803: ntdll: Use debugstr_wn instead of debugstr_w in nt_to_unix_file_name.
by Bernhard Übelacker (＠bernhardu) May 2, 2026

May 2, 2026

I noticed some logging like this, which looks like the second line had some unrelated characters appended: ``` 04c8:trace:file:NtCreateFile handle=0x7ffffec0ebe0 access=00010000 name=L"ones-6ae59e64850377ee5470c854761551ea.test" objattr=00001000 root=0x48 sec=(nil) io=0x7ffffec0eb80 alloc_size=(nil) attr=00000000 sharing=00000007 disp=1 options=00200000 ea=(nil).0x00000000 04c8:trace:file:nt_to_unix_file_name L"ones-6ae59e64850377ee5470c854761551ea.testI.TES" not found in . 04c8:trace:file:get_nt_and_unix_names L"ones-6ae59e64850377ee5470c854761551ea.test" -> ret c0000034 04c8:warn:file:NtCreateFile L"ones-6ae59e64850377ee5470c854761551ea.test" not found (c0000034) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10803

2 1

[PATCH 0/1] MR10802: windows.ui.core.textinput: Move Release below check_interface.
by Bernhard Übelacker (＠bernhardu) May 2, 2026

May 2, 2026

Followup to 3594073f1b. This is to avoid accessing already freed memory. CC: @alesliehughes, Do you see any problem in moving the release that way? [Test pattern page](https://test.winehq.org/data/patterns.html#windows.ui.core.textinput:… <details> <summary>ASan details [gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/261890#L2498) </summary> ``` ==windows.ui.core.textinput_test.exe==1836==ERROR: AddressSanitizer: heap-use-after-free on address 0x1005401201b0 at pc 0x000140003395 bp 0x7ffffe20f9a0 sp 0x7ffffe20f9e8 READ of size 8 at 0x1005401201b0 thread T0 #0 0x000140003394 in _check_interface /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:45:10 #1 0x000140001f9e in test_CoreTextServicesManager /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:162:5 #2 0x000140001068 in func_textinput /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:183:5 #3 0x000140005bd2 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #4 0x00014000564c in main /builds/bernhardu/wine/build64/../include/wine/test.h 0x1005401201b0 is located 0 bytes inside of 16-byte region [0x1005401201b0,0x1005401201c0) freed by thread T0 here: #0 0x6ffffe81da11 in free /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:78:3 #1 0x6ffffba254cc in core_text_services_manager_Release /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/services.c:168:9 #2 0x000140004446 in __x_ABI_CWindows_CUI_CText_CCore_CICoreTextServicesManager_Release /builds/bernhardu/wine/build64/include/windows.ui.text.core.h:4311:12 #3 0x000140001f7c in test_CoreTextServicesManager /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:160:5 #4 0x000140001068 in func_textinput /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:183:5 #5 0x000140005bd2 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #6 0x00014000564c in main /builds/bernhardu/wine/build64/../include/wine/test.h previously allocated by thread T0 here: #0 0x6ffffe81dc36 in calloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:98:3 #1 0x6ffffba24ff2 in core_text_services_manager_statics_GetForCurrentView /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/services.c:239:21 #2 0x0001400043e7 in __x_ABI_CWindows_CUI_CText_CCore_CICoreTextServicesManagerStatics_GetForCurrentView /builds/bernhardu/wine/build64/include/windows.ui.text.core.h:1526:12 #3 0x000140001f1b in test_CoreTextServicesManager /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:158:10 #4 0x000140001068 in func_textinput /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:183:5 #5 0x000140005bd2 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #6 0x00014000564c in main /builds/bernhardu/wine/build64/../include/wine/test.h SUMMARY: AddressSanitizer: heap-use-after-free /builds/bernhardu/wine/build64/../dlls/windows.ui.core.textinput/tests/textinput.c:45:10 in _check_interface ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10802

3 3

Re: [PATCH v2 0/1] MR10718: kernelbase: Add language resource search functionality - closed
by Craig Schulstad (＠NoDakker) May 2, 2026

May 2, 2026

This merge request was closed by Craig Schulstad. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10718

1 0

[PATCH 0/1] MR10801: msxml3: Fix missing document output in save().
by Nikolay Sivov (＠nsivov) May 2, 2026

May 2, 2026

Otherwise output does not reach the stream. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10801

2 1

[PATCH v2 0/7] MR10794: wininet: Attempt connecting to multiple host addresses and don't forcefully prefer ipv4.
by Paul Gofman (＠gofman) May 2, 2026

May 2, 2026

-- v2: wininet: Do not force ipv4 addresses. wininet: Try to connect to multiple server addresses. wininet: Introduce and use create_connect_socket(). wininet: Enclose ipv6 address string in square brackets. wininet: Store server address related data in the new server_addr_t structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/10794

2 8

[PATCH v8 0/1] MR10459: vbscript: Implement DateDiff built-in function.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Implement DateDiff(interval, date1, date2 [, firstdayofweek [, firstweekofyear]]) with support for all interval types: yyyy, q, m, y, d, w, ww, h, n, s. For yyyy/q/m the difference is computed from calendar fields via VarUdateFromDate. For d/y the day number difference is used. For w it is the day difference integer-divided by 7 (not affected by firstdayofweek). For ww it counts week boundary crossings based on firstdayofweek. For h/n/s the dates are converted to the respective unit and truncated before subtracting. Returns VT_I4 (Long). Null date arguments return Null; null interval or null firstdayofweek/firstweekofyear return VBSE_ILLEGAL_NULL_USE. -- v8: vbscript: Implement DateDiff built-in function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10459

1 0

[PATCH v21 0/1] MR10461: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v21: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v9 0/1] MR10509: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

-- v9: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

2 1

[PATCH v3 0/3] MR10783: vbscript: Match native semantics for empty parens on non-callable values
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Native VBScript distinguishes bare member access from with-parens access and rejects the latter on non-callable values: - `obj.scalarProp()` / `obj.arrayProp()` on a class instance variant property — error 5 (Invalid procedure call) - `x()` on a Dim scalar variable — error 13 (Type mismatch) - `arr()` on a Dim array — error 9 (Subscript out of range) -- v3: vbscript: Delegate do_icall is_call branch to variant_call. vbscript: Raise illegal-func-call on empty parens of class variant property. vbscript/tests: Cover empty parens on properties, Dim variables, and arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/10783

2 3

[PATCH v23 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v23: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 6

[PATCH v7 0/1] MR10459: vbscript: Implement DateDiff built-in function.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Implement DateDiff(interval, date1, date2 [, firstdayofweek [, firstweekofyear]]) with support for all interval types: yyyy, q, m, y, d, w, ww, h, n, s. For yyyy/q/m the difference is computed from calendar fields via VarUdateFromDate. For d/y the day number difference is used. For w it is the day difference integer-divided by 7 (not affected by firstdayofweek). For ww it counts week boundary crossings based on firstdayofweek. For h/n/s the dates are converted to the respective unit and truncated before subtracting. Returns VT_I4 (Long). Null date arguments return Null; null interval or null firstdayofweek/firstweekofyear return VBSE_ILLEGAL_NULL_USE. -- v7: vbscript: Implement DateDiff built-in function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10459

2 1

[PATCH v16 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v16: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

[PATCH 0/7] MR10794: wininet: Attempt connecting to multiple host addresses and don't forcefully prefer ipv4.
by Paul Gofman (＠gofman) May 1, 2026

May 1, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10794

3 12

Re: [PATCH v8 0/4] MR10680: scrrun: Implement IFile and IFolder Delete and Move methods. - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10680

1 0

Re: [PATCH v5 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569) - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

1 0

Re: [PATCH v5 0/1] MR10427: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10427

1 0

Re: [PATCH v2 0/2] MR10799: concrt140: Sync details.c file with msvcp90. - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10799

1 0

Re: [PATCH v3 0/1] MR10781: cmd: Fix handling of "ECHO.ON" - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10781

1 0

Re: [PATCH v9 0/1] MR10383: vbscript: Support element access on public array properties of class instances. - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10383

1 0

Re: [PATCH v10 0/4] MR10510: vbscript: Implement byte-string functions LenB, LeftB, RightB, MidB, InStrB, AscB, and ChrB. - approved
by Alexandre Julliard (＠julliard) May 1, 2026

May 1, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10510

1 0