- Wine-GitLab - list.winehq.org

[PATCH v3 0/6] MR10204: cfgmgr32: Get rid of setupapi dependency in DevObject* implementation (2/2).
by Rémi Bernon March 2, 2026

March 2, 2026

-- v3: cfgmgr32: Enumerate the registry keys directly in enum_dev_objects. cfgmgr32: Return LSTATUS from enum_dev_objects callback. cfgmgr32: Use the new helpers to read device interface properties. cfgmgr32: Use the new helpers to get device interface property keys. cfgmgr32: Return BOOL from devprop_filter_matches_properties. cfgmgr32: Initialize device_interface structs in DEV_OBJECT functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10204

1 7

[PATCH v21 0/1] MR10192: Draft: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Vishnunithyasoundhar S (＠svishnunithyasoundhar) March 2, 2026

March 2, 2026

``` Support the \\?\ prefix by skipping it during path resolution while preserving it in the output. Added specific handling for extended UNC paths (\\?\UNC\) to mirror standard UNC behavior, ensuring these paths are treated as network shares and not local devices. Some paths that use the extended length path were filtered out as UNC paths - but not all of them are UNC. There can be UNC path that use extended length path but not all extended lenght paths are UNC paths. ``` Signed-off-by: Vishnunithyasoundhar S svishnunithyasoundhar(a)gmail.com -- v21: fix: extended-file-name support https://gitlab.winehq.org/wine/wine/-/merge_requests/10192

2 1

[PATCH 0/2] MR9740: kernel32/tests: Add a test to show that GetNativeSystemInfo() returns PROCESSOR_AMD_X8664 on ARM64.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9740

5 10

[PATCH v3 0/4] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v3: msxml3/tests: Use broken() for Windows MSXML rejecting embedded XML declarations. libs/xml2: Simplify embedded XML handling; improve msxml3 test coverage. msxml3/tests: Add tests for embedded XML declarations inside elements. libs/xml2: Tolerate embedded XML declarations inside elements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

2 4

[PATCH v4 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Sreehari Anil (＠Sreehari425) March 2, 2026

March 2, 2026

Handle OAEP parameter setup failures when setting SPKI parameters and propagate GNUTLS_E_UNKNOWN_PK_ALGORITHM as STATUS_NOT_SUPPORTED For OAEP encrypt/decrypt, accept empty labels by only setting OAEP SPKI parameters when a non-empty label is provided Match native Windows OAEP(NULL) behavior for encryption by allowing size-only queries and returning STATUS_INVALID_PARAMETER for actual encryption when pPaddingInfo is NULL Add tests covering OAEP empty-label roundtrip and OAEP(NULL) size-query vs. encrypt behavior ##### Validation Built bcrypt_test from this branch(branch: bcrypt-rsa) Ran that same branch built test binary on: * Windows 11 (24H2): pass * Wine master: fail (OAEP cases) * Wine (bcrypt-rsa): pass -- v4: bcrypt: Improve RSA OAEP parameter handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10222

3 4

[PATCH v2 0/4] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v2: msxml3/tests: Use broken() for Windows MSXML rejecting embedded XML declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 4

[PATCH 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Thanks, I pointed out a few minor issues. Otherwise this looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130902

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > int ret; > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > + /* For OAEP decryption Windows requires a padding info structure with a hash > + * algorithm; label may be empty (pbLabel == NULL and cbLabel == 0). */ > if (!pad || !pad->pszAlgId) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } The comment is not very useful as it only states what the code does. Please remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130897

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { > + label.data = pad->pbLabel; > + label.size = pad->cbLabel; > + status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ); > + if (status == STATUS_NOT_SUPPORTED) status = STATUS_SUCCESS; /* Function not available, use defaults */ And here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130899

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ > + if (!pad) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } > + > + if (!pad->pszAlgId) > + { > + WARN( "padding hash not found\n" ); > + return STATUS_INVALID_PARAMETER; > + } Splitting these checks just to print a slightly different message is not worth it. This is unlikely to happen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130901

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return !params->output ? STATUS_SUCCESS : STATUS_BUFFER_TOO_SMALL; > } > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ And here as well. Comments should generally be used to point out non-obvious facts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130900

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return STATUS_INVALID_PARAMETER; > } > + > if ((dig = get_digest_from_id( pad->pszAlgId )) == GNUTLS_DIG_UNKNOWN) > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { Same here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130898

1 0

[PATCH v2 0/6] MR10204: cfgmgr32: Get rid of setupapi dependency in DevObject* implementation (2/2).
by Rémi Bernon March 2, 2026

March 2, 2026

-- v2: cfgmgr32: Enumerate the registry keys directly in enum_dev_objects. cfgmgr32: Return LSTATUS from enum_dev_objects callback. cfgmgr32: Use the new helpers to read device interface properties. cfgmgr32: Use the new helpers to get device interface property keys. cfgmgr32: Return BOOL from devprop_filter_matches_properties. cfgmgr32: Initialize device_interface structs in DEV_OBJECT functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10204

1 7

[PATCH 0/2] MR10215: Improve mouse in pointer message flags
by Huw Davies (＠huw) March 2, 2026

March 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10215

4 4

[PATCH v3 0/19] MR10221: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- v3: Edit loader.c - revise comment to attempt one more commit This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10221

1 0

[PATCH v2 0/18] MR10221: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- v2: kernelbase/loader.c: Add enhancement to search for language specific resources This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10221

1 0

[PATCH v2 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Sreehari Anil (＠Sreehari425) March 1, 2026

March 1, 2026

Handle OAEP parameter setup failures when setting SPKI parameters and propagate GNUTLS_E_UNKNOWN_PK_ALGORITHM as STATUS_NOT_SUPPORTED For OAEP encrypt/decrypt, accept empty labels by only setting OAEP SPKI parameters when a non-empty label is provided Match native Windows OAEP(NULL) behavior for encryption by allowing size-only queries and returning STATUS_INVALID_PARAMETER for actual encryption when pPaddingInfo is NULL Add tests covering OAEP empty-label roundtrip and OAEP(NULL) size-query vs. encrypt behavior ##### Validation Built bcrypt_test from this branch(branch: bcrypt-rsa) Ran that same branch built test binary on: * Windows 11 (24H2): pass * Wine master: fail (OAEP cases) * Wine (bcrypt-rsa): pass -- v2: bcrypt: Improve RSA OAEP parameter handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10222

2 1

[PATCH 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Sreehari Anil (＠Sreehari425) March 1, 2026

March 1, 2026

Handle OAEP parameter setup failures when setting SPKI parameters and propagate GNUTLS_E_UNKNOWN_PK_ALGORITHM as STATUS_NOT_SUPPORTED For OAEP encrypt/decrypt, accept empty labels by only setting OAEP SPKI parameters when a non-empty label is provided Match native Windows OAEP(NULL) behavior for encryption by allowing size-only queries and returning STATUS_INVALID_PARAMETER for actual encryption when pPaddingInfo is NULL Add tests covering OAEP empty-label roundtrip and OAEP(NULL) size-query vs. encrypt behavior ##### Validation Built bcrypt_test from this branch(branch: bcrypt-rsa) Ran that same branch built test binary on: * Windows 11 (24H2): pass * Wine master: fail (OAEP cases) * Wine (bcrypt-rsa): pass -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222

2 1

[PATCH 0/17] MR10220: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10220

1 1

[PATCH 0/17] MR10221: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10221

1 0

[PATCH v3 0/4] MR10196: Implement VariantCompare.
by eric pouech (＠epo) March 1, 2026

March 1, 2026

-- v3: propsys: Implement VariantCompare(). propsys/tests: Add tests for VariantCompare(). propsys: Add stub for VariantCompare(). include: Add definition for VariantCompare in propvarutil.h https://gitlab.winehq.org/wine/wine/-/merge_requests/10196

2 5

[PATCH 0/17] MR10219: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10219

1 1

[PATCH v13 0/15] MR10209: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "en-US", search for file "en-US/myapp.exe.mui", and if found, utilize that file for the source of resource data. -- v13: kernelbase/loader.c: Enhance resource search for multilanguage support https://gitlab.winehq.org/wine/wine/-/merge_requests/10209

2 15

[PATCH v4 0/8] MR10090: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 1, 2026

March 1, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- v4: kernelbase/loader.c: Add rudimentary support for multilanguage resource retrieval. https://gitlab.winehq.org/wine/wine/-/merge_requests/10090

2 9