- Wine-GitLab - list.winehq.org

Re: [PATCH v11 0/3] MR10225: libs/xml2: Tolerate embedded XML declarations inside elements.
by Nikolay Sivov (＠nsivov) March 2, 2026

March 2, 2026

> Test that loadXML() and load() correctly handle XML documents with > embedded <?xml?> declarations inside elements. Windows MSXML rejects > these documents (returns S_FALSE), while Wine's patched libxml2 > tolerates them and emits the embedded content as text nodes. This part is the problem. Tests included here do not point to an issue, but show that such documents are invalid both on Windows, and currently on Wine. We should not make them valid on Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10225#note_131003

1 0

[PATCH 0/1] MR7419: wininet: Fix crash when connection is null in NETCON_secure_connect
by Yongjie Yao (＠yaoyongjie) March 2, 2026

March 2, 2026

There will be crashed when connect is null, so we need avoid crash by checking connect value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7419

4 3

[PATCH 0/20] MR10227: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 2, 2026

March 2, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10227

2 2

[PATCH v6 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2
by pan hui (＠panhui) March 2, 2026

March 2, 2026

An application adds a new button using IFileDialogCustomize_AddPushButton. The application obtains IServiceProvider_iface through QueryInterface using the parameter IFileDialogCustomize_iface of the callback function IFileDialogControlEvents_OnButtonClicked, and then uses IServiceProvider_iface to pass IID_IFolderView and IID_IFolderView2 through IServiceProvider_fnQueryService to obtain IFolderView2. After that, it obtains the selected files and folders through IFolderView2_GetSelection. Currently, the implementation of obtaining IFolderView2 through IServiceProvider_fnQueryService is missing and needs to be added. -- v6: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2 https://gitlab.winehq.org/wine/wine/-/merge_requests/10193

3 2

[PATCH v4 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) March 2, 2026

March 2, 2026

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v4: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Select a default voice in synthesizer. windows.media.speech: Add more tests about default voice. windows.media.speech: Finish implementation of voice information view. windows.media.speech/tests: Add tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Add a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 10

Re: [PATCH v2 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values
by Elizabeth Figura (＠zfigura) March 2, 2026

March 2, 2026

On Sun Mar 1 11:59:02 2026 +0000, Vibhav Pant wrote: > Characteristics are how most IO in BLE is done, so I wanted to minimize > the roundtrips between PE and Unix as much as possible (given that the > wineserver IPC already going to make this slow). Plus, from my > understanding, most GATT services tend to limit the size of the values > to the default MTU (23 or so bytes). This way, most value reads should > be happening inline anyway. This, and a lot of things honestly, seem like premature optimization. Even if the cost of a Unix call weren't already small in comparison with the server I/O, or indeed the actual hardware I/O, I think it'd still be a mistake to be adding extra code to optimize before we have any evidence it matters. Same sort of thing about splitting up all the locks, which I've already talked about. It seems unlikely we need more than one; we don't _know_ we need more than one, and the extra complexity just makes things harder and risks deadlocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10208#note_130970

1 0

[PATCH 0/1] MR10226: change vkb hidraw handling to catchall
by Ty (＠chaos) March 2, 2026

March 2, 2026

now supports new modular hardware and user custom pid reason: in consulting with a large number of vkb device users it was found their pid is arbitrary for modular items (pid gets xor'd for each component plugged in), and devices can be software modified to have different numbers of axis/buttons, or user modified pid's. vkb have no known (to me) VID collisions so should be safe to just catch-all. Contingency for failure: if a hypothetical future device existed from vkb that didnt want hidraw (xinput gamepad), an explicit exemption for that device pid would be the solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10226

2 2

[PATCH v9 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v9: libs/xml2, msxml3/tests: Improve embedded XML declaration handling and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

[PATCH v8 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v8: libs/xml2, msxml3/tests: Improve embedded XML declaration handling and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

[PATCH v7 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v7: libs/xml2, msxml3/tests: Improve embedded XML declaration handling and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

[PATCH v6 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v6: libs/xml2, msxml3/tests: Improve embedded XML declaration handling and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

[PATCH v5 0/2] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v5: msxml3/tests: Add tests for embedded XML declarations inside elements. libs/xml2: Tolerate embedded XML declarations inside elements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 4

[PATCH v3 0/6] MR10204: cfgmgr32: Get rid of setupapi dependency in DevObject* implementation (2/2).
by Rémi Bernon March 2, 2026

March 2, 2026

-- v3: cfgmgr32: Enumerate the registry keys directly in enum_dev_objects. cfgmgr32: Return LSTATUS from enum_dev_objects callback. cfgmgr32: Use the new helpers to read device interface properties. cfgmgr32: Use the new helpers to get device interface property keys. cfgmgr32: Return BOOL from devprop_filter_matches_properties. cfgmgr32: Initialize device_interface structs in DEV_OBJECT functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10204

1 7

[PATCH v21 0/1] MR10192: Draft: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Vishnunithyasoundhar S (＠svishnunithyasoundhar) March 2, 2026

March 2, 2026

``` Support the \\?\ prefix by skipping it during path resolution while preserving it in the output. Added specific handling for extended UNC paths (\\?\UNC\) to mirror standard UNC behavior, ensuring these paths are treated as network shares and not local devices. Some paths that use the extended length path were filtered out as UNC paths - but not all of them are UNC. There can be UNC path that use extended length path but not all extended lenght paths are UNC paths. ``` Signed-off-by: Vishnunithyasoundhar S svishnunithyasoundhar(a)gmail.com -- v21: fix: extended-file-name support https://gitlab.winehq.org/wine/wine/-/merge_requests/10192

2 1

[PATCH 0/2] MR9740: kernel32/tests: Add a test to show that GetNativeSystemInfo() returns PROCESSOR_AMD_X8664 on ARM64.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9740

5 10

[PATCH v3 0/4] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v3: msxml3/tests: Use broken() for Windows MSXML rejecting embedded XML declarations. libs/xml2: Simplify embedded XML handling; improve msxml3 test coverage. msxml3/tests: Add tests for embedded XML declarations inside elements. libs/xml2: Tolerate embedded XML declarations inside elements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

2 4

[PATCH v4 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Sreehari Anil (＠Sreehari425) March 2, 2026

March 2, 2026

Handle OAEP parameter setup failures when setting SPKI parameters and propagate GNUTLS_E_UNKNOWN_PK_ALGORITHM as STATUS_NOT_SUPPORTED For OAEP encrypt/decrypt, accept empty labels by only setting OAEP SPKI parameters when a non-empty label is provided Match native Windows OAEP(NULL) behavior for encryption by allowing size-only queries and returning STATUS_INVALID_PARAMETER for actual encryption when pPaddingInfo is NULL Add tests covering OAEP empty-label roundtrip and OAEP(NULL) size-query vs. encrypt behavior ##### Validation Built bcrypt_test from this branch(branch: bcrypt-rsa) Ran that same branch built test binary on: * Windows 11 (24H2): pass * Wine master: fail (OAEP cases) * Wine (bcrypt-rsa): pass -- v4: bcrypt: Improve RSA OAEP parameter handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10222

3 4

[PATCH v2 0/4] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- v2: msxml3/tests: Use broken() for Windows MSXML rejecting embedded XML declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 4

[PATCH 0/3] MR10225: Draft: libs/xml2: Tolerate embedded XML declarations inside elements.
by lucas (＠luben93) March 2, 2026

March 2, 2026

Windows MSXML tolerates nested <?xml?> processing instructions inside elements, but libxml2 rejects them with XML_ERR_RESERVED_XML_NAME. When an embedded <?xml is encountered inside an element, consume everything up to the parent's closing tag and emit it via the SAX characters callback as a text node, matching Windows MSXML behavior where the content after the embedded <?xml?> is treated as text. This is needed for applications like Adobe Creative Cloud installer that use embedded XML declarations in their data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10225

3 3

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Thanks, I pointed out a few minor issues. Otherwise this looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130902

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > int ret; > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > + /* For OAEP decryption Windows requires a padding info structure with a hash > + * algorithm; label may be empty (pbLabel == NULL and cbLabel == 0). */ > if (!pad || !pad->pszAlgId) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } The comment is not very useful as it only states what the code does. Please remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130897

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { > + label.data = pad->pbLabel; > + label.size = pad->cbLabel; > + status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ); > + if (status == STATUS_NOT_SUPPORTED) status = STATUS_SUCCESS; /* Function not available, use defaults */ And here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130899

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ > + if (!pad) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } > + > + if (!pad->pszAlgId) > + { > + WARN( "padding hash not found\n" ); > + return STATUS_INVALID_PARAMETER; > + } Splitting these checks just to print a slightly different message is not worth it. This is unlikely to happen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130901

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return !params->output ? STATUS_SUCCESS : STATUS_BUFFER_TOO_SMALL; > } > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ And here as well. Comments should generally be used to point out non-obvious facts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130900

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) March 2, 2026

March 2, 2026

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return STATUS_INVALID_PARAMETER; > } > + > if ((dig = get_digest_from_id( pad->pszAlgId )) == GNUTLS_DIG_UNKNOWN) > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { Same here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130898

1 0